From patchwork Wed Dec 21 13:12:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?RGltaXRyaWplIE1pbG/FoWV2acSH?= X-Patchwork-Id: 35360 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp3515717wrn; Wed, 21 Dec 2022 05:14:10 -0800 (PST) X-Google-Smtp-Source: AMrXdXvZSTUHck7QM6AGu9m3/XCHdrcSeN7HTs6iMfKOKDv0Is5e4XScOQ0F31uZLflSRteqofnu X-Received: by 2002:a50:ee8c:0:b0:47e:6b3c:931a with SMTP id f12-20020a50ee8c000000b0047e6b3c931amr551777edr.10.1671628450726; Wed, 21 Dec 2022 05:14:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1671628450; cv=pass; d=google.com; s=arc-20160816; b=j/Hk17C7+jKDN0aJ1IQR6i7nwfYLDQ6Z9XnU+YG+CuK6YDeknBmayVqpOywNMisZtr Bnjw1c+La8hTj9TB/7y+hR+xDHs2WoDBm11D96Vj9jgQ0l6qx0kN7L0TiBFOSTa4NIYM nWJQRX0O8cKNIdxVGa5Y6JRv+JH6HFAbmGFMgceUP+L71vbFjMxNwgkgbIDUzg3QCVOV TtCPzO/MVI09+QupENG6lMU9q2bqQCYkkKotd+lZ0AuXgLpgsNFurGTgl63Wb/oXNPQ4 ZOuknwYkUhPrtBUojYZm0U9z1zeUMQwB2FPjVFvA+wO254NT7IUgB0vtIzUHnfMIxIfH Hq9Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version :content-transfer-encoding:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dmarc-filter:delivered-to; bh=j9aGxqqO2/mwQgWJsZ3oZHU/+vtyf1BpWpAhwq7/3Qg=; b=BZKk6HCCh4kSrH8unpDz+Og/8BXBH880N1K1R94WsDY+dD5Ylg/cDkqm2EhuXzuMq1 eEGGPqHy2cThd2NBrKFXBWYFJuTGMXFIxp45wrD2rySYe6c36zjk4CeUTaJBUSM1Ftn6 odAdOCiwm/s2fiY596Ds+u5qajUJU/+k20wUStIzWLMGpvXBMSupFkRzxl0YIYgvMbVD eTwBI12/VUX2u/Id20sdDqQaiy4WnwnmwGl8fPE1I4zYNoBDhgbF7MDoPP5UY7xr9xiR bCs7cv8f3i6h34Saspw2h+AJy7Cj/d88az3iHrfqHy1LwkkNGhW8WdsQ2liAL0SvvPiu ZKGQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@syrmia.com header.s=selector1 header.b=svvhcLlw; arc=pass (i=1 spf=pass spfdomain=syrmia.com dkim=pass dkdomain=syrmia.com dmarc=pass fromdomain=syrmia.com); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id f13-20020a056402354d00b0046109fd5943si3552047edd.544.2022.12.21.05.14.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Dec 2022 05:14:10 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@syrmia.com header.s=selector1 header.b=svvhcLlw; arc=pass (i=1 spf=pass spfdomain=syrmia.com dkim=pass dkdomain=syrmia.com dmarc=pass fromdomain=syrmia.com); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 92DC03870569 for ; Wed, 21 Dec 2022 13:13:17 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2109.outbound.protection.outlook.com [40.107.20.109]) by sourceware.org (Postfix) with ESMTPS id B0977385B502 for ; Wed, 21 Dec 2022 13:12:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B0977385B502 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=syrmia.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Syrmia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cooQCu9FXzwuzk2hIEjAcgiOwVUd5Ack8M15w5CvUtmYGRucwjdwUcB2SCcnzpSXccUKKJHK24W0Uia9+/vHAtcAa9HPtcsAi5bVnFrAhtTJwPzWIoNt+DynUKo9X0oOJiguz2KMyO4cpB72yxhpm/psqpPPl8C51wWj0pkQ1Ncax597pZbm3f8rgIY2pQylpClwC0OZx9mTVoLfHTjYF2zIjeYyo7fl1mg4TDqFCKqpu+FHGXvWe+fuBFWhapRNboRL8o3ERr6UgoonTXYNRJR5EKC8eWmr9Mgn3UWs9NMB2IlqurOCVjySRUs/QcGSqpWdfYzyIOo9mjsP/pAdVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j9aGxqqO2/mwQgWJsZ3oZHU/+vtyf1BpWpAhwq7/3Qg=; b=ay4pnsPEa9xWkuzGAa1XmCMghRFGXZFHbnZRhdXj2PVFzAz+0InRAtlcy4w1VmGwHcKrfipVKYOCb/rQ5P34y6M5LfgPgdC9qcSlfF72tUYluKOVZrp2ZbqlpDjrp4wN3N9ZaZrdVD6+Kk6UsmzjPld2VhehdXhIuI41eTDOnlXHXpxG/Y4MCcvUO6UKMpQ4zlocZNR0aU9afFRkkWyfmkwb+QNfL0hO132aJf7SQ/l29ozSDXyVagLL81Fyj/WNkzOx+LSIL/+Qltx1s/JMYQCpvSXN6Ck8wVypecDcXRbplPfQ9Ec6RwVLRimj4aTkdYSknkTuUQGlHIXNAbOCpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=syrmia.com; dmarc=pass action=none header.from=syrmia.com; dkim=pass header.d=syrmia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=syrmia.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j9aGxqqO2/mwQgWJsZ3oZHU/+vtyf1BpWpAhwq7/3Qg=; b=svvhcLlwxjm8ItJ0ek28WbQwGIqXziB4noL73yOD5FcWL03+STP1uephGXy6ES8WKVKrDS8+o1n9o5GHiA/85rAQQ0hxLNQ7Qgf95UlizFwdMATxmrs9JElcS2xxqy639UlMt7DtzzYGrC274RrTwlvCNrSTQ3MGLYUC4qJ6SVs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=syrmia.com; Received: from AM0PR03MB4882.eurprd03.prod.outlook.com (2603:10a6:208:fb::17) by PAXPR03MB8225.eurprd03.prod.outlook.com (2603:10a6:102:24c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 13:12:43 +0000 Received: from AM0PR03MB4882.eurprd03.prod.outlook.com ([fe80::6d55:c3be:1328:429b]) by AM0PR03MB4882.eurprd03.prod.outlook.com ([fe80::6d55:c3be:1328:429b%7]) with mapi id 15.20.5924.016; Wed, 21 Dec 2022 13:12:43 +0000 From: =?utf-8?b?RGltaXRyaWplIE1pbG/FoWV2acSH?= To: gcc-patches@gcc.gnu.org Cc: djordje.todorovic@syrmia.com, richard.guenther@gmail.com, jeffreyalaw@gmail.com, =?utf-8?b?RGltaXRyaWplIE1pbG/FoWV2acSH?= Subject: [PATCH 2/2] ivopts: Revert register pressure cost when there are enough registers. Date: Wed, 21 Dec 2022 14:12:14 +0100 Message-Id: <20221221131214.190579-3-dimitrije.milosevic@syrmia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221221131214.190579-1-dimitrije.milosevic@syrmia.com> References: <20221221131214.190579-1-dimitrije.milosevic@syrmia.com> X-ClientProxiedBy: VI1PR0102CA0022.eurprd01.prod.exchangelabs.com (2603:10a6:802::35) To AM0PR03MB4882.eurprd03.prod.outlook.com (2603:10a6:208:fb::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR03MB4882:EE_|PAXPR03MB8225:EE_ X-MS-Office365-Filtering-Correlation-Id: ee420656-e9e1-45ea-bbcd-08dae3550b71 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J5UI18o2paK0qUEP5gBkYugQ/jxtG1zENtufQNINv4GJ6QhPrrlE8GHITecbPxw350FecPCGizJdytAFBpFDu9ngjvaoQKFG1Ku0dYym9213AsEeeuASCyjpTCFsp7rrCkSPxWMW+lwUEKKEQ9Xq3aBNWGEHsbHKb002k2QZ07DmPVpav+L4O2DTkp8sB6bRQ4Tj6j/rZljSicSJQOadKWDJs4Y8/ATtDqtNXwYpNenzhytyU7LjRyePnXbIW13Qt5BQqbAjdgt889Vl3NiSaUshzvKE9Hy51hVp+PcICFscRsTdvX5ihpECFxHF1/P/EXfqcc0VvrqnaVtN7Db0ZuPkC6JdOTCRL+oqyZWj71niHWUOxcxlzMAV9gUt6yLZqx1Dz19EKUw3+tp0bAnpUPqaFabwDN73wXuqla+DE9lxbBKq9jODWMH+CmROiBqSjyiS16KyyFPD2ugFY4KRcZu2CtevrBgBRwnzxgRqFkESgm5DukOdxmmfpg0W+0Qrn+CzQf1i1tpvTwLQ/Ji/TqX+m4lHdAdaMayG8CMO7QELQD3wv4xArn7a9M2PSrD2H5tk8HIbqA38enIaHZwmpVlTDEzmFaqxSRrmm81wTL9l9UQFi6MzwbxpXysg85Sw3W50jLg5UH888nrYzCUdQ0ynQZ8z+9EjvcXPT2+cXuB6uHm24p57fLhL75zbcX034Bgc2oo86JbYIMsG1qEddQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR03MB4882.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(39840400004)(366004)(136003)(376002)(346002)(451199015)(2906002)(38350700002)(36756003)(38100700002)(86362001)(478600001)(107886003)(6666004)(6916009)(316002)(83380400001)(5660300002)(2616005)(6486002)(1076003)(6512007)(26005)(8676002)(52116002)(66476007)(66946007)(4326008)(66556008)(186003)(41300700001)(8936002)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /h+OTbYt6aMyD5jxlbluyZQh/0kSfl+IlT+oW0UcYAm5znFwaTzsQzJ8tEml/aFE9fk5lPkyuy7719FUYMkB69Iwh2RJh5mmXWQTAF3qLsgAwrOT3345wWlno6ZCerUPFsYVzHMSD3lCrJ7d+PQ6n3o55azcNqKtUreThnymYzwtj+/bFU5hFjTnhczAAPgAfyY6bpbHgQgBg/nZ5kFU1i9tmiza4X1u2WZ5ODAopHUxnBelITXV/vUR1w4NxmFDM62fkE4+gBgp6FrXQchenZSBBkNG86vspvmTb+jsZWG6JM/G5SNVYS865ufeowboolWJlA467FTjiQmkp3pTJ+3XJwSaWnIDxNbxevHVcZQjLQtHixsregZ5jgyywx5KkHCisZ+S7fqlDgY+iT9kOWUA4c71VR1VaSYSKqFsGqeP8j5h7nYJWtlgs7qW/OFl+6Ys6e9K+AK3v0okZq3KVj8aBdXVdfJc7k+a7ga6CdLhW0WAn4UUMLZHfGUjKgdBuH3aSySTSMkNaXcEMfqJwNYddU5lHgHPDwzKQ1xxfwVKWbmNz7CueZQiqIJry3DlJ9KswsDaD7G5V3Hi+jhs1K6Fd09eCmnmPYsxKGZqyethA3vFdPQvpccYZlOevZgDqNRkfn2u2xgA/yvjumEtv8ItBi0NLM6RJ1jIbpeP8li7MmZYTUj7YPsZTKmgXS+d9yEvqCAOPQ1fTDxJ6+GY3+RbZGn/zL3odRnueLkeAr4nmnEb7atzbrFA4Tjs4BYvaFTXuEhpQ/hEzzd7LHYE4qddFquQeLTxtaPCiIHdgq0ct1AoGszFm4+et7bKmTEijFXt79mPfZR5wdH5lhQn/xbtmm2XcEkfFl9R/SsTuCczT66gwuezumvcfbPNGSZqMPkZRc5MDjGpxBB18qhkmAWM/waX1vBIxY89PeLEweUujR26fGqXuGerZr+2ePN5xlBH7R9pP27lHotZN0hTxrHXz57U8BMdz0B3wlmBTtnhswld8YWzmolMwjVk0i5TCBn1ygDw3Tc5eUqSiK2tj7P19X3mWJVe3+FoTgs36iRC08aKp5w2gNEFQLKeWpAjyaZLLo0vpJ+jKkKv0BS9KceYfbSQiO3ZnKcxEhJj6T804dm08xlDIs90CjS6PDaC0nsmuntb9KfSHGF9AWWgq7YotywseQx7oioSoPTw1R1+ZQj7DXJYod+bGeZokyxedVXQWCYXoPD9MyCpOR/BQG2xR20Sd89gxRhX9seuHoZUveWGoAp0HMpw4vLTrjy8vK/I2LVIpwaLadEjSM7vGD4qFo3IjM/IlOTGM+T7qzrRW7fkoBpuelGsjQZDCiuelO9xvbRg1hFn5J5H7/WQqIX1XGiFkWgk8ZDDBxiiN/vk4zFco/TCZMhBdAUHHn4rAI/BiwY9tMH4xgVPFCT6DDRRtRLUOybnrh+uTKHO3luEMOrwHwKUMrY55ijFy8Xy/Jg6QRpobAhkhNdPIvVvUbkK3+E7gqi35bJCIUexKRuAXIrozCPief98RZLEbKF0JvI8ztHfTosn+TB816W/xEQoSEJq8dNBolb9oISDZpa1j7JF7F3B2VQentNDS1YmwS4ErGFdr06osSecAupxX/q0byv6Uy6fXh47Xo4dZpQ= X-OriginatorOrg: syrmia.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee420656-e9e1-45ea-bbcd-08dae3550b71 X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB4882.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2022 13:12:43.2105 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 19214a73-c1ab-4e19-8f59-14bdcb09a66e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WaZhMadCKGlsXUs+zc4+QnGwvpRMYApzc0dph1/LAHHxXURtXvsO6jUls/yEGY7tPuTGxV5QrD8Wa7KMR0RKqu9/4/8kZYxfGQwn2g39Vd4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB8225 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752829474147106981?= X-GMAIL-MSGID: =?utf-8?q?1752829474147106981?= When there are enough registers, the register pressure cost is unnecessarily bumped by adding another n_cands. This behavior may result in register pressure costs for the case when there are enough registers being higher than for other cases. When there are enough registers, the register pressure cost should be equal to n_invs + n_cands. This used to be the case before c18101f. gcc/ChangeLog: * tree-ssa-loop-ivopts.cc (ivopts_estimate_reg_pressure): Adjust. Signed-off-by: Dimitrije Milosevic --- gcc/tree-ssa-loop-ivopts.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/tree-ssa-loop-ivopts.cc b/gcc/tree-ssa-loop-ivopts.cc index 60c61dc9e49..3176482d0d9 100644 --- a/gcc/tree-ssa-loop-ivopts.cc +++ b/gcc/tree-ssa-loop-ivopts.cc @@ -6092,7 +6092,7 @@ ivopts_estimate_reg_pressure (struct ivopts_data *data, unsigned n_invs, /* If we have enough registers. */ if (regs_needed + target_res_regs < available_regs) - cost = n_new; + return n_new; /* If close to running out of registers, try to preserve them. */ else if (regs_needed <= available_regs) cost = target_reg_cost [speed] * regs_needed;