From patchwork Sun Dec 11 18:13:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iain Buclaw X-Patchwork-Id: 32199 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1868868wrr; Sun, 11 Dec 2022 10:15:08 -0800 (PST) X-Google-Smtp-Source: AA0mqf6pg+KpX0Gcda6IoqKQ1lsTX43hXY8ewT0+n2LfRIL3g958IkZG6HOWfbzcFUbzXJNX8bux X-Received: by 2002:a17:907:a68a:b0:7b9:ee36:6153 with SMTP id vv10-20020a170907a68a00b007b9ee366153mr11774973ejc.2.1670782507956; Sun, 11 Dec 2022 10:15:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670782507; cv=none; d=google.com; s=arc-20160816; b=GQnTz4EerSnSgT0oQWj+C0hnTMVEdjMpE1vM4/JcqkMwtTxLbaGcUnih8tY78y/KLP HO76xGBXwbNY38+xTaxFXUK6HIuHzhA58R6a+TdHGk0Y/0LBvaI/fxhM4LHgv1QlKwLy mV1T+k8iHrW/4n2hre0u9YxMcQkLlEfi9KCPaX2F0ELj+elGAr3jKBuEu5po1g1qxPyl rS3p/wnHU2y8P9gyKdBomFb1kK3s86DgrzU7vlipIkpIMdGTnmKV0wwctgTVKCXztZRM SBXl0iJMsH0URiwtZyZwIvzBgv2KMpkG2lfcz6PDNUxPkxD5Zwmmxstq8N1V1l2aOl9H ELKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=wOafGthr6A/y1Z2w6eCrNxcphEvF/rE62ksZtOl1Spc=; b=a3hf3X8Dt3N7k1HYz0VZKIltreb+34hjuFAMIL6jrt+OahbW9eJcLPP4zd7vOfXovC jnBFdNk1WQAsfgFIB32G+rBqjBDL3ljpaQDbwVkoTPol4Es63z6laxrBeZ6yDWk2hN2g U4JH8VwD4Qs9Fi4AzRRPTdd8f0HEKBjdMCkCHSUrP7NOEAbykElXbtfWk+4/ORQ+gJWf Rdl4eqhX5NXetHd5MPy7kxGV6uKkc43WfaVDvVnShzWgnl+7iYdPpYCRtlM0JGdexqGl CvkOC3B1S/tt8oygD3zBvVmHCdH3IoXJdVqr0bgRE2BgChzRJb+w/4yksv+SvLy4bo3C +enQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=p0eQqvFB; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id q11-20020a170906b28b00b007acc6769292si3562920ejz.365.2022.12.11.10.15.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Dec 2022 10:15:07 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=p0eQqvFB; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 716EC382FC85 for ; Sun, 11 Dec 2022 18:14:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 716EC382FC85 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1670782492; bh=wOafGthr6A/y1Z2w6eCrNxcphEvF/rE62ksZtOl1Spc=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=p0eQqvFB09pu10CYzxPzyY+O6WVW279bq+I37/vfSFcGorVqK20KOUdiRIGgPt+82 r44t4rRDJA2tAtRQ+J2TFYYR8M8aOE+0NnQSVHGlVWVoVazUxb3NeOmZ4VjjlwUzUr 1Mrr3WB2Xfm29b0P4x1lHE4E5z8txTf2DwWNBmvk= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [IPv6:2001:67c:2050:0:465::201]) by sourceware.org (Postfix) with ESMTPS id 1D0533835546 for ; Sun, 11 Dec 2022 18:14:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1D0533835546 Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4NVXvX4jGKz9sRP; Sun, 11 Dec 2022 19:14:00 +0100 (CET) To: gcc-patches@gcc.gnu.org Cc: Iain Buclaw Subject: [GCC-12][committed] d: Remove "final" and "override" from visitor method. Date: Sun, 11 Dec 2022 19:13:54 +0100 Message-Id: <20221211181354.2826180-1-ibuclaw@gdcproject.org> MIME-Version: 1.0 X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Iain Buclaw via Gcc-patches From: Iain Buclaw Reply-To: Iain Buclaw Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751942438644415513?= X-GMAIL-MSGID: =?utf-8?q?1751942438644415513?= Hi, This patch removes "final" and "override" from the OverloadSet visitor method. This was added by the backport of an ICE in r12-8969. While harmless, it was not until r13-758 that "final" and "override" were introduced to all visitor methods in the D front-end. Removing it from the release branch just for consistency with the rest of the file. Committed to releases/gcc-12. Regards, Iain. --- gcc/d/ChangeLog: * imports.cc (ImportVisitor::visit (OverloadSet *)): Remove "final" and "override" from visitor method. --- gcc/d/imports.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/d/imports.cc b/gcc/d/imports.cc index 4ce6f026b29..dfda2401ee8 100644 --- a/gcc/d/imports.cc +++ b/gcc/d/imports.cc @@ -161,7 +161,7 @@ public: } /* Build IMPORTED_DECLs for all overloads in a set. */ - void visit (OverloadSet *d) final override + void visit (OverloadSet *d) { vec *tset = NULL;