From patchwork Wed Nov 16 20:59:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 21273 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp59050wrr; Wed, 16 Nov 2022 13:01:31 -0800 (PST) X-Google-Smtp-Source: AA0mqf7VofTMGWtPo0n9jFwqkjY/bItAqtFHgWDzEg8TINjlKrWbDU86TDKKui0DuAASLzsN5cGM X-Received: by 2002:a17:907:c312:b0:78d:9caa:31b7 with SMTP id tl18-20020a170907c31200b0078d9caa31b7mr20115830ejc.263.1668632490992; Wed, 16 Nov 2022 13:01:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668632490; cv=none; d=google.com; s=arc-20160816; b=MGlwamkilQYvBz1VKYJ05heEU7k8gpeyiNQG6mNvnO9F7DA4u+V+e1mNgFUrNYZrvD jYSkqtWavPm8kc+LB3fOSkv1Xg0mZeCZF5KCSYI+Czktsg80RdtwBXIBIlqps4wK9uXS Gy1cy5LkILV36/cDj+2fMUwmdGpoScMY3bw7AapNKX3wWlPvR9kt3wq0X7BO7hpu6iGR IFyOm0l2BTV6CYr2RLtFKiJHEpQksedm5iS0MvNpq38L3m2cANN2pZBeAIuxfBkaCnF6 S3oZV4hl8povpF9P6wQdbsdwaSVLKaY/1dRcsqrv49haH2ZBLfHM96zINBU0u+GmBplF EadQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:to :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=npBLG/yyKAjzQfX9wXyYuVvOmF96j/uJSwtKHVtk5n4=; b=KSFuDm8zj4z6ukV4+sYBvN5XtZQnXpOxiYfmI+Ij8P5nCFCuQ6TjDUpBkv+pKsVS7K x6CDuARFo9g72WrPb9F2YSebhzIpSQGy3+S9gYrG+lvD8IH0HXyj0kUu7UgP80FkPyrv 49H9QpykJlOpl6B/rpSmiEqI246r8K9Z8BTUo8CIKX3orkHqsPDsgCq6YGbllXwWw0t/ gp6PWGLLeb4rDfsV5e10snj6dqsQsNFDEkmzrM7LUE7O1UmpwM7i21pBaPQky4Q0H2Qk f9sFKPz870FmGzpxHsK+rULENEr/sWF7xHV1qftNvfoTnWEk2REctbS48JnZAGSJMbtZ dgjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=PKq0rDFr; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id e12-20020a17090658cc00b0078d3ba4d567si13482023ejs.422.2022.11.16.13.01.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 13:01:30 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=PKq0rDFr; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ABB09396E01C for ; Wed, 16 Nov 2022 21:00:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ABB09396E01C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1668632442; bh=npBLG/yyKAjzQfX9wXyYuVvOmF96j/uJSwtKHVtk5n4=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=PKq0rDFrXYtPf6ZFOV2o894repHONGFPraU4auE9egCmgiunaqsqf/HI8KK+ZYUs9 pCsgzfdEuVd1oqsB3+36D3WqcCMDbTxiqCC5Dlb7yWv5tvaLxJ7O1WBi3AC97G+qgM vYRcOzZGoiWaL2v2s3+TySY1EGjokTNDBF3Q17KU= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9D066396DC3C for ; Wed, 16 Nov 2022 20:59:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9D066396DC3C Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-26-IoBgBTMyPbiMHozBjBRWGw-1; Wed, 16 Nov 2022 15:59:53 -0500 X-MC-Unique: IoBgBTMyPbiMHozBjBRWGw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1845A862FDF; Wed, 16 Nov 2022 20:59:53 +0000 (UTC) Received: from localhost (unknown [10.33.36.199]) by smtp.corp.redhat.com (Postfix) with ESMTP id D5BA9140EBF3; Wed, 16 Nov 2022 20:59:52 +0000 (UTC) To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [committed] libstdc++: Disable std::format of _Float128 if std::to_chars is innaccurate Date: Wed, 16 Nov 2022 20:59:50 +0000 Message-Id: <20221116205950.1420057-1-jwakely@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jonathan Wakely via Gcc-patches From: Jonathan Wakely Reply-To: Jonathan Wakely Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749687982508717736?= X-GMAIL-MSGID: =?utf-8?q?1749687982508717736?= Tested x86_64-linux. Pushed to trunk. -- >8 -- This restricts std::format support for _Float128 (and __float128) to targets where glibc provides __strfromf128 and so can give correct output. libstdc++-v3/ChangeLog: * include/std/format [__FLT128_DIG__] (_GLIBCXX_FORMAT_F128): Only support formatting _Float128 when glibc provides the functionality needed for accurate std::to_chars. --- libstdc++-v3/include/std/format | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libstdc++-v3/include/std/format b/libstdc++-v3/include/std/format index 204a1710aca..fb29f7e7835 100644 --- a/libstdc++-v3/include/std/format +++ b/libstdc++-v3/include/std/format @@ -1235,13 +1235,13 @@ namespace __format using __float128_t = long double; # define _GLIBCXX_FORMAT_F128 1 -#elif __FLT128_DIG__ && defined(__GLIBC_PREREQ) // see floating_to_chars.cc +#elif __FLT128_DIG__ && defined(_GLIBCXX_HAVE_FLOAT128_MATH) // Format 128-bit floating-point types using _Float128. using __float128_t = _Float128; # define _GLIBCXX_FORMAT_F128 2 -# if __cplusplus == 202002L || !defined(_GLIBCXX_HAVE_FLOAT128_MATH) +# if __cplusplus == 202002L // These overloads exist in the library, but are not declared for C++20. // Make them available as std::__format::to_chars. to_chars_result