From patchwork Tue Nov 8 08:42:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Marc_Poulhi=C3=A8s?= X-Patchwork-Id: 16940 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2570897wru; Tue, 8 Nov 2022 00:48:02 -0800 (PST) X-Google-Smtp-Source: AMsMyM4AugwOAfz50+jxQQUbrZz1CCXXWBHmoK/CQDDDnP7Ilnv9VQV+Ez3a0cx6wmLPoBRu+1kK X-Received: by 2002:a17:907:1b22:b0:741:8809:b4e6 with SMTP id mp34-20020a1709071b2200b007418809b4e6mr52158606ejc.84.1667897282213; Tue, 08 Nov 2022 00:48:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667897282; cv=none; d=google.com; s=arc-20160816; b=elDjcxtZIscKlDlL2OYeIvumySJcXBB6etdEWG/B5YJrzD5Y/KzLzin7D9whnXGaxc ZZv0giowlcaQehRf6HNZ3I1CVpVAy/1OAsryS8raYgANTd7nGo2resQTIRSh8+/I/HLa qbRu+dij95rcBYiOJxs6lPO+DPFqpwc+H8YdpuHIESr67CgB3OUCR/XxR9R69NBNG+EA GJ7CrPRYEMB/EMtyKXaWdapsIg/9txdTr+s1nIK+Ffk8MpO/bpzcV0el9W5qPK/Ijlr6 8vMF8aldAxblndCpFB82U5yNfD8YU2EHxXardP/vphu2siLyCpzBQKDrdhNp25OGux68 Ac9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=QvyC6GH08HG1v+NhjzK1k6NeEdfgzFtF/mA1ulRJ8Ec=; b=mp4Ci59aQEUGXSzQ679OZRIoJ3AKQe8wChqbKmTBDYnWJWpGHk8PBFgyow0CfGGSJl uUQKkODo+2LM8vFPiiIcER+QAAfKIBZLJ0+uBSYoII/ziSY2+KK47KVb1YyaWkG7ZzIk ZDrkKtYJ14XFtosWKRFaP8aCMBax3QxFCCcw5dl/XQ6Szn9x0+5YSvi3JqSMODUcpK9x ffk+88Z6DAQDu95BdWbU5zVTvwkp/G2VGQkXM9thux4mflZQCRqMq7Jmz/NCRJ8jqG2h HUl/6w4miQBzvzT5xnYD0dvaGBdQ9SQruvz4bLlqDPAAI8JTIR96TDUF2mFxpyZrlzU8 O65w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=cHR6GOx9; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id b14-20020a056402084e00b00461e5618305si14601462edz.280.2022.11.08.00.48.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 00:48:02 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=cHR6GOx9; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 988833857410 for ; Tue, 8 Nov 2022 08:46:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 988833857410 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1667897163; bh=QvyC6GH08HG1v+NhjzK1k6NeEdfgzFtF/mA1ulRJ8Ec=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=cHR6GOx94ZsOHx1ju4EjAh46pqAST5uprTLDYpqXiDImQGga4XdGwMjmdIkbyKnhx kNvhnaBx3/Y1A0MljaN8ZeYPzn6QZZlT8V4OOG9SaIcIgevNdKs1g+hxDS0wubM3B6 iz5M+dnW9J7NIsuK3HsKA7e913PXYvzLFxsGhwr0= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id 2A1703858C53 for ; Tue, 8 Nov 2022 08:42:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2A1703858C53 Received: by mail-wr1-x430.google.com with SMTP id a14so19793246wru.5 for ; Tue, 08 Nov 2022 00:42:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QvyC6GH08HG1v+NhjzK1k6NeEdfgzFtF/mA1ulRJ8Ec=; b=rCcxM3zlmFUMhmtl51ALD6Ggza1wtKYwKvo4nKtachOwIlwx1AdvBjfu9FuuCjGCcB x/LfIAZqWapITP3Y6t0gzIJoZtLUmrtt9EqUg9feakw7yvTUjEx3LPnTNHn0OBoIyr8Z 7lqpvdRlDE3gAW9spF+j/SmPUBmB36voRFhTneX14Wq9IRC0Qz/2SWEq+6Mkra2yUWwP NaGQ9LbYGN0A+DYU+9XrTR52bJwv8bkJ+3912qRHgSnCMRvI5FBmBBuGouUVINtiBR+h nAZH3oUW4LSEhOTaxpvX2eXV7XF2KcNaRqepf9vYz0pBVOnSm+35hwfIAXRrjJjVwKD5 1/Mg== X-Gm-Message-State: ACrzQf3et/iaXX3VBUDRnO0h1iezUP7+HzigUUR+whd1LhEWK/pZgCGg aO6cVBqq49gxT5Zh9j8g8oydGj3IRW8lyQ== X-Received: by 2002:a5d:548f:0:b0:236:ccb9:6749 with SMTP id h15-20020a5d548f000000b00236ccb96749mr29128599wrv.25.1667896931052; Tue, 08 Nov 2022 00:42:11 -0800 (PST) Received: from localhost.localdomain (static-176-191-105-132.ftth.abo.bbox.fr. [176.191.105.132]) by smtp.gmail.com with ESMTPSA id m8-20020a05600c4f4800b003c64c186206sm10867002wmq.16.2022.11.08.00.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 00:42:10 -0800 (PST) To: gcc-patches@gcc.gnu.org Cc: Piotr Trojanek Subject: [COMMITTED] ada: Cleanup local variable that is only set as an out parameter Date: Tue, 8 Nov 2022 09:42:07 +0100 Message-Id: <20221108084207.301124-1-poulhies@adacore.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: =?utf-8?q?Marc_Poulhi=C3=A8s_via_Gcc-patches?= From: =?utf-8?q?Marc_Poulhi=C3=A8s?= Reply-To: =?utf-8?q?Marc_Poulhi=C3=A8s?= Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748917060591524602?= X-GMAIL-MSGID: =?utf-8?q?1748917060591524602?= From: Piotr Trojanek Minor improvements; found experimenting with improved detection of unreferenced objects. gcc/ada/ * exp_spark.adb (SPARK_Freeze_Type): Refine type of a local object. * sem_ch3.adb (Derive_Subprograms): Remove initial value for New_Subp, which is in only written as an out parameter and never read. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/exp_spark.adb | 2 +- gcc/ada/sem_ch3.adb | 18 +++++++++--------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/gcc/ada/exp_spark.adb b/gcc/ada/exp_spark.adb index c89d604aa80..ba7bd7fe5d2 100644 --- a/gcc/ada/exp_spark.adb +++ b/gcc/ada/exp_spark.adb @@ -895,7 +895,7 @@ package body Exp_SPARK is procedure SPARK_Freeze_Type (N : Entity_Id) is Typ : constant Entity_Id := Entity (N); - Renamed_Eq : Node_Id; + Renamed_Eq : Entity_Id; -- Defining unit name for the predefined equality function in the case -- where the type has a primitive operation that is a renaming of -- predefined equality (but only if there is also an overriding diff --git a/gcc/ada/sem_ch3.adb b/gcc/ada/sem_ch3.adb index f6b852051dc..8f4e9f80eb8 100644 --- a/gcc/ada/sem_ch3.adb +++ b/gcc/ada/sem_ch3.adb @@ -16497,15 +16497,15 @@ package body Sem_Ch3 is -- Local variables - Alias_Subp : Entity_Id; - Act_List : Elist_Id; - Act_Elmt : Elmt_Id; - Act_Subp : Entity_Id := Empty; - Elmt : Elmt_Id; - Need_Search : Boolean := False; - New_Subp : Entity_Id := Empty; - Parent_Base : Entity_Id; - Subp : Entity_Id; + Alias_Subp : Entity_Id; + Act_List : Elist_Id; + Act_Elmt : Elmt_Id; + Act_Subp : Entity_Id := Empty; + Elmt : Elmt_Id; + Need_Search : Boolean := False; + New_Subp : Entity_Id; + Parent_Base : Entity_Id; + Subp : Entity_Id; -- Start of processing for Derive_Subprograms