From patchwork Thu Nov 3 21:00:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Reutner-Fischer X-Patchwork-Id: 15194 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a40e:b0:83:7221:86ba with SMTP id ck14csp1106676dyb; Thu, 3 Nov 2022 14:01:54 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6JkigMf0VLboo+E5ccUS4exDQue55jRvcEyMGx6OThS4eKAoaX2fU26cb9s9TyX6hg+Ggc X-Received: by 2002:aa7:c14f:0:b0:460:e1cc:2c29 with SMTP id r15-20020aa7c14f000000b00460e1cc2c29mr32672073edp.423.1667509314400; Thu, 03 Nov 2022 14:01:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667509314; cv=none; d=google.com; s=arc-20160816; b=pPfNUxgShqoelbECqLs9dcKuofQIqi3gcVdYS5ukpPLMYMbLSKxvJo98Netc2h4Gg7 vCIelcr1iigW6eNfXP83cuSrZR5x+R9Z3GvKJYQgJ4WERw7LPe6OHGrqKKIPhATLBQ79 97C6jV0vZHpR/Jge0KDJvKHMgvTXw4BG4J2z5h9jV6MtiwradcDOe2Wj7cVXdqZ3bEBX M2C8KnR/hJ1vYLVQq+Edk2OuNmiO2/dHEp49593/r+3+YsuqZKVq7venlqXhI2D8h9/c l3amQiXJznVck9xAPtDL5/r/TxFJ25qpND4YuA1i8OhQlswTymutPcprP5kzNRhzeDA+ AFdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:to :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=9kqxaJ8GxRTkJr4Wanhq5o3DWtl/h+yprXwrwGK9F2k=; b=FDE8tU1gB9EvAPn7ExJVhRmIzdPLhDBpSfoZRWFa6u2gm+L7z6D7jy9hsWE/+fuUuy UVkOsg8HaZAfkmxNgDZxdivY99xZQ6Vxkb5/kwlIW2t1hXizEkLFyf+x2IGeuwmmrtiO bjQc359qM4D51E+ru/fTXyDZumdqQp8UVfFOMXPHZSg8DbeHP7Kwvn/hZjFNmXdRK0iY hEHZGqsms6qHEYAeBtsvotfiFuX1KuTGvR/sQJh6vlCzr3VhAHAul1bGwOhYsDxgwQPe aVZuDRkdSvcYpToCE9zFbLD0oy1IISlHR5dbJaxKg+o5lFjEDN8M2DA0dPkxJ3Gl4eda Ey/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=O+FVzHm4; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id a16-20020aa7cf10000000b0045cfa0b1f46si2019709edy.11.2022.11.03.14.01.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Nov 2022 14:01:54 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=O+FVzHm4; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 725BC3858419 for ; Thu, 3 Nov 2022 21:01:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 725BC3858419 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1667509308; bh=9kqxaJ8GxRTkJr4Wanhq5o3DWtl/h+yprXwrwGK9F2k=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=O+FVzHm4BEAAtGqSPfEUJ3N3800zTw1qjEm2qay2bOtSgzbbzG8OD/Zm+JIMvw6RF GArE3QlNfi/vperFpILRcXkMBom12/VbsCoW+hqwsDcITdxEO2BicVBFlWWxmiVudd j3ey1CtrhWgObcja8x+mUbTn5KZhMc8ySPfdFMC0= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id 859443858C2D; Thu, 3 Nov 2022 21:01:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 859443858C2D Received: by mail-ed1-x52c.google.com with SMTP id 21so4947648edv.3; Thu, 03 Nov 2022 14:01:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9kqxaJ8GxRTkJr4Wanhq5o3DWtl/h+yprXwrwGK9F2k=; b=K/Xp62KM0/CzGX70DUtgweHDoq1c5Y5VWzmUPHdTnIFVCUpQlh+gTbjDdSJZ7myMYO n9DmZHuZcXCzvTCqlyBUch3fkWZA4cQYtav26OWGuIKzp5ntnvG06pGb2BJ+3h8GtmxC hNJwbyS0FOywsVcLY628mg/1CKAsyrU2WwLrb4xlw43NajLF53gG69UEov0Vzq7QkUif xBMdc0r48Ra3zhZN8PjqzGersumg9LBfhS8ku8Ule4eParR3hSy8TSvPZBSOVdHPBHR5 YQlIDweoW9vcH+C/yQHU2A56eR3z+rGRouCttn4F0STV3/uM9eAUpjpLlpdTjzuPtilo BaaQ== X-Gm-Message-State: ACrzQf0LlzdYI0bKUKzMiw/UJLifGQg/e5h08PtGZhHjfor7YjEmdWg+ ukiENVJUvFC82DAUiTBbeQ0= X-Received: by 2002:a05:6402:2949:b0:451:fabf:d88a with SMTP id ed9-20020a056402294900b00451fabfd88amr31078418edb.324.1667509260958; Thu, 03 Nov 2022 14:01:00 -0700 (PDT) Received: from nbbrfq ([2001:871:227:81c4:d7ff:3a0e:48da:5fe3]) by smtp.gmail.com with ESMTPSA id j26-20020a170906255a00b007789e7b47besm938015ejb.25.2022.11.03.14.01.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Nov 2022 14:01:00 -0700 (PDT) X-Google-Original-From: Bernhard Reutner-Fischer Received: from b by nbbrfq with local (Exim 4.96) (envelope-from ) id 1oqhKd-002AT6-02; Thu, 03 Nov 2022 22:00:59 +0100 To: gcc-patches@gcc.gnu.org Subject: [PATCH] Plug memory leak in attribute target_clones Date: Thu, 3 Nov 2022 22:00:49 +0100 Message-Id: <20221103210049.516886-1-aldot@gcc.gnu.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Bernhard Reutner-Fischer via Gcc-patches From: Bernhard Reutner-Fischer Reply-To: Bernhard Reutner-Fischer Cc: Bernhard Reutner-Fischer , Bernhard Reutner-Fischer Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748510246963733995?= X-GMAIL-MSGID: =?utf-8?q?1748510246963733995?= It looks like there was some memory leak in the handling of attribute target_clones, introduced in 5928bc2ec06d . Ok for trunk if testing passes? gcc/ChangeLog: * multiple_target.cc (expand_target_clones): Free memory. Signed-off-by: Bernhard Reutner-Fischer --- gcc/multiple_target.cc | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/gcc/multiple_target.cc b/gcc/multiple_target.cc index 67866a7c963..77e0f21dd05 100644 --- a/gcc/multiple_target.cc +++ b/gcc/multiple_target.cc @@ -390,19 +390,23 @@ expand_target_clones (struct cgraph_node *node, bool definition) for (i = 0; i < attrnum; i++) { char *attr = attrs[i]; - char *suffix = XNEWVEC (char, strlen (attr) + 1); - create_new_asm_name (attr, suffix); /* Create new target clone. */ tree attributes = make_attribute ("target", attr, DECL_ATTRIBUTES (node->decl)); + char *suffix = XNEWVEC (char, strlen (attr) + 1); + create_new_asm_name (attr, suffix); cgraph_node *new_node = create_target_clone (node, definition, suffix, attributes); + XDELETEVEC (suffix); if (new_node == NULL) - return false; + { + XDELETEVEC (attrs); + XDELETEVEC (attr_str); + return false; + } new_node->local = false; - XDELETEVEC (suffix); decl2_v = new_node->function_version (); if (decl2_v != NULL)