From patchwork Thu Oct 20 16:57:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 6303 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp217978wrr; Thu, 20 Oct 2022 09:58:23 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5IyRj9quFSj4nJ74J89ll46/97GA9y6ZwrRopgLc04gXb/VZIbeuunaCGKfuVI4K03YGf9 X-Received: by 2002:a17:906:dc89:b0:78d:5616:4c24 with SMTP id cs9-20020a170906dc8900b0078d56164c24mr11846973ejc.118.1666285103610; Thu, 20 Oct 2022 09:58:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666285103; cv=none; d=google.com; s=arc-20160816; b=Af8Ay2exAmYFhZrf4uTI5uS4YRujNbGoPvzHT79MwSq1KtToep3T6Bcx4MiJc7Rezv DzdlbVDmwAPCBeY/uEFXhEWpJc+AGl0Ef62qP6UYNDOmzjJbwGJdjaqIO2F5w3FLRBBY xcGnl5Mo9K961IzLbqXE6wPuHlckYuJ75Mgf1Gkc8ElyvscRmlS3heRlXjcB8sVjjNF7 gxKFV224kHHjpCZv6f3nMBr6aXtd77yQLwQOQxc1DI8pemPTmd/jlvaWln31R3U2P+PU 9VEhpwYA5hZzKMWGtR9+ypWv5oeIPIAD0nd4pKgB+w2tlPRFeJt7NK7/fNIvO5zwZoB/ ckig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:to :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=EKUNDSz3JWO5Hu126v2pBV+KgoD4BKh3MhuaHH9D59g=; b=Lw78k8AVMwxi7vGqwy41Sm5Yw/rJ3g1Jldc2xEcZ7xB3PHqS4vnulwjn2cxUvGAGmd eoIlfOfKKDDvDJC2BNIs8QZ93GnnAZsdba9/y/Wr5XPKRFKbb0/UztKBpbHLRTUcbVkN RHrtcgBk27jCuXPSvJx0qsusMeAqhzV3s534pH95uO/UMS7uOfqYoO+w2AkR54Y7KDBA mLdMHtvzbrRJofkZk/OIER+jJx8SLyp4khqi7Gn7vO3yorqp6khTGALCyjvE5seVBCju KnevomU0RhgiFtXBi9APtY23ryBbeySpAzzR9MUvwqBoubBu/Z/kMwYzqptuIGoBqqcT Ag9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="icZ/p8tX"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id sd41-20020a1709076e2900b0078c2c22d6cesi18367083ejc.70.2022.10.20.09.58.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 09:58:23 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="icZ/p8tX"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5A84C384D154 for ; Thu, 20 Oct 2022 16:58:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5A84C384D154 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1666285102; bh=EKUNDSz3JWO5Hu126v2pBV+KgoD4BKh3MhuaHH9D59g=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=icZ/p8tXY8e885y/RJpo+SBMb2dZ9OviLndttQk6tQ8kUwsxEwyML3+kmWAh1ybn9 I7bTv3gr9kzanFEIla74zhboi1ONeZ85CN3qYxBIgLHnfzddBxKuKIgt8D6l56WwgF Jjx1Brb8/aYEonDh4fBYLYo3TNtVT8m8JyW6Cbd0= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id 51221384D189 for ; Thu, 20 Oct 2022 16:57:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 51221384D189 Received: by mail-pj1-x102f.google.com with SMTP id u8-20020a17090a5e4800b002106dcdd4a0so4100487pji.1 for ; Thu, 20 Oct 2022 09:57:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EKUNDSz3JWO5Hu126v2pBV+KgoD4BKh3MhuaHH9D59g=; b=0Y71iw5nDqRQN+2bveR4H7RxCqDlm2QiuH3BqnRWrkjq4Hjh96yzIUdlFNFXuQ/fmR HTzfQDQKZWSPAJSzRYjlUQDlitmjvM/zznPVljMqiSFAAhK2OjQkti05CZD/VaCBV05X OtJ3dOvmV0z8sVc1ymvlv6F+dJ3gezGohYPXCE6OEox5PTUZCY93yvD2QjN43SS3aHAw wCkWlUGyHeSCoCzysLRGIv0kDNwvO/T9IPSIkdW3pGUDo38PFTvw0L1ALnQGC4R/Ob4b /DMeEabLy+fRRQNMq4GfL1GodPd1ipjD6PVTGZB+aKAffCXIuG5TV7Q1K/grQjn1/8E3 16Ug== X-Gm-Message-State: ACrzQf2hYEeFrumBujzKoQKU3A6HGcDfcW8ctUP7/VEccdx0Ry/QyUMU RNrvVdvaHe7O1h3S3WbsVj37d+LQqSw= X-Received: by 2002:a17:90b:38d1:b0:210:99f9:9712 with SMTP id nn17-20020a17090b38d100b0021099f99712mr8368898pjb.57.1666285056702; Thu, 20 Oct 2022 09:57:36 -0700 (PDT) Received: from gnu-tgl-3.localdomain ([172.56.30.186]) by smtp.gmail.com with ESMTPSA id j13-20020a170903024d00b0017f864355aasm13171384plh.164.2022.10.20.09.57.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 09:57:36 -0700 (PDT) Received: from gnu-tgl-3.. (localhost [IPv6:::1]) by gnu-tgl-3.localdomain (Postfix) with ESMTP id 5AFF7C032D for ; Thu, 20 Oct 2022 09:57:34 -0700 (PDT) To: gcc-patches@gcc.gnu.org Subject: [PATCH] Always use TYPE_MODE instead of DECL_MODE for vector field Date: Thu, 20 Oct 2022 09:57:34 -0700 Message-Id: <20221020165734.1113688-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 X-Spam-Status: No, score=-3024.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Gcc-patches" From: "H.J. Lu" Reply-To: "H.J. Lu" Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747226568563150808?= X-GMAIL-MSGID: =?utf-8?q?1747226568563150808?= commit e034c5c895722e0092d2239cd8c2991db77d6d39 Author: Jakub Jelinek Date: Sat Dec 2 08:54:47 2017 +0100 PR target/78643 PR target/80583 * expr.c (get_inner_reference): If DECL_MODE of a non-bitfield is BLKmode for vector field with vector raw mode, use TYPE_MODE instead of DECL_MODE. fixed the case where DECL_MODE of a vector field is BLKmode and its TYPE_MODE is a vector mode because of target attribute. Remove the BLKmode check for the case where DECL_MODE of a vector field is a vector mode and its TYPE_MODE is BLKmode because of target attribute. gcc/ PR target/107304 * expr.c (get_inner_reference): Always use TYPE_MODE for vector field with vector raw mode. gcc/testsuite/ PR target/107304 * gcc.target/i386/pr107304.c: New test. --- gcc/expr.cc | 3 +- gcc/testsuite/gcc.target/i386/pr107304.c | 39 ++++++++++++++++++++++++ 2 files changed, 40 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gcc.target/i386/pr107304.c diff --git a/gcc/expr.cc b/gcc/expr.cc index efe387e6173..9145193c2c1 100644 --- a/gcc/expr.cc +++ b/gcc/expr.cc @@ -7905,8 +7905,7 @@ get_inner_reference (tree exp, poly_int64_pod *pbitsize, /* For vector fields re-check the target flags, as DECL_MODE could have been set with different target flags than the current function has. */ - if (mode == BLKmode - && VECTOR_TYPE_P (TREE_TYPE (field)) + if (VECTOR_TYPE_P (TREE_TYPE (field)) && VECTOR_MODE_P (TYPE_MODE_RAW (TREE_TYPE (field)))) mode = TYPE_MODE (TREE_TYPE (field)); } diff --git a/gcc/testsuite/gcc.target/i386/pr107304.c b/gcc/testsuite/gcc.target/i386/pr107304.c new file mode 100644 index 00000000000..24d68795e7f --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr107304.c @@ -0,0 +1,39 @@ +/* { dg-do compile } */ +/* { dg-options "-O0 -march=tigerlake" } */ + +#include + +typedef union { + uint8_t v __attribute__((aligned(256))) __attribute__ ((vector_size(64 * sizeof(uint8_t)))); + uint8_t i[64] __attribute__((aligned(256))); +} stress_vec_u8_64_t; + +typedef struct { + struct { + stress_vec_u8_64_t s; + stress_vec_u8_64_t o; + stress_vec_u8_64_t mask1; + stress_vec_u8_64_t mask2; + } u8_64; +} stress_vec_data_t; + +__attribute__((target_clones("arch=alderlake", "default"))) +void +stress_vecshuf_u8_64(stress_vec_data_t *data) +{ + stress_vec_u8_64_t *__restrict s; + stress_vec_u8_64_t *__restrict mask1; + stress_vec_u8_64_t *__restrict mask2; + register int i; + + s = &data->u8_64.s; + mask1 = &data->u8_64.mask1; + mask2 = &data->u8_64.mask2; + + for (i = 0; i < 256; i++) { /* was i < 65536 */ + stress_vec_u8_64_t tmp; + + tmp.v = __builtin_shuffle(s->v, mask1->v); + s->v = __builtin_shuffle(tmp.v, mask2->v); + } +}