Message ID | 20221012115252.1881060-1-jwakely@redhat.com |
---|---|
State | Accepted, archived |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp2566605wrs; Wed, 12 Oct 2022 04:53:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6hFJQaNozie3bKLivXNv3pS51jo0QbXf+EcbTg6SIM/hsGhDzrRnWqmqcS07CV725k/2A2 X-Received: by 2002:a05:6402:156:b0:440:b458:93df with SMTP id s22-20020a056402015600b00440b45893dfmr28232118edu.337.1665575620726; Wed, 12 Oct 2022 04:53:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665575620; cv=none; d=google.com; s=arc-20160816; b=cXUPiI/1sn/KxYTq4Mld/iHqcgbCxcO/IywSjRhevjA/qSJ18QCUD50tanw3zed4am flXLc53leyt8eTxprIAZKCgg+ZaSsvWzSwNmMr4u7ynXwWca7Df5In/yVfjpc4zLbQsD UF9Rg/qvkElcdgRs0trZfDkNxqKwwm/tMVgVjP7ZfKffvkICRrGNw/zzQ+EFx41TQ1qd 4VXJEIqdS+PrRfzM+88/NUM5qOWogxaDHNiWf6PJ5WqBP9c5SEYAIH9T2ajfpuFEww7/ lW89GQZR5++h3BMh0oTL0etv4thwmnAzOrCCNNjRJgv09Rz1+YR1nkr4OlWkHFsC1910 7JDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:to :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=mMCjxVsV/Bk2+om0uwFwjSzMHTn+bn7mxGfOJnStLNU=; b=sA4n5Xiqa472/JALnimGrAtsLIkdCTTf5cJGv1ZbjlwB92/jHy1RpvnaQ4aJdmvyBT Y/S1Lbp6VyjkTWYEnBD+t+/kA39UFaqPdB62+xgEt2wOjuBlnnjPsx/GStInhY6RqmwF PJE2fhDge4LNDkSo3SCrLqDf7HsGVe6j4FQ6IR35SGNGVRVZfeyw98ovs4UFkKamGrv7 xIzkiAO5kM6mSGI0nyQ+P6gVe01NrH6312pnQUlgJczDO+JWjrMP/rBl0fYv7LXf1l72 OoG+rqMLMlO1WNuWt+tSmt3LdZswxW8AsO/EFs0Z2wG2gEycagzBMW+WGONQZuu9cHoh ePKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="piD/vWZw"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id k27-20020a50ce5b000000b00459fe88e946si14920497edj.451.2022.10.12.04.53.40 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 04:53:40 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="piD/vWZw"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E5C613851165 for <ouuuleilei@gmail.com>; Wed, 12 Oct 2022 11:53:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E5C613851165 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1665575618; bh=mMCjxVsV/Bk2+om0uwFwjSzMHTn+bn7mxGfOJnStLNU=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=piD/vWZwcnlJ532QuOByP/zviRFQPUA/rGX2WZAqVsR6bwuSqbt4czpBDqkMpq4QD 1uV15C33OUHBFc5Zi/8Jkgik0VJDFoGD9cR+rLA0mUM1EV3SX1ZVBAP3N63GV5gr+R /mhvr6EGCURU/TQ/QsXt9qV3YZ5jshGFVQqegJBc= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 14C0038515E4 for <gcc-patches@gcc.gnu.org>; Wed, 12 Oct 2022 11:52:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 14C0038515E4 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-39-G9r9mfizPFiEt1thWurGYw-1; Wed, 12 Oct 2022 07:52:53 -0400 X-MC-Unique: G9r9mfizPFiEt1thWurGYw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2504329AB3EC for <gcc-patches@gcc.gnu.org>; Wed, 12 Oct 2022 11:52:53 +0000 (UTC) Received: from localhost (unknown [10.33.36.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id E3919200A4E7 for <gcc-patches@gcc.gnu.org>; Wed, 12 Oct 2022 11:52:52 +0000 (UTC) To: gcc-patches@gcc.gnu.org Subject: [PATCH] libgcc: Quote variable in Makefile.in Date: Wed, 12 Oct 2022 12:52:52 +0100 Message-Id: <20221012115252.1881060-1-jwakely@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: Jonathan Wakely via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: Jonathan Wakely <jwakely@redhat.com> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746482622356878973?= X-GMAIL-MSGID: =?utf-8?q?1746482622356878973?= |
Series |
libgcc: Quote variable in Makefile.in
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | success | Github commit url |
Commit Message
Jonathan Wakely
Oct. 12, 2022, 11:52 a.m. UTC
This isn't very important as the error is harmless, but it's easy to fix and so is one less thing that might confuse people when looking at build logs. OK for trunk? -- >8 -- If the xgcc executable has not been built (or has been removed by 'make clean') then the command to print the multilib dir fails, and so the MULTIOSDIR variable is empty. That then causes: /bin/sh: line 0: test: !=: unary operator expected We can avoid it by quoting the variable. libgcc/ChangeLog: * Makefile.in: Quote variable. --- libgcc/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 10/12/22 05:52, Jonathan Wakely via Gcc-patches wrote: > This isn't very important as the error is harmless, but it's easy to fix > and so is one less thing that might confuse people when looking at build > logs. > > OK for trunk? > > -- >8 -- > > If the xgcc executable has not been built (or has been removed by 'make > clean') then the command to print the multilib dir fails, and so the > MULTIOSDIR variable is empty. That then causes: > /bin/sh: line 0: test: !=: unary operator expected > > We can avoid it by quoting the variable. > > libgcc/ChangeLog: > > * Makefile.in: Quote variable. OK jeff
diff --git a/libgcc/Makefile.in b/libgcc/Makefile.in index 1fe708a93f7..6e2a0470944 100644 --- a/libgcc/Makefile.in +++ b/libgcc/Makefile.in @@ -310,7 +310,7 @@ CRTSTUFF_T_CFLAGS = MULTIDIR := $(shell $(CC) $(CFLAGS) -print-multi-directory) MULTIOSDIR := $(shell $(CC) $(CFLAGS) -print-multi-os-directory) -MULTIOSSUBDIR := $(shell if test $(MULTIOSDIR) != .; then echo /$(MULTIOSDIR); fi) +MULTIOSSUBDIR := $(shell if test "$(MULTIOSDIR)" != .; then echo /$(MULTIOSDIR); fi) inst_libdir = $(libsubdir)$(MULTISUBDIR) inst_slibdir = $(slibdir)$(MULTIOSSUBDIR)