diff mbox series

[committed] libstdc++: Adjust deduction guides for static operator() [PR106651]

Message ID 20220927110013.2378598-1-jwakely@redhat.com
State New, archived
Headers
Series [committed] libstdc++: Adjust deduction guides for static operator() [PR106651] |

Commit Message

Jonathan Wakely Sept. 27, 2022, 11 a.m. UTC 
  Tested x86_64-linux. Pushed to trunk.

-- >8 --

Adjust the deduction guides for std::function and std::packaged_task to
work with static call operators. This finishes the implementation of
P1169R4 for C++23.

libstdc++-v3/ChangeLog:

	PR c++/106651
	* include/bits/std_function.h (__function_guide_t): New alias
	template.
	[__cpp_static_call_operator] (__function_guide_static_helper):
	New class template.
	(function): Use __function_guide_t in deduction guide.
	* include/std/future (packaged_task): Use __function_guide_t in
	deduction guide.
	* testsuite/20_util/function/cons/deduction_c++23.cc: New test.
	* testsuite/30_threads/packaged_task/cons/deduction_c++23.cc:
	New test.
---
 libstdc++-v3/include/bits/std_function.h      | 25 ++++++++++++++++---
 libstdc++-v3/include/std/future               |  4 +--
 .../20_util/function/cons/deduction_c++23.cc  | 23 +++++++++++++++++
 .../packaged_task/cons/deduction_c++23.cc     | 23 +++++++++++++++++
 4 files changed, 70 insertions(+), 5 deletions(-)
 create mode 100644 libstdc++-v3/testsuite/20_util/function/cons/deduction_c++23.cc
 create mode 100644 libstdc++-v3/testsuite/30_threads/packaged_task/cons/deduction_c++23.cc
diff mbox series

Patch

diff --git a/libstdc++-v3/include/bits/std_function.h b/libstdc++-v3/include/bits/std_function.h
index 96918a04a35..f5423a3a5c7 100644
--- a/libstdc++-v3/include/bits/std_function.h
+++ b/libstdc++-v3/include/bits/std_function.h
@@ -697,12 +697,31 @@  _GLIBCXX_BEGIN_NAMESPACE_VERSION
     >
     { using type = _Res(_Args...); };
 
+#if __cpp_static_call_operator >= 202207L && __cpp_concepts >= 202002L
+  template<typename _StaticCallOp>
+    struct __function_guide_static_helper
+    { };
+
+  template<typename _Res, bool _Nx, typename... _Args>
+    struct __function_guide_static_helper<_Res (*) (_Args...) noexcept(_Nx)>
+    { using type = _Res(_Args...); };
+
+  template<typename _Fn, typename _Op>
+    using __function_guide_t = typename __conditional_t<
+      requires (_Fn& __f) { (void) __f.operator(); },
+      __function_guide_static_helper<_Op>,
+      __function_guide_helper<_Op>>::type;
+#else
+  template<typename _Fn, typename _Op>
+    using __function_guide_t = typename __function_guide_helper<_Op>::type;
+#endif
+
   template<typename _Res, typename... _ArgTypes>
     function(_Res(*)(_ArgTypes...)) -> function<_Res(_ArgTypes...)>;
 
-  template<typename _Functor, typename _Signature = typename
-	   __function_guide_helper<decltype(&_Functor::operator())>::type>
-    function(_Functor) -> function<_Signature>;
+  template<typename _Fn, typename _Signature
+	     = __function_guide_t<_Fn, decltype(&_Fn::operator())>>
+    function(_Fn) -> function<_Signature>;
 #endif
 
   // [20.7.15.2.6] null pointer comparisons
diff --git a/libstdc++-v3/include/std/future b/libstdc++-v3/include/std/future
index a1b2d7f1d3a..cf08c155a24 100644
--- a/libstdc++-v3/include/std/future
+++ b/libstdc++-v3/include/std/future
@@ -1649,8 +1649,8 @@  _GLIBCXX_BEGIN_NAMESPACE_VERSION
   template<typename _Res, typename... _ArgTypes>
     packaged_task(_Res(*)(_ArgTypes...)) -> packaged_task<_Res(_ArgTypes...)>;
 
-  template<typename _Fun, typename _Signature = typename
-	   __function_guide_helper<decltype(&_Fun::operator())>::type>
+  template<typename _Fun, typename _Signature
+	     = __function_guide_t<_Fun, decltype(&_Fun::operator())>>
     packaged_task(_Fun) -> packaged_task<_Signature>;
 #endif
 
diff --git a/libstdc++-v3/testsuite/20_util/function/cons/deduction_c++23.cc b/libstdc++-v3/testsuite/20_util/function/cons/deduction_c++23.cc
new file mode 100644
index 00000000000..17454ea4108
--- /dev/null
+++ b/libstdc++-v3/testsuite/20_util/function/cons/deduction_c++23.cc
@@ -0,0 +1,23 @@ 
+// { dg-options "-std=gnu++23" }
+// { dg-do compile { target c++23 } }
+
+#include <functional>
+
+template<typename T, typename U> struct require_same;
+template<typename T> struct require_same<T, T> { using type = void; };
+
+template<typename T, typename U>
+  typename require_same<T, U>::type
+  check_type(U&) { }
+
+void
+test_static_call_operator()
+{
+  struct F1 { static long operator()() { return 0; } };
+  std::function func1 = F1{};
+  check_type<std::function<long()>>(func1);
+
+  struct F2 { static float operator()(char, void*) noexcept { return 0; } };
+  std::function func2 = F2{};
+  check_type<std::function<float(char, void*)>>(func2);
+}
diff --git a/libstdc++-v3/testsuite/30_threads/packaged_task/cons/deduction_c++23.cc b/libstdc++-v3/testsuite/30_threads/packaged_task/cons/deduction_c++23.cc
new file mode 100644
index 00000000000..e36edfa0359
--- /dev/null
+++ b/libstdc++-v3/testsuite/30_threads/packaged_task/cons/deduction_c++23.cc
@@ -0,0 +1,23 @@ 
+// { dg-options "-std=gnu++23" }
+// { dg-do compile { target c++23 } }
+
+#include <future>
+
+template<typename T, typename U> struct require_same;
+template<typename T> struct require_same<T, T> { using type = void; };
+
+template<typename T, typename U>
+  typename require_same<T, U>::type
+  check_type(U&) { }
+
+void
+test_static_call_operator()
+{
+  struct F1 { static long operator()() { return 0; } };
+  std::packaged_task task1{ F1{} };
+  check_type<std::packaged_task<long()>>(task1);
+
+  struct F2 { static float operator()(char, void*) noexcept { return 0; } };
+  std::packaged_task task2{ F2{} };
+  check_type<std::packaged_task<float(char, void*)>>(task2);
+}