Message ID | 20220918201545.453296-7-mikael@gcc.gnu.org |
---|---|
State | Accepted, archived |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2302:b0:79:6ae5:3758 with SMTP id gv2csp1023944dyb; Sun, 18 Sep 2022 13:23:47 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6iLQxNkKrYdyF0UCcgz3wurGrjbzxIYap7YV3+TR8VxYd8D/gxtMAPR42zQ18CjhWvmVsw X-Received: by 2002:a17:907:86ab:b0:77f:f628:3ed7 with SMTP id qa43-20020a17090786ab00b0077ff6283ed7mr10572900ejc.71.1663532627212; Sun, 18 Sep 2022 13:23:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663532627; cv=none; d=google.com; s=arc-20160816; b=kPVyYWAW9TKJ1niLFZWv/w5GBTW/LLrZ/GLmd8c/7uuInMnucI6X8k7hcWbU7mzl7s zD+qAEmS3kUpNihrxh/MUOryVs/pbR/2kRv6BnVohgWE9feFurCAI6f3WaFCI6vjojkl /Cjz5FNRRpNGklQFoV1+cKb9ZC6/G7yTyPQ5ugAh1AcObg9JNb5BDJ7JE65oQdYLOnn5 3yqrFr4n1ygd71d8VPDRFNeDaOOkYLwxU8gg24HV5TQxYfgWUWP5CA51F2s3HK3AC9rE 8l4hX02r9czP9WQceaVpyujCItsiCwoI4Rs/5yBCi2qiH95EVfAYO6+3Styo2x5X2jnH iX4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=TY4tRe/YSalYcihOTimNrvjqZii699z4FtfL0Tze7ZQ=; b=tHIEvMBl6BsLOY8bx3m1b1EvoocEW7yF+6PNywpWJchH3kxeEWam4WAK1u4hAP4ljI Nh4Hi9zEc4Oi7DtuwMr2RvRKwpePM5H7jcfpaCvViDScELKeq58nHSxdvx+TLh0B0Zek 7ibmORgriF7O2+VpJSShEys1VgHSvOnJiSyqr2Epdi/yk+TcMWV2OySbND+C7RjvIS0G voPKfxYK+u1X5YK4BMsBiwwf8gXk/En6kOU6sEDy4xs5pnXwrQXoEeAWqphDjwIsXZUK 4bwdE+hROM5RlgfXrHjXCMYyB0LwUim/9RlnvN+A59WXlx5zoxuGjJWL/3U9QO4Fl95p z4Qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=PZo07Ajd; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id eb11-20020a0564020d0b00b00451f433ecd4si8214811edb.107.2022.09.18.13.23.46 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Sep 2022 13:23:47 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=PZo07Ajd; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2D8DF38301A9 for <ouuuleilei@gmail.com>; Sun, 18 Sep 2022 20:20:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2D8DF38301A9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1663532448; bh=TY4tRe/YSalYcihOTimNrvjqZii699z4FtfL0Tze7ZQ=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=PZo07AjdF9+pjycgbYjGeq4b/fQhga75w3K7G2UjBibn0qRQ7PM9vXFsw25cVPOkA mfs6JQsspUsbzouRdkGiWEAkPfqnE/Qw5u6ei/BOQgIUD418L4V4gU6Jmc8qF90p3t Rk2BlCli8K6stY8/BqvGhxD7qis2W45V4CyD1C0Q= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp.smtpout.orange.fr (smtp07.smtpout.orange.fr [80.12.242.129]) by sourceware.org (Postfix) with ESMTPS id BD32B385843E for <gcc-patches@gcc.gnu.org>; Sun, 18 Sep 2022 20:15:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BD32B385843E Received: from cyrano.home ([86.215.174.255]) by smtp.orange.fr with ESMTPA id a0hgorqvnjJi0a0hnokkEN; Sun, 18 Sep 2022 22:15:56 +0200 X-ME-Helo: cyrano.home X-ME-Auth: bW9yaW4tbWlrYWVsQG9yYW5nZS5mcg== X-ME-Date: Sun, 18 Sep 2022 22:15:56 +0200 X-ME-IP: 86.215.174.255 To: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org Subject: [PATCH v2 6/9] fortran: Support clobbering of SAVE variables [PR87395] Date: Sun, 18 Sep 2022 22:15:42 +0200 Message-Id: <20220918201545.453296-7-mikael@gcc.gnu.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220918201545.453296-1-mikael@gcc.gnu.org> References: <20220918201545.453296-1-mikael@gcc.gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: Mikael Morin via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: Mikael Morin <mikael@gcc.gnu.org> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1744340388243225730?= X-GMAIL-MSGID: =?utf-8?q?1744340388243225730?= |
Series |
fortran: clobber fixes [PR41453]
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patches-check | success | Github commit url |
Commit Message
Mikael Morin
Sept. 18, 2022, 8:15 p.m. UTC
This is in spirit a revert of: r9-3032-gee7fb0588c6361b4d77337ab0f7527be64fcdde2 That commit added a condition to avoid generating ICE with clobbers of variables with the SAVE attribute. The test added at that point continues to pass if we remove that condition now. PR fortran/87395 PR fortran/41453 gcc/fortran/ChangeLog: * trans-expr.cc (gfc_conv_procedure_call): Remove condition on SAVE attribute guarding clobber generation. --- gcc/fortran/trans-expr.cc | 2 -- 1 file changed, 2 deletions(-)
diff --git a/gcc/fortran/trans-expr.cc b/gcc/fortran/trans-expr.cc index 9b2832bdb26..d169df44a71 100644 --- a/gcc/fortran/trans-expr.cc +++ b/gcc/fortran/trans-expr.cc @@ -6527,8 +6527,6 @@ gfc_conv_procedure_call (gfc_se * se, gfc_symbol * sym, && !e->symtree->n.sym->attr.dimension && !e->symtree->n.sym->attr.pointer && !e->symtree->n.sym->attr.allocatable - /* FIXME - PR 87395 and PR 41453 */ - && e->symtree->n.sym->attr.save == SAVE_NONE && !e->symtree->n.sym->attr.associate_var && e->ts.type != BT_CHARACTER && e->ts.type != BT_DERIVED