[Ada] Fix detection of unused warning suppression
Commit Message
The comment for Warnings_Off says: "clients should generally not test
this flag directly, but instead use function Has_Warnings_Off".
Primarily a code cleanup, as this only affects minor a corner case.
Tested on x86_64-pc-linux-gnu, committed on trunk
gcc/ada/
* sem_ch13.adb (Validate_Unchecked_Conversions): Use
Has_Warnings_Off.
* sem_elab.adb (Check_Internal_Call_Continue): Likewise.
@@ -17726,7 +17726,9 @@ package body Sem_Ch13 is
begin
-- Skip if function marked as warnings off
- if Warnings_Off (Act_Unit) or else Serious_Errors_Detected > 0 then
+ if Has_Warnings_Off (Act_Unit)
+ or else Serious_Errors_Detected > 0
+ then
goto Continue;
end if;
@@ -18767,9 +18767,9 @@ package body Sem_Elab is
T : constant Entity_Id := Etype (First_Formal (E));
begin
if Is_Controlled (T) then
- if Warnings_Off (T)
+ if Has_Warnings_Off (T)
or else (Ekind (T) = E_Private_Type
- and then Warnings_Off (Full_View (T)))
+ and then Has_Warnings_Off (Full_View (T)))
then
goto Output;
end if;