diff mbox series

[Ada] Small cleanup in body of System.Value_R

Message ID 20220905072608.GA1174745@poulhies-Precision-5550
State New, archived
Headers
Series [Ada] Small cleanup in body of System.Value_R |

Commit Message

Marc Poulhiès Sept. 5, 2022, 7:26 a.m. UTC 
  This is mostly stylistic but also adds a couple of missing comments.

Tested on x86_64-pc-linux-gnu, committed on trunk

gcc/ada/

	* libgnat/s-valuer.adb (Scan_Decimal_Digits): Consistently avoid
	initializing local variables.
	(Scan_Integral_Digits): Likewise.
	(Scan_Raw_Real): Likewise and add a couple of comments.
diff mbox series

Patch

diff --git a/gcc/ada/libgnat/s-valuer.adb b/gcc/ada/libgnat/s-valuer.adb
--- a/gcc/ada/libgnat/s-valuer.adb
+++ b/gcc/ada/libgnat/s-valuer.adb
@@ -184,7 +184,7 @@  package body System.Value_R is
       UmaxB : constant Uns := Precision_Limit / Uns (Base);
       --  Numbers bigger than UmaxB overflow if multiplied by base
 
-      Precision_Limit_Reached : Boolean := False;
+      Precision_Limit_Reached : Boolean;
       --  Set to True if addition of a digit will cause Value to be superior
       --  to Precision_Limit.
 
@@ -198,7 +198,7 @@  package body System.Value_R is
       Temp : Uns;
       --  Temporary
 
-      Trailing_Zeros : Natural := 0;
+      Trailing_Zeros : Natural;
       --  Number of trailing zeros at a given point
 
    begin
@@ -209,12 +209,17 @@  package body System.Value_R is
          Precision_Limit_Reached := True;
       else
          Extra := 0;
+         Precision_Limit_Reached := False;
       end if;
 
       if Round then
          Precision_Limit_Just_Reached := False;
       end if;
 
+      --  Initialize trailing zero counter
+
+      Trailing_Zeros := 0;
+
       --  The function precondition is that the first character is a valid
       --  digit.
 
@@ -362,7 +367,7 @@  package body System.Value_R is
       UmaxB : constant Uns := Precision_Limit / Uns (Base);
       --  Numbers bigger than UmaxB overflow if multiplied by base
 
-      Precision_Limit_Reached : Boolean := False;
+      Precision_Limit_Reached : Boolean;
       --  Set to True if addition of a digit will cause Value to be superior
       --  to Precision_Limit.
 
@@ -383,6 +388,8 @@  package body System.Value_R is
       Scale := 0;
       Extra := 0;
 
+      Precision_Limit_Reached := False;
+
       if Round then
          Precision_Limit_Just_Reached := False;
       end if;
@@ -494,28 +501,32 @@  package body System.Value_R is
       After_Point : Boolean;
       --  True if a decimal should be parsed
 
-      Base_Char : Character := ASCII.NUL;
-      --  Character used to set the base. If Nul this means that default
+      Base_Char : Character;
+      --  Character used to set the base. If it is Nul, this means that default
       --  base is used.
 
-      Base_Violation : Boolean := False;
+      Base_Violation : Boolean;
       --  If True some digits where not in the base. The real is still scanned
       --  till the end even if an error will be raised.
 
+      Expon : Integer;
+      --  Exponent as an Integer
+
       Index : Integer;
       --  Local copy of string pointer
 
       Start : Positive;
+      --  Index of the first non-blank character
 
       Value : Uns;
       --  Mantissa as an Integer
 
-      Expon : Integer;
-
    begin
       --  The default base is 10
 
-      Base := 10;
+      Base           := 10;
+      Base_Char      := ASCII.NUL;
+      Base_Violation := False;
 
       --  We do not tolerate strings with Str'Last = Positive'Last