Message ID | 20220830133814.3238A3839045@sourceware.org |
---|---|
State | New, archived |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:ecc5:0:0:0:0:0 with SMTP id s5csp1838819wro; Tue, 30 Aug 2022 06:38:49 -0700 (PDT) X-Google-Smtp-Source: AA6agR7VyDBqgFjbWAqZO8aDdIkkAgmC1PdghRmZ//t7IxovvaoyDEAS2kPe92h5PyXPuqXD41Cb X-Received: by 2002:a17:907:762d:b0:73d:ad57:e037 with SMTP id jy13-20020a170907762d00b0073dad57e037mr17194437ejc.405.1661866729112; Tue, 30 Aug 2022 06:38:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661866729; cv=none; d=google.com; s=arc-20160816; b=dldTVnT5qn4F/BvqhM+YsKeneLN/Tmjlp3pNUyji3lmAOC0QaGRkiJz5nzyBIr6mGM rDm51sBzGy7GV5zqaLby6m6JzyN4S7UWE0jdDm3hbmAftYtIpmBDrJvxgrCzpbhFyBgo oPKoh3TRs/O7BEf/KtCEhZ/8p3NeD7P+BIv+O2YAivwD18CUutjZwqchYwBji56AxrCO wK8gs4SQOvFt9QJpysBN+UVpaezzxC3RSO0gorhxm2QaFDraBP83wYrQgaJr1gcUXUeT AeDgBESgpbZ+74rJR9VjZ++r5Vbb8iDUeGc3DG0sbFzYJdVzcWZYRJgBc8ReAl/Fl8mM KRUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:sender:errors-to:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :mime-version:user-agent:subject:to:date:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=4vvamtMdu3H6d216aWPRc7n7laQurEfO3E2sWjCageI=; b=CSwnlTy/lIX9OLMoYcM7cTT36xWbDg4EIN/gl0Le16JcFWRNgCaz62a9+nSqp61lTB k+x09K8dfIF65HrGOGoAiUN8Cex5sjFla0dUyJvewGt+x96nvlsTlobRPF+iLA6NHg8X TbMOzL5f5Mj6hOWu6brELy7DQYIKz9Qeb4Z8NZT/cSRwlELjo1i3aq1YuoIVBwTVTsht 2piWideCVewwTySMjDqNv/dsTWsFCfDGIjMrh2GdzeoPZFIqR+hSncFAw6xl4pxQpXjk 4EW+ibT8AuUYTz2CEZ4h3joe607/Q3O0NseRGNnsOAkFBoEdYQ6Pfj16PLLaH7zgahjP FKpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=J7SEf309; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id v17-20020a17090690d100b0073d9c7a6e93si7289194ejw.333.2022.08.30.06.38.48 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Aug 2022 06:38:49 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=J7SEf309; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3238A3839045 for <ouuuleilei@gmail.com>; Tue, 30 Aug 2022 13:38:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3238A3839045 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1661866694; bh=4vvamtMdu3H6d216aWPRc7n7laQurEfO3E2sWjCageI=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=J7SEf309DIlo5avQXlarpmfmDzEIYrMJhrVEeVlVzIrgI3pxY3VHpcRYI/pd8dmRN UNLyZkRky96LgceLH7enoZ+RPcUFxP/ubMvNLZVM9JGOU0vxE63VhChvJwnFsP9gBN 8JoCEk7JS0zzMNtmEaP47i/JEbtx2ilExFP6E+Ls= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id B2FB83852771 for <gcc-patches@gcc.gnu.org>; Tue, 30 Aug 2022 13:37:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B2FB83852771 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id CF4D41F90B for <gcc-patches@gcc.gnu.org>; Tue, 30 Aug 2022 13:37:27 +0000 (UTC) Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id CA7F62C141 for <gcc-patches@gcc.gnu.org>; Tue, 30 Aug 2022 13:37:26 +0000 (UTC) Date: Tue, 30 Aug 2022 13:37:26 +0000 (UTC) To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/73550 - apply MAX_NUM_CHAINS consistently User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: Richard Biener via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: Richard Biener <rguenther@suse.de> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Message-Id: <20220830133814.3238A3839045@sourceware.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1742593567643977653?= X-GMAIL-MSGID: =?utf-8?q?1742593567643977653?= |
Series |
tree-optimization/73550 - apply MAX_NUM_CHAINS consistently
|
|
Commit Message
Richard Biener
Aug. 30, 2022, 1:37 p.m. UTC
The MAX_NUM_CHAINS is applied once with <= and once with < which results in the chains not limited but analyis dropped completely. That's one issue in the PR. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/73550 * gimple-predicate-analysis.cc (predicate::init_from_control_deps): Do not apply MAX_NUM_CHAINS again. --- gcc/gimple-predicate-analysis.cc | 7 ------- 1 file changed, 7 deletions(-)
diff --git a/gcc/gimple-predicate-analysis.cc b/gcc/gimple-predicate-analysis.cc index f9ae8910a26..6f30d729df2 100644 --- a/gcc/gimple-predicate-analysis.cc +++ b/gcc/gimple-predicate-analysis.cc @@ -1674,13 +1674,6 @@ predicate::init_from_control_deps (const vec<edge> *dep_chains, if (num_chains == 0) return; - if (num_chains >= MAX_NUM_CHAINS) - { - if (dump_file) - fprintf (dump_file, "MAX_NUM_CHAINS exceeded: %u\n", num_chains); - return; - } - /* Convert the control dependency chain into a set of predicates. */ m_preds.reserve (num_chains);