From patchwork Tue Aug 23 10:12:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 670 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:ecc5:0:0:0:0:0 with SMTP id s5csp874255wro; Tue, 23 Aug 2022 03:13:00 -0700 (PDT) X-Google-Smtp-Source: AA6agR4aT9yuGVESCmmWH1Ld8JOK06Q24vq8/Pi4VO6hAfncXe7xYIZrJ6CH/7IDSGPHQDXiiAju X-Received: by 2002:a05:6402:428a:b0:42e:8f7e:1638 with SMTP id g10-20020a056402428a00b0042e8f7e1638mr3061546edc.228.1661249580183; Tue, 23 Aug 2022 03:13:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661249580; cv=none; d=google.com; s=arc-20160816; b=hx6DCTmI7PrQROm5SC1BGynFagnDa40oUv85/rbPZpPsscY1HA//Y9ajId33RYZuRv ho+7PrKI5/72sz2npGYJ1Ti8j0mycDe3pytfwNk9PWWIZnFBqSiI0luxRl0tzn/etPNa xG7wdYs7Ouaa2wLRUCLK/G3z0gPFFOeVWLAqXZBMvz90V6wq1NgfHR7RoIo3hl/Y8PE+ isadCMtGQFg4do313O0HCVOueTiiin0OEm6HhVrgjdInl43RBjAGuGX7DgL8A4PAoRFz jufc378JIqP4UlQK0Mm9qYdF+ngQ8Xes4//9f3hEcbU1fF+tSYg35A7XVsbXJOXRQnQk ZgcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:to :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=K7CYVr+Zhnv0PAVUjAPDpTO15+nAlskHGIH50geBlag=; b=xmxnKx/AYe6jJdKnBEeZws2dpb+BdQCqvc/WsO0fz7hZUeSGFNIR1/IuKsNp9gj/rI b58wAlCJ9UqKERvqfp3vnv8PFcLQZk6d86mLi0yIpOHULZ659qbqGssmxaxSleNJwLsQ Oo8U8S+1sro5UO9fgDTS0l4cIZlcUCKH4xh/hsG/Bwc85SwBH3aW9im79z7FiAZS0v1E f7LyT5VXLghRy0d1YZ3xfO3pg1e19VCs14XOXjFKlz+ol6pGI2zZj6M2rrQ1terNQXqg OUZ9Enm5we267Sl3pKrKY7WQDseVYKXNybsjPF3FB13wHCIA5MqQ2BwG5GZixKNeKw6i oFpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="bEIlR/sv"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id ga23-20020a1709070c1700b0072ed60fb78asi3233940ejc.548.2022.08.23.03.12.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Aug 2022 03:13:00 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="bEIlR/sv"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C168B3858290 for ; Tue, 23 Aug 2022 10:12:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C168B3858290 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1661249578; bh=K7CYVr+Zhnv0PAVUjAPDpTO15+nAlskHGIH50geBlag=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=bEIlR/svEJN8TgIZ9e4oKj9kxnnnMOEeD4BEekUIF92uIMoaBg/fE6d4M+qlMAdsT 67kR66hUREGRX1G9jcNN2LQyl3o62hVfmUjv3kHckwVszY1QM4lYYl+h8rkybfEkC9 68vYtV/+eOl3o4WRllB8tLeXi8kk1XeT6tUtIQH8= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 654A03858D32 for ; Tue, 23 Aug 2022 10:12:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 654A03858D32 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-451-BoqOT3O2OIGkpLtjT9Ksrw-1; Tue, 23 Aug 2022 06:12:11 -0400 X-MC-Unique: BoqOT3O2OIGkpLtjT9Ksrw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7F5133C10684; Tue, 23 Aug 2022 10:12:11 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.193.180]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F163F18EA8; Tue, 23 Aug 2022 10:12:10 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.17.1/8.17.1) with ESMTPS id 27NAC7kF874521 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 23 Aug 2022 12:12:07 +0200 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.17.1/8.17.1/Submit) id 27NAC75J874520; Tue, 23 Aug 2022 12:12:07 +0200 To: GCC patches Subject: [PATCH] Add newline when checking path profitability. Date: Tue, 23 Aug 2022 12:12:03 +0200 Message-Id: <20220823101203.874506-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Aldy Hernandez via Gcc-patches From: Aldy Hernandez Reply-To: Aldy Hernandez Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1741946439669166182?= X-GMAIL-MSGID: =?utf-8?q?1741946439669166182?= It looks like we're missing a newline for cases where we don't print anything. OK? gcc/ChangeLog: * tree-ssa-threadbackward.cc (possibly_profitable_path_p): Always add newline. (profitable_path_p): Same. --- gcc/tree-ssa-threadbackward.cc | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gcc/tree-ssa-threadbackward.cc b/gcc/tree-ssa-threadbackward.cc index 3218ad931ef..9725f50e639 100644 --- a/gcc/tree-ssa-threadbackward.cc +++ b/gcc/tree-ssa-threadbackward.cc @@ -719,7 +719,11 @@ back_threader_profitability::possibly_profitable_path_p gimple *stmt = gsi_stmt (gsi); if (gimple_call_internal_p (stmt, IFN_UNIQUE) || gimple_call_builtin_p (stmt, BUILT_IN_CONSTANT_P)) - return false; + { + if (dump_file && (dump_flags & TDF_DETAILS)) + fputc ('\n', dump_file); + return false; + } /* Do not count empty statements and labels. */ if (gimple_code (stmt) != GIMPLE_NOP && !is_gimple_debug (stmt)) @@ -821,6 +825,8 @@ back_threader_profitability::possibly_profitable_path_p && (m_n_insns * param_fsm_scale_path_stmts >= param_max_jump_thread_duplication_stmts)); + if (dump_file && (dump_flags & TDF_DETAILS)) + fputc ('\n', dump_file); return true; } @@ -947,6 +953,8 @@ back_threader_profitability::profitable_path_p (const vec &m_path, "non-empty latch\n"); return false; } + if (dump_file && (dump_flags & TDF_DETAILS)) + fputc ('\n', dump_file); return true; }