Message ID | 20220806194122.19633-1-palmer@rivosinc.com |
---|---|
State | New, archived |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6a10:20da:b0:2d3:3019:e567 with SMTP id n26csp975309pxc; Sat, 6 Aug 2022 12:42:41 -0700 (PDT) X-Google-Smtp-Source: AA6agR52dccLzIHJ+dX8jZF1zYsiMUbsxeV/Q1DZKlzwOrliSj13vA0JXRVqVkZAT+XzjlCFEA0y X-Received: by 2002:a17:906:9b0a:b0:730:d37b:4712 with SMTP id eo10-20020a1709069b0a00b00730d37b4712mr8584235ejc.537.1659814961574; Sat, 06 Aug 2022 12:42:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659814961; cv=none; d=google.com; s=arc-20160816; b=gkrTrYLlFmSXyRtBeKRp3MIobOwbd9ELeT1Cpm3QDK4GG2ApO4H0Hw19vnSxOdM4Ac 8jwRspuKvr3PNr6KaVJEUqYuZazYSCaeyM0UKbexdUaFEUpLt+/8AnboeLFgiFMn3Qzq cMwweB+wIlPhAu7++R2euaNgvbd4RLhMuiirfO+b9Qt2kd8YNL3yqmb3pZpYnrsxmGr0 EfmriQYWWg6Lcp1fIe4sILMg9kF0wh0PDnlLZ7qSzgV5TyTWnmsULYslGc2OtSwfYga4 iMcaQ6Zr4xM8hEQXhpa9WuI3odi0rH+TOBgokSgvnrG0nb8IAMpVKA70dIK4zT/O5J2t KIxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:to:from :content-transfer-encoding:mime-version:message-id:date:subject :dkim-signature:dmarc-filter:delivered-to; bh=n83aoXmwZZiVMHFuYtOM2fyS+EIJTxpYqs5AQHLcypE=; b=qhhcPywiJkSC3mAx8GMJCeHBbaegchaX05kwOKaeJZ+wH0oMUFQZ6n68hByLIr835B oa2ePbxKtHXlZJbtwee1pTHSAweUHCZiIFFDPzeo1kFtOv7n/EYchqf01yJ93q4PETL2 TrZ6aOEHF77a64wEWA5v94r3vilAwa/Ezg9T7UQTE1GrwnywuP1EmGVGfc6vddGLsLhP oJYQ5WZRKt/w4aGL+IaTcHFuXHlmPB3mLyXwHkdXbESShVEhs28bHs36qWwt1i75wIt3 dY1z2Pbqwa/VMREbmSRQL7fAi1P+psloxN7ph/IlahWLBd/bjDWiAnXAaHUgqgoRDvty tJTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@rivosinc-com.20210112.gappssmtp.com header.s=20210112 header.b=2NkIZlLT; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id nc23-20020a1709071c1700b0072f1f41bf94si136183ejc.244.2022.08.06.12.42.41 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Aug 2022 12:42:41 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=fail header.i=@rivosinc-com.20210112.gappssmtp.com header.s=20210112 header.b=2NkIZlLT; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7BBD63856DE7 for <ouuuleilei@gmail.com>; Sat, 6 Aug 2022 19:42:17 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by sourceware.org (Postfix) with ESMTPS id B870C3858430 for <gcc-patches@gcc.gnu.org>; Sat, 6 Aug 2022 19:41:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B870C3858430 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-oi1-x233.google.com with SMTP id c185so6167975oia.7 for <gcc-patches@gcc.gnu.org>; Sat, 06 Aug 2022 12:41:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=to:from:cc:content-transfer-encoding:mime-version:message-id:date :subject:from:to:cc; bh=n83aoXmwZZiVMHFuYtOM2fyS+EIJTxpYqs5AQHLcypE=; b=2NkIZlLTfb0YJBLEvbRgcf+Qz7YYrZvUlMWGP2PCfbXTJ/fF0d1yBAoTMMbUUCxRoz b1i5Yh5nIA4uuFjQeLzySPD6tpxs0f/VYa4KgAKNYmVwnHoBMvd09plD+paFlTlJpJ0M H7fZrJrol6j5RPagyNOy3ZgqwKUZC2InsEg81ZrlFM9m87DSphm9YNSlTB27/I2pPhVx QhlPP1DNi1po/PuAEqtUMtefykezvVQSuOrP5AlrfwQLpIF+F3JdpzOKr/cTC1/fLlRt rRxOvOO6Rvh4kOi/2wN+diWylClElLHF/HA2WvGpki23atonbT4RQo1kBubvsnR8aEpw 9T7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:from:cc:content-transfer-encoding:mime-version:message-id:date :subject:x-gm-message-state:from:to:cc; bh=n83aoXmwZZiVMHFuYtOM2fyS+EIJTxpYqs5AQHLcypE=; b=oUS6S98Lxi+tZk3gE9QvD4vIFHkdB2cBpFgRVc87GW4vEaQoGOnmv3EkSGE1Z4Zp8S t1Jj9YLVKyzjJ6WboZGe5PvsmsSrv70J7fWVjgDqiX7t9TdOWjGjkZ6fqoGiZ9iM4Ez7 gY9hTcTImL9Gs75aQD6uYva5hWQZJHc+t1gs+DT9okjGfZHiArTH4rKQUq5GJ8+0tVnR 3aogcEeeegEbAoPNtT7jkUkwsbv46fCyR6t//1RQf/h79Y2nE537bjDhz51kGFGbptZs GMTm8IkMOqsxpK3ozEK1EF0dAHVINhAF8UUgdTSdqzug1GO1rcQNCzGLSq2TT5vcRnRj WoVA== X-Gm-Message-State: ACgBeo1HBx1EU9xYpOH4QLdUjhSP+PfrYSVLq957jcBDOnz2xPAmo6kG s3v6/yRmHjL3SozyntBy9q6nEakNwMldaQ== X-Received: by 2002:a17:90b:4a06:b0:1f4:e4fc:91ed with SMTP id kk6-20020a17090b4a0600b001f4e4fc91edmr14016384pjb.152.1659814903287; Sat, 06 Aug 2022 12:41:43 -0700 (PDT) Received: from localhost ([50.221.140.186]) by smtp.gmail.com with ESMTPSA id i11-20020a17090332cb00b0016d1b708729sm5458398plr.132.2022.08.06.12.41.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Aug 2022 12:41:42 -0700 (PDT) Subject: [PATCH] RISC-V: Fix the sge<u> ..., x0, ... pattern Date: Sat, 6 Aug 2022 12:41:23 -0700 Message-Id: <20220806194122.19633-1-palmer@rivosinc.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Palmer Dabbelt <palmer@rivosinc.com> To: gcc-patches@gcc.gnu.org X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1740442132960460257?= X-GMAIL-MSGID: =?utf-8?q?1740442132960460257?= |
Series |
RISC-V: Fix the sge<u> ..., x0, ... pattern
|
|
Commit Message
Palmer Dabbelt
Aug. 6, 2022, 7:41 p.m. UTC
There's no operand 2 here, so referencing it doesn't make sense. I couldn't find a way to trigger bad assembly output so I don't have a test. gcc/ChangeLog PR target/106543 * config/riscv/riscv.md (sge<u>_<X:mode><GPR:mode>): Remove reference to non-existent operand. --- No new failures on the Linux multilibs on trunk. --- gcc/config/riscv/riscv.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
LGTM, that's apparently some kind of copy & paste error (from *slt<u> pattern) when we add this pattern. On Sun, Aug 7, 2022 at 3:42 AM Palmer Dabbelt <palmer@rivosinc.com> wrote: > > There's no operand 2 here, so referencing it doesn't make sense. I > couldn't find a way to trigger bad assembly output so I don't have a > test. > > gcc/ChangeLog > > PR target/106543 > * config/riscv/riscv.md (sge<u>_<X:mode><GPR:mode>): Remove > reference to non-existent operand. > --- > No new failures on the Linux multilibs on trunk. > --- > gcc/config/riscv/riscv.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/riscv/riscv.md b/gcc/config/riscv/riscv.md > index 0796f91dd30..ed1c7f241e6 100644 > --- a/gcc/config/riscv/riscv.md > +++ b/gcc/config/riscv/riscv.md > @@ -2386,7 +2386,7 @@ > (any_ge:GPR (match_operand:X 1 "register_operand" " r") > (const_int 1)))] > "" > - "slt%i2<u>\t%0,zero,%1" > + "slt<u>\t%0,zero,%1" > [(set_attr "type" "slt") > (set_attr "mode" "<X:MODE>")]) > > -- > 2.34.1 >
diff --git a/gcc/config/riscv/riscv.md b/gcc/config/riscv/riscv.md index 0796f91dd30..ed1c7f241e6 100644 --- a/gcc/config/riscv/riscv.md +++ b/gcc/config/riscv/riscv.md @@ -2386,7 +2386,7 @@ (any_ge:GPR (match_operand:X 1 "register_operand" " r") (const_int 1)))] "" - "slt%i2<u>\t%0,zero,%1" + "slt<u>\t%0,zero,%1" [(set_attr "type" "slt") (set_attr "mode" "<X:MODE>")])