From patchwork Fri Jul 22 23:54:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li, Pan2 via Gcc-patches" X-Patchwork-Id: 136 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f503:0:0:0:0:0 with SMTP id q3csp468531wro; Fri, 22 Jul 2022 16:55:23 -0700 (PDT) X-Google-Smtp-Source: AGRyM1utNRic6T1mObaZKCFA6DqBzW1nwtkdtGpmfAvUBYasBs5nqqDS44lGtYrsrhEoGiRJRzEX X-Received: by 2002:a17:907:7395:b0:72e:e6c4:53d9 with SMTP id er21-20020a170907739500b0072ee6c453d9mr1740398ejc.42.1658534123222; Fri, 22 Jul 2022 16:55:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658534123; cv=none; d=google.com; s=arc-20160816; b=iImuvNSdATR7wiJPMMEhwhrNWUdCugzXHvftK9owYWgBMNL2jnAqS5fq27oENG1sc/ cDAoib0scPn345ey1V+IYBJqGgNY3lNyvKMeYO85YKIEjDcWA8X3WIxYb7SQ4TdshtSs paNvE6FCjOXdOmwFZL0uKE9bH0VMf+uc63tShDd75/Ps50/GHaG90Onmu80NvyMZHYos UyyMkel8mKE2xR8JnKkIZJtW3knggpmfSwRIdMsG7pqNFiCh0QF8sozt8fc3JySo+5gS vVn3ksHUA8sCpVX2rL9C21OaRL68hYm8S3Ydbse3kJAPcGCMxfcS4fqBF3RtQuD+e11v eFTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:to :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=ncf3Z6EE4f7BAju1haLT2rWUVGZmRJepe4IHIwjoY7g=; b=DApxGF8lw6zmRI3XJpxxh65hLG4PtX9mcbSRzHuRCIMqYSneodUxn54LVqDvCD7Py5 L+vA5q6EiyAtPNDeUBAoXNi6ghGlUbRrcSh3nX36LUaCLJPEgul+S2Xbaie5RNTbo+ak hXQ2ZYocguP0Zv78XvDqF+RIUEkKy2exBA16TfJNXjObP9ys2+wKUPYQFi9E8gNZ8oJK ZOafxEjgQiCmDVJtIi5k6Zy4kB/jUVxFfdB8X5xgezGZzes4TOEH/m61md3hdc/bUHR4 QkihW3voyQHBAHO2MXJ1GZ+WSUfA8zsQAp2Qa0xmQuKwTldUtQ0WFCaz5nEurV7mI7bH Y3cg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=p5X5upFP; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id o15-20020a056402438f00b0043a75d68ae3si8212286edc.417.2022.07.22.16.55.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jul 2022 16:55:23 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=p5X5upFP; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C8F493857C62 for ; Fri, 22 Jul 2022 23:55:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C8F493857C62 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1658534121; bh=ncf3Z6EE4f7BAju1haLT2rWUVGZmRJepe4IHIwjoY7g=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=p5X5upFP0Yf8gRea/X0Zmr5uEIsIABPq3qn8+zbY0Dpi3J5D2RSQGiFwYu4JAzdwv bH6vLI7bz2T4abd9yZa03hbM6Fah0+FAI22DHl6ZNArVkj064HNXdJvyAkvPt9/BcI ZMwnRgjDYK32gRiLdFIc0zFHJTFuxy7miI3RBIN8= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B1B543858405 for ; Fri, 22 Jul 2022 23:54:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B1B543858405 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-561-xpSndqutPOWidfIfV1RX8w-1; Fri, 22 Jul 2022 19:54:38 -0400 X-MC-Unique: xpSndqutPOWidfIfV1RX8w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0AF72811E75 for ; Fri, 22 Jul 2022 23:54:38 +0000 (UTC) Received: from t14s.localdomain.com (unknown [10.2.16.236]) by smtp.corp.redhat.com (Postfix) with ESMTP id D7B22404754B; Fri, 22 Jul 2022 23:54:37 +0000 (UTC) To: gcc-patches@gcc.gnu.org Subject: [committed] analyzer: fix ICE in binding_cluster ctor [PR106401] Date: Fri, 22 Jul 2022 19:54:36 -0400 Message-Id: <20220722235436.1705578-1-dmalcolm@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Malcolm via Gcc-patches From: "Li, Pan2 via Gcc-patches" Reply-To: David Malcolm Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1739099076719692214?= X-GMAIL-MSGID: =?utf-8?q?1739099076719692214?= Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to trunk as r13-1806-g0fb35a45a28c67. gcc/analyzer/ChangeLog: PR analyzer/106401 * store.cc (binding_cluster::binding_cluster): Remove overzealous assertion; we're checking for tracked_p in store::get_or_create_cluster. gcc/testsuite/ChangeLog: PR analyzer/106401 * gcc.dg/analyzer/memcpy-2.c: New test. Signed-off-by: David Malcolm --- gcc/analyzer/store.cc | 1 - gcc/testsuite/gcc.dg/analyzer/memcpy-2.c | 8 ++++++++ 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/analyzer/memcpy-2.c diff --git a/gcc/analyzer/store.cc b/gcc/analyzer/store.cc index e3dabf300df..0b3fb370d1e 100644 --- a/gcc/analyzer/store.cc +++ b/gcc/analyzer/store.cc @@ -1107,7 +1107,6 @@ binding_cluster::binding_cluster (const region *base_region) : m_base_region (base_region), m_map (), m_escaped (false), m_touched (false) { - gcc_assert (base_region->tracked_p ()); } /* binding_cluster's copy ctor. */ diff --git a/gcc/testsuite/gcc.dg/analyzer/memcpy-2.c b/gcc/testsuite/gcc.dg/analyzer/memcpy-2.c new file mode 100644 index 00000000000..88ec84cb640 --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/memcpy-2.c @@ -0,0 +1,8 @@ +/* { dg-additional-options "-Wno-stringop-overflow" } */ + +void +main (int c, void *v) +{ + static char a[] = ""; + __builtin_memcpy (v, a, -1); +}