From patchwork Fri Jul 15 09:40:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li, Pan2 via Gcc-patches" X-Patchwork-Id: 11 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a98:d5ce:0:b0:178:cc93:bf7d with SMTP id g14csp251263eik; Fri, 15 Jul 2022 02:42:13 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uFJGBVEA+9nzvEwcEfdt7Eanu51fMVk1PESqgjZtZOlv/F1Q7V8bdrJXqzN4PVHkX5NiTx X-Received: by 2002:a17:907:2cc3:b0:722:e993:c420 with SMTP id hg3-20020a1709072cc300b00722e993c420mr12769371ejc.145.1657878133110; Fri, 15 Jul 2022 02:42:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657878133; cv=none; d=google.com; s=arc-20160816; b=cKbRN+lN7IaxuJwiZqQXL8yJRTxlUTM/6C/FLP6awzX0JI6nYMlI3mgGKRDcGfudxG 6pH/X5GWhdZ8J4Lj6gDX3jKmcSZHruxFymx2JovUlXSz1a0B95bVIS9l4yS6+MistnMm iQh545f8Yf3tNj1w18IRSmFOu8pdd43pXijDEy2RFSxLOKuQTNAVmtvpJQ+Q/12Hd6cg iXhH69CaRqbzBWsl6hARwTpXb92VFModM/h2gDqqwlCnLJOlT4kV6KsYCBlNRmn2yDPJ lR4eBepCubadyu83N63+r9iPkdZ+cM7m3WAW1wou7VN8gBJulDxxflTDws2FXlUbCyYs w96g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=JuCZRvEwMBftEA0fRnH18F6rRtTUjGpTzeztxCLk3PQ=; b=tsXSULakllXGvR5UK6crAGMJF/d9pTcYtVp4WLs06msRMIjHf+4WjTh6MMRqyyP8+V MRuZxE0ih3bO6YcOcYDHa7un9Mkjr75SqtNshDymOFIZrdS4hue22myDrkQgSH3U5jei UcYfh3QnM1sVJGqYIJsZZyzIkoHeiUbroUYwrJxmiptoWXYDtvEGndW2e+wFFf8BCTk3 DvNqdJUR5Ajm0EGw1QUTj5S9Ihl8TB3GwUHOG00WScxuwoKppnekc6Oere3vXjA+zt0u t6E5Vy0Qb+TJXxJbAvKtYlqYwsTixPw5B0pfCPg5Ng1emMst1+Bvngsi0+hQ+eVCEArI SCvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=NCLrB3f5; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id hd40-20020a17090796a800b0072b5adee784si6447842ejc.529.2022.07.15.02.42.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jul 2022 02:42:13 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=NCLrB3f5; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 49F7E385BAEF for ; Fri, 15 Jul 2022 09:41:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 49F7E385BAEF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1657878093; bh=JuCZRvEwMBftEA0fRnH18F6rRtTUjGpTzeztxCLk3PQ=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=NCLrB3f55g7FWTHL0OPUFIVeMWrvSI14bbEAt7hQoOh6IkcIg/qz0JdTDMXrPZgLy X9MJzFqljSajhr6iovFoi7ZAxgzCcgHKjIKO2Gj1RxJxrVpnwDQb/kaXf6sA8dWMSn uvEZbEvnB7pOOyDLVBkx34qcWBnUag8DrNwvWjjQ= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 44814385AE59 for ; Fri, 15 Jul 2022 09:40:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 44814385AE59 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-166-bI1OGMoeMi22jP-PnyG9Og-1; Fri, 15 Jul 2022 05:40:45 -0400 X-MC-Unique: bI1OGMoeMi22jP-PnyG9Og-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 99B983C1104D for ; Fri, 15 Jul 2022 09:40:45 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.193.172]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 50B2C2166B26; Fri, 15 Jul 2022 09:40:45 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.17.1/8.17.1) with ESMTPS id 26F9ehgo1011308 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 15 Jul 2022 11:40:43 +0200 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.17.1/8.17.1/Submit) id 26F9ehnU1011307; Fri, 15 Jul 2022 11:40:43 +0200 To: GCC patches Subject: [COMMITTED] Use pp_vrange for ranges in dump_ssaname_info. Date: Fri, 15 Jul 2022 11:40:35 +0200 Message-Id: <20220715094035.1011279-3-aldyh@redhat.com> In-Reply-To: <20220715094035.1011279-1-aldyh@redhat.com> References: <20220715094035.1011279-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Aldy Hernandez via Gcc-patches From: "Li, Pan2 via Gcc-patches" Reply-To: Aldy Hernandez Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1738411221273916148?= X-GMAIL-MSGID: =?utf-8?q?1738411221273916148?= This changes the ad-hoc dumping of ranges in the gimple pretty printer to use the pp_vrange utility function, which has the benefit of handling all range types going forward and unifying the dumping code. Instead of: # RANGE [0, 51] NONZERO 0x3f # RANGE ~[5, 10] we would now get: # RANGE [irange] long unsigned int [0, 51] NONZERO 0x3f # RANGE [irange] int [-MIN, 4][11, MAX] Tested on x86-64 Linux. gcc/ChangeLog: * gimple-pretty-print.cc (dump_ssaname_info): Use pp_vrange. --- gcc/gimple-pretty-print.cc | 32 ++++---------------------------- 1 file changed, 4 insertions(+), 28 deletions(-) diff --git a/gcc/gimple-pretty-print.cc b/gcc/gimple-pretty-print.cc index ebd87b20a0a..f18baec438a 100644 --- a/gcc/gimple-pretty-print.cc +++ b/gcc/gimple-pretty-print.cc @@ -30,6 +30,7 @@ along with GCC; see the file COPYING3. If not see #include "ssa.h" #include "cgraph.h" #include "gimple-pretty-print.h" +#include "value-range-pretty-print.h" #include "internal-fn.h" #include "tree-eh.h" #include "gimple-iterator.h" @@ -2335,35 +2336,10 @@ dump_ssaname_info (pretty_printer *buffer, tree node, int spc) if (!POINTER_TYPE_P (TREE_TYPE (node)) && SSA_NAME_RANGE_INFO (node)) { - wide_int min, max, nonzero_bits; - value_range r; - + Value_Range r (TREE_TYPE (node)); get_global_range_query ()->range_of_expr (r, node); - value_range_kind range_type = r.kind (); - if (!r.undefined_p ()) - { - min = wi::to_wide (r.min ()); - max = wi::to_wide (r.max ()); - } - - // FIXME: Use irange::dump() instead. - if (range_type == VR_VARYING) - pp_printf (buffer, "# RANGE VR_VARYING"); - else if (range_type == VR_RANGE || range_type == VR_ANTI_RANGE) - { - pp_printf (buffer, "# RANGE "); - pp_printf (buffer, "%s[", range_type == VR_RANGE ? "" : "~"); - pp_wide_int (buffer, min, TYPE_SIGN (TREE_TYPE (node))); - pp_printf (buffer, ", "); - pp_wide_int (buffer, max, TYPE_SIGN (TREE_TYPE (node))); - pp_printf (buffer, "]"); - } - nonzero_bits = get_nonzero_bits (node); - if (nonzero_bits != -1) - { - pp_string (buffer, " NONZERO "); - pp_wide_int (buffer, nonzero_bits, UNSIGNED); - } + pp_string (buffer, "# RANGE "); + pp_vrange (buffer, &r); newline_and_indent (buffer, spc); } }