diff mbox series

[pushed] libcpp: Avoid pessimizing std::move [PR106272]

Message ID 20220713182414.58583-1-polacek@redhat.com
State New, archived
Headers
Series [pushed] libcpp: Avoid pessimizing std::move [PR106272] |

Commit Message

Marek Polacek July 13, 2022, 6:24 p.m. UTC 
  std::move in a return statement can prevent the NRVO:
<https://developers.redhat.com/blog/2019/04/12/understanding-when-not-to-stdmove-in-c>

PR106272 reports that we have two such cases in class label_text's
member functions.  We have -Wpessimizing-move that's supposed to detect
problematic std::move uses, but in this case it didn't trigger.  I've filed
PR106276 to track that.

Tested x86_64-pc-linux-gnu, applying to trunk.

	PR preprocessor/106272

libcpp/ChangeLog:

	* include/line-map.h (class label_text): Don't std::move in a return
	statement.
---
 libcpp/include/line-map.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


base-commit: f70c18524221dcefa6cd26cee7b55503181bd912
diff mbox series

Patch

diff --git a/libcpp/include/line-map.h b/libcpp/include/line-map.h
index c6379ce25b8..c434a246b13 100644
--- a/libcpp/include/line-map.h
+++ b/libcpp/include/line-map.h
@@ -1873,13 +1873,13 @@  public:
      longer-lived owner.  */
   static label_text borrow (const char *buffer)
   {
-    return std::move (label_text (const_cast <char *> (buffer), false));
+    return label_text (const_cast <char *> (buffer), false);
   }
 
   /* Create a label_text instance that takes ownership of BUFFER.  */
   static label_text take (char *buffer)
   {
-    return std::move (label_text (buffer, true));
+    return label_text (buffer, true);
   }
 
   /* Take ownership of the buffer, copying if necessary.  */