From patchwork Wed Aug 10 06:09:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Sayle X-Patchwork-Id: 459 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6a10:20da:b0:2d3:3019:e567 with SMTP id n26csp2963919pxc; Tue, 9 Aug 2022 23:09:38 -0700 (PDT) X-Google-Smtp-Source: AA6agR5h0mZVBPgusXdZi9HlyyCc1z215Wysj4d7cbJ4Tcj9o/ENjCuAMqlaZ8khewrUrOWSPrtT X-Received: by 2002:a17:907:6d16:b0:731:17b5:699 with SMTP id sa22-20020a1709076d1600b0073117b50699mr14878559ejc.23.1660111778572; Tue, 09 Aug 2022 23:09:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660111778; cv=none; d=google.com; s=arc-20160816; b=akFPLIQceOoy2MAtSzcedUczdXY2SSMnnii+ZIfP+BJ4SV6mxVGXTzGrWmil7cl0Op kLm1zZzrQ/V4gFWTVnwMdxpOF9Vv+Ig8l133XOAfyyGYT6617679vhIvIWdx3KL3ZHBv mNL5+TMR17vay08yH08ExZCwR+PbpMlB6K5eke0aIDFN6VUFasUSt1KzMxBgP7D7XrUQ FP9Z2cg19GukAIoKWEvypELW2lKE9xiA32y/sMe4zhvwqRjCC6dcn74GJc4R7JSQMXtL wY9zs8nGyU7djNygOXDcZ5Z4eC30ZSyg9lUnqz9xp0NuHVjjtZ0i2mKU+ObYlCU9Sfsr AFIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-language:thread-index :mime-version:message-id:date:subject:to:from:dkim-signature :dmarc-filter:delivered-to; bh=PWZGTttxovYzUAASg6erZshNps0vV4FLSvnxavvpK8M=; b=Knvfsb1tyurCmGryxV0T6S8QXVUED8u4jN9lK+Acox1TUEvCU8IX/tjE1N06jfmLsH tIMWAyXGtB+qVm6/GWCmlO7oclfeiOttLW8ZppuzjeNE19oFldAvqYZFHj+SEjQpSYUN FB7ePzMg2XzNEq/4K76nku6XWNqPaiNseefltvZ9t6FO+KdwCNdVsNsGf7iQ+EIb0COi 5d9tm3Hk9umrMC8lSxEFRJC1pfh7ye1mfCYzOSZE0IBJ8Xv5lbuymoIZBhcZcjuAaBwA kGrt4sIlAioKW3ntXN1B1avsE1qzR/HEnAwZQbVPeYBTKDHvQkd1bDbRGtbZi82MgBuB QbWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nextmovesoftware.com header.s=default header.b=kvuQ5Z3L; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id sc28-20020a1709078a1c00b0072f22713af6si3797368ejc.666.2022.08.09.23.09.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Aug 2022 23:09:38 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=fail header.i=@nextmovesoftware.com header.s=default header.b=kvuQ5Z3L; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7D5AE3856DDC for ; Wed, 10 Aug 2022 06:09:28 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from server.nextmovesoftware.com (server.nextmovesoftware.com [162.254.253.69]) by sourceware.org (Postfix) with ESMTPS id DBEA93858419 for ; Wed, 10 Aug 2022 06:09:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DBEA93858419 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=nextmovesoftware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nextmovesoftware.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nextmovesoftware.com; s=default; h=Content-Type:MIME-Version:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PWZGTttxovYzUAASg6erZshNps0vV4FLSvnxavvpK8M=; b=kvuQ5Z3L7+iGc3piEC5kc+QJhJ UQx8UmiN2zh6ijnSTw29kZtrSdmuWKl8UJAHaaCiJPF0YWgtctY/ex789+zlwzza6IzvCgzIV5khj vfdhUYLD8WmVGnwaLa2RTzrP2Bv5bLG+qeGOhIll3XSzxj8tBxu1M1Hv9BOho8/m87108YtpJk0Oq hVqJDiN6s6qSf60//Q+i+fbKxJQYf5xkfR8Ng1NwfeYvuSlCC35NHdwl0Iu/8zi1KTzW6gligTkKU CE3xuSc/jgcwdN7gVUSjkThEUZ+A/nS1HdKmZERiR1I5snROvfHR3DOmA35n35bKQNHLrhJZtQ63e ol+ZQMPQ==; Received: from host86-169-41-119.range86-169.btcentralplus.com ([86.169.41.119]:58107 helo=Dell) by server.nextmovesoftware.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oLets-0003XP-08 for gcc-patches@gcc.gnu.org; Wed, 10 Aug 2022 02:09:04 -0400 From: "Roger Sayle" To: Subject: [Committed] PR other/106575: Use "signed char" in new fold-eqandshift-4.c Date: Wed, 10 Aug 2022 07:09:02 +0100 Message-ID: <057e01d8ac7f$b0f48ab0$12dda010$@nextmovesoftware.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AdisfvdyB5HlT9qVTbWHC4lcdc1Frg== Content-Language: en-gb X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.nextmovesoftware.com X-AntiAbuse: Original Domain - gcc.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - nextmovesoftware.com X-Get-Message-Sender-Via: server.nextmovesoftware.com: authenticated_id: roger@nextmovesoftware.com X-Authenticated-Sender: server.nextmovesoftware.com: roger@nextmovesoftware.com X-Source: X-Source-Args: X-Source-Dir: X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1740753368176870602?= X-GMAIL-MSGID: =?utf-8?q?1740753368176870602?= My recently added testcase gcc.dg/fold-eqandshift-4.c, incorrectly assumed that "char" was "signed char", and hence fails on powerpc64 where this isn't the case. Fixed by making "signed char" explicit where needed in this test. Committed as obvious. 2022-08-10 Roger Sayle gcc/testsuite/ChangeLog * gcc.dg/fold-eqandshift-4.c: Use "signed char" explicitly. Apologies for the inconvenience. Roger diff --git a/gcc/testsuite/gcc.dg/fold-eqandshift-4.c b/gcc/testsuite/gcc.dg/fold-eqandshift-4.c index 42d5190703e..fbba438556e 100644 --- a/gcc/testsuite/gcc.dg/fold-eqandshift-4.c +++ b/gcc/testsuite/gcc.dg/fold-eqandshift-4.c @@ -1,14 +1,14 @@ /* { dg-do compile } */ /* { dg-options "-O2 -fdump-tree-optimized" } */ -int sr30eq00(char x) { return ((x >> 4) & 0x30) == 0; } -int sr30ne00(char x) { return ((x >> 4) & 0x30) != 0; } -int sr30eq20(char z) { return ((z >> 4) & 0x30) == 0x20; } -int sr30ne20(char z) { return ((z >> 4) & 0x30) != 0x20; } -int sr30eq30(char x) { return ((x >> 4) & 0x30) == 0x30; } -int sr30ne30(char x) { return ((x >> 4) & 0x30) != 0x30; } -int sr33eq33(char x) { return ((x >> 4) & 0x33) == 0x33; } -int sr33ne33(char x) { return ((x >> 4) & 0x33) != 0x33; } +int sr30eq00(signed char x) { return ((x >> 4) & 0x30) == 0; } +int sr30ne00(signed char x) { return ((x >> 4) & 0x30) != 0; } +int sr30eq20(signed char z) { return ((z >> 4) & 0x30) == 0x20; } +int sr30ne20(signed char z) { return ((z >> 4) & 0x30) != 0x20; } +int sr30eq30(signed char x) { return ((x >> 4) & 0x30) == 0x30; } +int sr30ne30(signed char x) { return ((x >> 4) & 0x30) != 0x30; } +int sr33eq33(signed char x) { return ((x >> 4) & 0x33) == 0x33; } +int sr33ne33(signed char x) { return ((x >> 4) & 0x33) != 0x33; } int ur30eq00(unsigned char z) { return ((z >> 4) & 0x30) == 0; } int ur30ne00(unsigned char z) { return ((z >> 4) & 0x30) != 0; }