From patchwork Thu Jan 5 14:10:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Sayle X-Patchwork-Id: 39603 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp318522wrt; Thu, 5 Jan 2023 06:10:37 -0800 (PST) X-Google-Smtp-Source: AMrXdXuJhMvIhdSywDtP4vb7O4ZC7MIGz15wWLaJaIeeex+FHpo1UM411W3t5DBogI1L+7HJRBvp X-Received: by 2002:a05:6402:88d:b0:46c:e615:9f61 with SMTP id e13-20020a056402088d00b0046ce6159f61mr43433138edy.25.1672927837321; Thu, 05 Jan 2023 06:10:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672927837; cv=none; d=google.com; s=arc-20160816; b=CJ+f8dbst6nfTtsgl6n87zGO5T/SP+GKKhr1D3gMQehc/0nBrH0mG/K8tNtLhSde14 U8OFJUEGaCJtTudzJB5U8xFxB1dtzdyA+J31cNLfAwhDJxOvf+VWgrCzuqN8pSwuezJE VqUetyYBYoRyUElcPJT9XwnJXavosC1jV0dna65QzgQqJjhVuYZgOxKMRPKAynThlhkG rl6Pd3940wnoCTm9VMF14D+3Jv4TLwQuSfLfPKM7i9NvQav6vr/slFfJQTsQKEn/T5T7 NerO2ODJ9pe9rZSLshx1kQBm/19jx39xM9mLcEZUzI8yDb9B9RAg8R9NRTgcG1rUY8e2 QW4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-language:thread-index :mime-version:message-id:date:subject:cc:to:from:dkim-signature :dmarc-filter:delivered-to; bh=euG1Q84tzO2Wr9eRZlZiVufrVAETA6GVM3mbGx6OoRE=; b=vdLGJxkf1j/CvIgTS36oz6pt3ioVqcivFDj+BdSw+70XrgUK+2jac/UWIjY2E3SRv8 3uQay8Jm2kwwYFFQ/h42vKAdTxvWRQ4sJWhJR367JeJ/ULZUFSmgMiT3EjPmmgXMj3gj UzPVGrTs0WDSwtEaYi+KOGqyQWIkcdqaYoode3qxNkA4kYmGPavjmfhEVGMzp3CpSycF hgK0wIWYqDTl/YYxkUJ/Khg+H60GMYUMXbrpjyd6ScDEg2nrhosnhI1hlo58M7Qa8tyA golzZj6+EjP1cM8R6Gyp1fApFc91be0fbha7KJic7FJwDzCITZqaGkYUlJrVsflTBjTH cgdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nextmovesoftware.com header.s=default header.b="iUXtA0O/"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id t10-20020a056402240a00b0048b0b329f9fsi16702935eda.416.2023.01.05.06.10.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 06:10:37 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=fail header.i=@nextmovesoftware.com header.s=default header.b="iUXtA0O/"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BFD3A3858425 for ; Thu, 5 Jan 2023 14:10:32 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from server.nextmovesoftware.com (server.nextmovesoftware.com [162.254.253.69]) by sourceware.org (Postfix) with ESMTPS id BD9C53858D35 for ; Thu, 5 Jan 2023 14:10:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BD9C53858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=nextmovesoftware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nextmovesoftware.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nextmovesoftware.com; s=default; h=Content-Type:MIME-Version:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=euG1Q84tzO2Wr9eRZlZiVufrVAETA6GVM3mbGx6OoRE=; b=iUXtA0O/8HDUdbdQ8vtu4SXugz KjgEMINirOVo6O01EvIE71XJSG5vva8B0hX5dqOeCyNiHrYzu8MLcmOdrtLct3Ko2o75IpS/JrRS5 l4QFU8WkmEPFB5IGaN1sEdTIBmiFfT0w7r8WZB4472FssHHSPZAhMHh5Hlg0MhSLfJFM9KAq2A0xc a6YKihyVt0CzMHwYbjz1V5vhgAqaHdxnLXaDbsPTWeiQvTFyy5d3XJ251O6e2pylVE2aFZC5GsDnR 1qUsAhZU07n4GlW1JDquoMx3Nz6uxQWSqjWnF/hAqXTHOYaNQIip619cZrYGNQETTabDqoPBQ+Bjd EK+BHplQ==; Received: from [185.62.158.67] (port=51169 helo=Dell) by server.nextmovesoftware.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pDQwX-0005FM-RQ; Thu, 05 Jan 2023 09:10:06 -0500 From: "Roger Sayle" To: "'GCC Patches'" Cc: "'Uros Bizjak'" Subject: [x86_64 PATCH] Introduce insvti_highpart define_insn_and_split. Date: Thu, 5 Jan 2023 14:10:04 -0000 Message-ID: <001501d9210f$694bed70$3be3c850$@nextmovesoftware.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AdkhDl4F+DFrwaBXQnuslcZR5qfMjQ== Content-Language: en-gb X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.nextmovesoftware.com X-AntiAbuse: Original Domain - gcc.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - nextmovesoftware.com X-Get-Message-Sender-Via: server.nextmovesoftware.com: authenticated_id: roger@nextmovesoftware.com X-Authenticated-Sender: server.nextmovesoftware.com: roger@nextmovesoftware.com X-Source: X-Source-Args: X-Source-Dir: X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754191980166383443?= X-GMAIL-MSGID: =?utf-8?q?1754191980166383443?= This patch adds a convenient post-reload splitter for setting/updating the highpart of a TImode variable, using the recently added split_double_concat infrastructure. For the new test case below: __int128 foo(__int128 x, unsigned long long y) { __int128 t = (__int128)y << 64; __int128 r = (x & ~0ull) | t; return r; } mainline GCC with -O2 currently generates: foo: movq %rdi, %rcx xorl %eax, %eax xorl %edi, %edi orq %rcx, %rax orq %rdi, %rdx ret with this patch, GCC instead now generates the much better: foo: movq %rdi, %rcx movq %rcx, %rax ret [which interestingly shows the deeper (ABI) issue that I'm trying to fix, this new define_insn_and_split being the next piece]. It turns out that the -m32 equivalent of this testcase, already avoids using explict orl/xor instructions, as it gets optimized (in combine) by a completely different path. Given that this idiom isn't seen in 32-bit code (and therefore this pattern wouldn't match), and also that the shorter 32-bit AND bitmask is represented as a CONST_INT rather than a CONST_WIDE_INT, this new define_insn_and_split is implemented for just TARGET_64BIT rather than contort a "generic" implementation using DWI mode iterators. This patch has been tested on x86_64-pc-linux-gnu with make bootstrap and make -k check, both with and without --target_board=unix{-m32}, with no new failures. Ok for mainline? Please let me know if you'd prefer a different pattern name [insv seemed better than mov]. 2023-01-05 Roger Sayle gcc/ChangeLog * config/i386/i386.md (any_or_plus): Move definition earlier. (*insvti_highpart_1): New define_insn_and_split to overwrite (insv) the highpart of a TImode register/memory. gcc/testsuite/ChangeLog * gcc.target/i386/insvti_highpart-1.c: New test case. Thanks in advance, Roger diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md index 890c4c8..9f3c62b 100644 --- a/gcc/config/i386/i386.md +++ b/gcc/config/i386/i386.md @@ -3401,6 +3401,31 @@ "mov{b}\t{%h1, %h0|%h0, %h1}" [(set_attr "type" "imov") (set_attr "mode" "QI")]) + +(define_code_iterator any_or_plus [plus ior xor]) +(define_insn_and_split "*insvti_highpart_1" + [(set (match_operand:TI 0 "nonimmediate_operand" "=ro,r,r,&r") + (any_or_plus:TI + (and:TI + (match_operand:TI 1 "nonimmediate_operand" "r,m,r,m") + (match_operand:TI 3 "const_scalar_int_operand" "n,n,n,n")) + (ashift:TI + (zero_extend:TI + (match_operand:DI 2 "nonimmediate_operand" "r,r,m,m")) + (const_int 64))))] + "TARGET_64BIT + && CONST_WIDE_INT_P (operands[3]) + && CONST_WIDE_INT_NUNITS (operands[3]) == 2 + && CONST_WIDE_INT_ELT (operands[3], 0) == -1 + && CONST_WIDE_INT_ELT (operands[3], 1) == 0" + "#" + "&& reload_completed" + [(clobber (const_int 0))] +{ + operands[4] = gen_lowpart (DImode, operands[1]); + split_double_concat (TImode, operands[0], operands[4], operands[2]); + DONE; +}) ;; Floating point push instructions. @@ -11418,7 +11443,6 @@ (set_attr "mode" "QI")]) ;; Split DST = (HI<<32)|LO early to minimize register usage. -(define_code_iterator any_or_plus [plus ior xor]) (define_insn_and_split "*concat3_1" [(set (match_operand: 0 "nonimmediate_operand" "=ro,r") (any_or_plus: diff --git a/gcc/testsuite/gcc.target/i386/insvti_highpart-1.c b/gcc/testsuite/gcc.target/i386/insvti_highpart-1.c new file mode 100644 index 0000000..4ae9ccf --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/insvti_highpart-1.c @@ -0,0 +1,12 @@ +/* { dg-do compile { target int128 } } */ +/* { dg-options "-O2" } */ + +__int128 foo(__int128 x, unsigned long long y) +{ + __int128 t = (__int128)y << 64; + __int128 r = (x & ~0ull) | t; + return r; +} + +/* { dg-final { scan-assembler-not "xorl" } } */ +/* { dg-final { scan-assembler-not "orq" } } */