[v2,0/8] Turn some C warnings into errors by default

Message ID	cover.1699983736.git.fweimer@redhat.com
Headers	Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 300F63858D20 From: Florian Weimer <fweimer@redhat.com> To: gcc-patches@gcc.gnu.org Cc: jason@redhat.com, jeffreyalaw@gmail.com, joseph@codesourcery.com, sam@gentoo.org Subject: [PATCH v2 0/8] Turn some C warnings into errors by default Message-ID: <cover.1699983736.git.fweimer@redhat.com> Date: Tue, 14 Nov 2023 18:50:11 +0100 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Precedence: list Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX
Series	Turn some C warnings into errors by default \| [v2,0/8] Turn some C warnings into errors by default [v2,1/8] Add tests for validating future C permerrors [v2,2/8] c: Turn int-conversion warnings into permerrors [v2,3/8] c: Turn -Wimplicit-function-declaration into a permerror [v2,5/8] c: Do not ignore some forms of -Wimplicit-int in system headers [v2,6/8] c: Turn -Wreturn-mismatch into a permerror [v2,7/8] c: Turn -Wincompatible-pointer-types into a permerror [v2,8/8] c: Add new -Wdeclaration-missing-parameter-type permerror

Message ID

cover.1699983736.git.fweimer@redhat.com

Headers

Received-SPF: pass (google.com: domain of
 gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates
 2620:52:3:1:0:246e:9693:128c as permitted sender)
 client-ip=2620:52:3:1:0:246e:9693:128c;
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 300F63858D20
From: Florian Weimer <fweimer@redhat.com>
To: gcc-patches@gcc.gnu.org
Cc: jason@redhat.com, jeffreyalaw@gmail.com, joseph@codesourcery.com,
 sam@gentoo.org
Subject: [PATCH v2 0/8] Turn some C warnings into errors by default
Message-ID: <cover.1699983736.git.fweimer@redhat.com>
Date: Tue, 14 Nov 2023 18:50:11 +0100
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux)
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=UTF-8
Precedence: list
Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org

Series

Turn some C warnings into errors by default |

Message

Florian Weimer Nov. 14, 2023, 5:50 p.m. UTC

  This new series covers:

  -Wint-conversion
  -Wimplicit-function-declaration
  -Wimplicit-int
  -Wreturn-mismatch
  -Wincompatible-pointer-types
  -Wdeclaration-missing-parameter-type (new)

There are now gcc.dg/permerror-*.c tests which track the graduation of
warnings to errors.

It turns out that pedpermerror was indeed unnecessary, and I can use
permerror_opt directly (or DK_PERMERROR in case I call one of the
low-level functions).

While working on this I found out that -Wimplicit-int is mostly
ineffective in system headers, so I fixed that for consistency.  I also
added a new -Wdeclaration-missing-parameter-type warning because missing
types in parameter lists in function declarations (as opposed to
old-style function definitions) are not covered by -Wimplicit-int, and
probably shouldn't be because the omitted types are not necessarily int.

This still depends on a couple of unreviewed patches.  In particular, I
do not want to break the AArch64 bootstrap, so the first patch looks
like a blocker.

  [PATCH] aarch64: Avoid -Wincompatible-pointer-types warning in Linux unwinder
  <https://inbox.sourceware.org/gcc-patches/874jht5tsq.fsf@oldenburg.str.redhat.com/>

  [PATCH] aarch64: Call named function in gcc.target/aarch64/aapcs64/ice_1.c
  <https://inbox.sourceware.org/gcc-patches/87r0kx6eez.fsf@oldenburg.str.redhat.com/>

  [PATCH] gm2: Add missing declaration of m2pim_M2RTS_Terminate to test
  <https://inbox.sourceware.org/gcc-patches/874jhp3nwf.fsf@oldenburg.str.redhat.com/>

Thanks,
Florian


Florian Weimer (8):
  Add tests for validating future C permerrors
  c: Turn int-conversion warnings into permerrors
  c: Turn -Wimplicit-function-declaration into a permerror
  c: Turn -Wimplicit-int into a permerror
  c: Do not ignore some forms of -Wimplicit-int in system headers
  c: Turn -Wreturn-mismatch into a permerror
  c: Turn -Wincompatible-pointer-types into a permerror
  c: Add new -Wdeclaration-missing-parameter-type permerror

 gcc/c-family/c.opt                            |   4 +
 gcc/c/c-decl.cc                               |  71 +++----
 gcc/c/c-typeck.cc                             | 164 ++++++++-------
 gcc/doc/invoke.texi                           |  50 ++++-
 gcc/testsuite/c-c++-common/pr77624-1.c        |   4 +-
 .../c-c++-common/spellcheck-reserved.c        |   4 +-
 gcc/testsuite/gcc.dg/20030906-1.c             |   2 +-
 gcc/testsuite/gcc.dg/20030906-1a.c            |  21 ++
 gcc/testsuite/gcc.dg/20030906-2.c             |   2 +-
 gcc/testsuite/gcc.dg/20030906-2a.c            |  21 ++
 .../Wimplicit-function-declaration-c99-2.c    |   7 +
 .../Wimplicit-function-declaration-c99.c      |   2 +-
 gcc/testsuite/gcc.dg/Wimplicit-int-1.c        |   2 +-
 gcc/testsuite/gcc.dg/Wimplicit-int-1a.c       |  11 ++
 gcc/testsuite/gcc.dg/Wimplicit-int-4.c        |   2 +-
 gcc/testsuite/gcc.dg/Wimplicit-int-4a.c       |  11 ++
 .../gcc.dg/Wincompatible-pointer-types-2.c    |   2 +-
 .../gcc.dg/Wincompatible-pointer-types-5.c    |  10 +
 gcc/testsuite/gcc.dg/Wint-conversion-2.c      |   2 +-
 gcc/testsuite/gcc.dg/Wint-conversion-3.c      |   2 +-
 gcc/testsuite/gcc.dg/Wint-conversion-4.c      |  14 ++
 gcc/testsuite/gcc.dg/Wreturn-mismatch-1.c     |   2 +-
 gcc/testsuite/gcc.dg/Wreturn-mismatch-1a.c    |  40 ++++
 gcc/testsuite/gcc.dg/Wreturn-mismatch-2.c     |   2 +-
 gcc/testsuite/gcc.dg/Wreturn-mismatch-2a.c    |  41 ++++
 gcc/testsuite/gcc.dg/anon-struct-11.c         |   5 +-
 gcc/testsuite/gcc.dg/anon-struct-11a.c        | 111 +++++++++++
 gcc/testsuite/gcc.dg/anon-struct-13.c         |   2 +-
 gcc/testsuite/gcc.dg/anon-struct-13a.c        |  76 +++++++
 gcc/testsuite/gcc.dg/assign-warn-1.c          |   2 +-
 gcc/testsuite/gcc.dg/assign-warn-4.c          |  21 ++
 .../gcc.dg/builtin-arith-overflow-4.c         |   2 +-
 .../gcc.dg/builtin-arith-overflow-4a.c        |  43 ++++
 gcc/testsuite/gcc.dg/c23-qual-4.c             |   6 +-
 gcc/testsuite/gcc.dg/dfp/composite-type-2.c   |  58 ++++++
 gcc/testsuite/gcc.dg/dfp/composite-type.c     |   2 +-
 gcc/testsuite/gcc.dg/diag-aka-1.c             |   2 +-
 gcc/testsuite/gcc.dg/diag-aka-1a.c            |  29 +++
 .../gcc.dg/diagnostic-range-bad-return-2.c    |  52 +++++
 .../gcc.dg/diagnostic-range-bad-return.c      |   2 +-
 gcc/testsuite/gcc.dg/diagnostic-types-1.c     |   2 +-
 gcc/testsuite/gcc.dg/diagnostic-types-2.c     |  24 +++
 gcc/testsuite/gcc.dg/enum-compat-1.c          |   2 +-
 gcc/testsuite/gcc.dg/enum-compat-2.c          |  32 +++
 gcc/testsuite/gcc.dg/func-ptr-conv-1.c        |   2 +-
 gcc/testsuite/gcc.dg/func-ptr-conv-2.c        |  56 ++++++
 gcc/testsuite/gcc.dg/gnu23-attr-syntax-2.c    |   2 +-
 gcc/testsuite/gcc.dg/gnu23-attr-syntax-3.c    |  17 ++
 gcc/testsuite/gcc.dg/gomp/pr35738-2.c         |  18 ++
 gcc/testsuite/gcc.dg/gomp/pr35738.c           |   2 +-
 gcc/testsuite/gcc.dg/init-bad-7.c             |   2 +-
 gcc/testsuite/gcc.dg/init-bad-7a.c            |  12 ++
 gcc/testsuite/gcc.dg/init-excess-3.c          |   4 +-
 gcc/testsuite/gcc.dg/missing-header-fixit-1.c |   2 +-
 .../gcc.dg/missing-header-fixit-1a.c          |  37 ++++
 gcc/testsuite/gcc.dg/missing-header-fixit-2.c |   2 +-
 .../gcc.dg/missing-header-fixit-2a.c          |  31 +++
 gcc/testsuite/gcc.dg/missing-header-fixit-4.c |   2 +-
 .../gcc.dg/missing-header-fixit-4a.c          |  27 +++
 gcc/testsuite/gcc.dg/missing-header-fixit-5.c |   2 +-
 .../gcc.dg/missing-header-fixit-5a.c          |  42 ++++
 .../gcc.dg/noncompile/incomplete-3.c          |   2 +-
 gcc/testsuite/gcc.dg/noncompile/pr79758-2.c   |   6 +
 gcc/testsuite/gcc.dg/noncompile/pr79758.c     |   1 +
 gcc/testsuite/gcc.dg/overflow-warn-1.c        |   4 +-
 gcc/testsuite/gcc.dg/overflow-warn-3.c        |   4 +-
 gcc/testsuite/gcc.dg/param-type-mismatch-2.c  | 187 ++++++++++++++++++
 gcc/testsuite/gcc.dg/param-type-mismatch.c    |   2 +-
 gcc/testsuite/gcc.dg/permerror-default.c      |  85 ++++++++
 gcc/testsuite/gcc.dg/permerror-fpermissive.c  |  85 ++++++++
 .../gcc.dg/permerror-gnu89-pedantic.c         |  85 ++++++++
 gcc/testsuite/gcc.dg/permerror-gnu89.c        |  85 ++++++++
 gcc/testsuite/gcc.dg/permerror-noerror.c      |  85 ++++++++
 gcc/testsuite/gcc.dg/permerror-pedantic.c     |  85 ++++++++
 gcc/testsuite/gcc.dg/permerror-system.c       |  45 +++++
 gcc/testsuite/gcc.dg/pointer-array-atomic-2.c |  60 ++++++
 gcc/testsuite/gcc.dg/pointer-array-atomic.c   |   2 +-
 gcc/testsuite/gcc.dg/pointer-array-quals-1.c  |   6 +-
 gcc/testsuite/gcc.dg/pr105635-2.c             |  11 ++
 gcc/testsuite/gcc.dg/pr105635.c               |   2 +-
 gcc/testsuite/gcc.dg/pr23075-2.c              |  14 ++
 gcc/testsuite/gcc.dg/pr23075.c                |   2 +-
 gcc/testsuite/gcc.dg/pr29521-a.c              |  15 ++
 gcc/testsuite/gcc.dg/pr29521.c                |   2 +-
 gcc/testsuite/gcc.dg/pr61162-2.c              |   2 +-
 gcc/testsuite/gcc.dg/pr61162-3.c              |  13 ++
 gcc/testsuite/gcc.dg/pr61852.c                |   4 +-
 gcc/testsuite/gcc.dg/pr67730-a.c              |  11 ++
 gcc/testsuite/gcc.dg/pr67730.c                |   2 +-
 gcc/testsuite/gcc.dg/spec-barrier-3.c         |   2 +-
 gcc/testsuite/gcc.dg/spec-barrier-3a.c        |  13 ++
 .../gcc.dg/spellcheck-identifiers-1a.c        | 136 +++++++++++++
 .../gcc.dg/spellcheck-identifiers-2.c         |   2 +-
 .../gcc.dg/spellcheck-identifiers-2a.c        |  33 ++++
 .../gcc.dg/spellcheck-identifiers-3.c         |   2 +-
 .../gcc.dg/spellcheck-identifiers-3a.c        |  45 +++++
 .../gcc.dg/spellcheck-identifiers-4.c         |   2 +-
 .../gcc.dg/spellcheck-identifiers-4a.c        |  10 +
 gcc/testsuite/gcc.dg/spellcheck-identifiers.c |   2 +-
 gcc/testsuite/gcc.dg/transparent-union-1.c    |   2 +-
 gcc/testsuite/gcc.dg/transparent-union-1a.c   |  85 ++++++++
 .../gcc.target/aarch64/acle/memtag_2.c        |   4 +-
 .../gcc.target/aarch64/acle/memtag_2a.c       |  71 +++++++
 .../sve/acle/general-c/ld1sh_gather_1.c       |   2 +-
 .../aarch64/sve/acle/general-c/load_2.c       |   4 +-
 .../aarch64/sve/acle/general-c/load_3.c       |   2 +-
 .../acle/general-c/load_ext_gather_index_1.c  |   2 +-
 .../load_ext_gather_index_restricted_1.c      |   2 +-
 .../acle/general-c/load_ext_gather_offset_1.c |   4 +-
 .../acle/general-c/load_ext_gather_offset_2.c |   4 +-
 .../acle/general-c/load_ext_gather_offset_3.c |   4 +-
 .../acle/general-c/load_ext_gather_offset_4.c |   4 +-
 .../acle/general-c/load_ext_gather_offset_5.c |   4 +-
 .../load_ext_gather_offset_restricted_1.c     |   4 +-
 .../load_ext_gather_offset_restricted_2.c     |   4 +-
 .../load_ext_gather_offset_restricted_3.c     |   4 +-
 .../load_ext_gather_offset_restricted_4.c     |   4 +-
 .../aarch64/sve/acle/general-c/sizeless-1.c   |   8 +-
 .../aarch64/sve/acle/general-c/sizeless-2.c   |   8 +-
 .../aarch64/sve/acle/general-c/store_1.c      |   8 +-
 .../aarch64/sve/acle/general-c/store_2.c      |  10 +-
 .../acle/general-c/store_scatter_index_1.c    |   8 +-
 .../store_scatter_index_restricted_1.c        |   8 +-
 .../acle/general-c/store_scatter_offset_2.c   |   8 +-
 .../store_scatter_offset_restricted_1.c       |   8 +-
 .../aarch64/sve/acle/general/attributes_7.c   |  28 +--
 .../i386/sse2-bfloat16-scalar-typecheck.c     |   4 +-
 .../i386/vect-bfloat16-typecheck_1.c          |   4 +-
 .../i386/vect-bfloat16-typecheck_2.c          |   4 +-
 .../gcc.target/powerpc/conditional-return.c   |   2 +-
 130 files changed, 2441 insertions(+), 257 deletions(-)
 create mode 100644 gcc/testsuite/gcc.dg/20030906-1a.c
 create mode 100644 gcc/testsuite/gcc.dg/20030906-2a.c
 create mode 100644 gcc/testsuite/gcc.dg/Wimplicit-function-declaration-c99-2.c
 create mode 100644 gcc/testsuite/gcc.dg/Wimplicit-int-1a.c
 create mode 100644 gcc/testsuite/gcc.dg/Wimplicit-int-4a.c
 create mode 100644 gcc/testsuite/gcc.dg/Wincompatible-pointer-types-5.c
 create mode 100644 gcc/testsuite/gcc.dg/Wint-conversion-4.c
 create mode 100644 gcc/testsuite/gcc.dg/Wreturn-mismatch-1a.c
 create mode 100644 gcc/testsuite/gcc.dg/Wreturn-mismatch-2a.c
 create mode 100644 gcc/testsuite/gcc.dg/anon-struct-11a.c
 create mode 100644 gcc/testsuite/gcc.dg/anon-struct-13a.c
 create mode 100644 gcc/testsuite/gcc.dg/assign-warn-4.c
 create mode 100644 gcc/testsuite/gcc.dg/builtin-arith-overflow-4a.c
 create mode 100644 gcc/testsuite/gcc.dg/dfp/composite-type-2.c
 create mode 100644 gcc/testsuite/gcc.dg/diag-aka-1a.c
 create mode 100644 gcc/testsuite/gcc.dg/diagnostic-range-bad-return-2.c
 create mode 100644 gcc/testsuite/gcc.dg/diagnostic-types-2.c
 create mode 100644 gcc/testsuite/gcc.dg/enum-compat-2.c
 create mode 100644 gcc/testsuite/gcc.dg/func-ptr-conv-2.c
 create mode 100644 gcc/testsuite/gcc.dg/gnu23-attr-syntax-3.c
 create mode 100644 gcc/testsuite/gcc.dg/gomp/pr35738-2.c
 create mode 100644 gcc/testsuite/gcc.dg/init-bad-7a.c
 create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-1a.c
 create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-2a.c
 create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-4a.c
 create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-5a.c
 create mode 100644 gcc/testsuite/gcc.dg/noncompile/pr79758-2.c
 create mode 100644 gcc/testsuite/gcc.dg/param-type-mismatch-2.c
 create mode 100644 gcc/testsuite/gcc.dg/permerror-default.c
 create mode 100644 gcc/testsuite/gcc.dg/permerror-fpermissive.c
 create mode 100644 gcc/testsuite/gcc.dg/permerror-gnu89-pedantic.c
 create mode 100644 gcc/testsuite/gcc.dg/permerror-gnu89.c
 create mode 100644 gcc/testsuite/gcc.dg/permerror-noerror.c
 create mode 100644 gcc/testsuite/gcc.dg/permerror-pedantic.c
 create mode 100644 gcc/testsuite/gcc.dg/permerror-system.c
 create mode 100644 gcc/testsuite/gcc.dg/pointer-array-atomic-2.c
 create mode 100644 gcc/testsuite/gcc.dg/pr105635-2.c
 create mode 100644 gcc/testsuite/gcc.dg/pr23075-2.c
 create mode 100644 gcc/testsuite/gcc.dg/pr29521-a.c
 create mode 100644 gcc/testsuite/gcc.dg/pr61162-3.c
 create mode 100644 gcc/testsuite/gcc.dg/pr67730-a.c
 create mode 100644 gcc/testsuite/gcc.dg/spec-barrier-3a.c
 create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-1a.c
 create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-2a.c
 create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-3a.c
 create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-4a.c
 create mode 100644 gcc/testsuite/gcc.dg/transparent-union-1a.c
 create mode 100644 gcc/testsuite/gcc.target/aarch64/acle/memtag_2a.c


base-commit: 69d69865a792a93cce2905617c53913769d0f260
prerequisite-patch-id: f46d6a56470ab459865ba2e45372d60e131b9ee2
prerequisite-patch-id: 7e0b407ec2bbd5e3b9c7ed1342b08d3677a65283
prerequisite-patch-id: 02e95117add6ada9d5cdb489399fb2e562db76e2

Comments

Sam James Nov. 15, 2023, 5:16 a.m. UTC | #1

Florian Weimer <fweimer@redhat.com> writes:

> This new series covers:
>
>   -Wint-conversion
>   -Wimplicit-function-declaration
>   -Wimplicit-int
>   -Wreturn-mismatch
>   -Wincompatible-pointer-types
>   -Wdeclaration-missing-parameter-type (new)
>
> There are now gcc.dg/permerror-*.c tests which track the graduation of
> warnings to errors.
>
> It turns out that pedpermerror was indeed unnecessary, and I can use
> permerror_opt directly (or DK_PERMERROR in case I call one of the
> low-level functions).
>
> While working on this I found out that -Wimplicit-int is mostly
> ineffective in system headers, so I fixed that for consistency.  I also
> added a new -Wdeclaration-missing-parameter-type warning because missing
> types in parameter lists in function declarations (as opposed to
> old-style function definitions) are not covered by -Wimplicit-int, and
> probably shouldn't be because the omitted types are not necessarily int.
>
> This still depends on a couple of unreviewed patches.  In particular, I
> do not want to break the AArch64 bootstrap, so the first patch looks
> like a blocker.
>
>   [PATCH] aarch64: Avoid -Wincompatible-pointer-types warning in Linux unwinder
>   <https://inbox.sourceware.org/gcc-patches/874jht5tsq.fsf@oldenburg.str.redhat.com/>
>
>   [PATCH] aarch64: Call named function in gcc.target/aarch64/aapcs64/ice_1.c
>   <https://inbox.sourceware.org/gcc-patches/87r0kx6eez.fsf@oldenburg.str.redhat.com/>
>
>   [PATCH] gm2: Add missing declaration of m2pim_M2RTS_Terminate to test
>   <https://inbox.sourceware.org/gcc-patches/874jhp3nwf.fsf@oldenburg.str.redhat.com/>

When posting v3, I guess consider CCing the aarch64 maintainers (or just
pinging them separately)?

I'm not really sure how approval of (an earlier version of) this series
interacts with stage 3 ending on Friday.

>
> Thanks,
> Florian
>
>
> Florian Weimer (8):
>   Add tests for validating future C permerrors
>   c: Turn int-conversion warnings into permerrors
>   c: Turn -Wimplicit-function-declaration into a permerror
>   c: Turn -Wimplicit-int into a permerror
>   c: Do not ignore some forms of -Wimplicit-int in system headers
>   c: Turn -Wreturn-mismatch into a permerror
>   c: Turn -Wincompatible-pointer-types into a permerror
>   c: Add new -Wdeclaration-missing-parameter-type permerror
>
>  gcc/c-family/c.opt                            |   4 +
>  gcc/c/c-decl.cc                               |  71 +++----
>  gcc/c/c-typeck.cc                             | 164 ++++++++-------
>  gcc/doc/invoke.texi                           |  50 ++++-
>  gcc/testsuite/c-c++-common/pr77624-1.c        |   4 +-
>  .../c-c++-common/spellcheck-reserved.c        |   4 +-
>  gcc/testsuite/gcc.dg/20030906-1.c             |   2 +-
>  gcc/testsuite/gcc.dg/20030906-1a.c            |  21 ++
>  gcc/testsuite/gcc.dg/20030906-2.c             |   2 +-
>  gcc/testsuite/gcc.dg/20030906-2a.c            |  21 ++
>  .../Wimplicit-function-declaration-c99-2.c    |   7 +
>  .../Wimplicit-function-declaration-c99.c      |   2 +-
>  gcc/testsuite/gcc.dg/Wimplicit-int-1.c        |   2 +-
>  gcc/testsuite/gcc.dg/Wimplicit-int-1a.c       |  11 ++
>  gcc/testsuite/gcc.dg/Wimplicit-int-4.c        |   2 +-
>  gcc/testsuite/gcc.dg/Wimplicit-int-4a.c       |  11 ++
>  .../gcc.dg/Wincompatible-pointer-types-2.c    |   2 +-
>  .../gcc.dg/Wincompatible-pointer-types-5.c    |  10 +
>  gcc/testsuite/gcc.dg/Wint-conversion-2.c      |   2 +-
>  gcc/testsuite/gcc.dg/Wint-conversion-3.c      |   2 +-
>  gcc/testsuite/gcc.dg/Wint-conversion-4.c      |  14 ++
>  gcc/testsuite/gcc.dg/Wreturn-mismatch-1.c     |   2 +-
>  gcc/testsuite/gcc.dg/Wreturn-mismatch-1a.c    |  40 ++++
>  gcc/testsuite/gcc.dg/Wreturn-mismatch-2.c     |   2 +-
>  gcc/testsuite/gcc.dg/Wreturn-mismatch-2a.c    |  41 ++++
>  gcc/testsuite/gcc.dg/anon-struct-11.c         |   5 +-
>  gcc/testsuite/gcc.dg/anon-struct-11a.c        | 111 +++++++++++
>  gcc/testsuite/gcc.dg/anon-struct-13.c         |   2 +-
>  gcc/testsuite/gcc.dg/anon-struct-13a.c        |  76 +++++++
>  gcc/testsuite/gcc.dg/assign-warn-1.c          |   2 +-
>  gcc/testsuite/gcc.dg/assign-warn-4.c          |  21 ++
>  .../gcc.dg/builtin-arith-overflow-4.c         |   2 +-
>  .../gcc.dg/builtin-arith-overflow-4a.c        |  43 ++++
>  gcc/testsuite/gcc.dg/c23-qual-4.c             |   6 +-
>  gcc/testsuite/gcc.dg/dfp/composite-type-2.c   |  58 ++++++
>  gcc/testsuite/gcc.dg/dfp/composite-type.c     |   2 +-
>  gcc/testsuite/gcc.dg/diag-aka-1.c             |   2 +-
>  gcc/testsuite/gcc.dg/diag-aka-1a.c            |  29 +++
>  .../gcc.dg/diagnostic-range-bad-return-2.c    |  52 +++++
>  .../gcc.dg/diagnostic-range-bad-return.c      |   2 +-
>  gcc/testsuite/gcc.dg/diagnostic-types-1.c     |   2 +-
>  gcc/testsuite/gcc.dg/diagnostic-types-2.c     |  24 +++
>  gcc/testsuite/gcc.dg/enum-compat-1.c          |   2 +-
>  gcc/testsuite/gcc.dg/enum-compat-2.c          |  32 +++
>  gcc/testsuite/gcc.dg/func-ptr-conv-1.c        |   2 +-
>  gcc/testsuite/gcc.dg/func-ptr-conv-2.c        |  56 ++++++
>  gcc/testsuite/gcc.dg/gnu23-attr-syntax-2.c    |   2 +-
>  gcc/testsuite/gcc.dg/gnu23-attr-syntax-3.c    |  17 ++
>  gcc/testsuite/gcc.dg/gomp/pr35738-2.c         |  18 ++
>  gcc/testsuite/gcc.dg/gomp/pr35738.c           |   2 +-
>  gcc/testsuite/gcc.dg/init-bad-7.c             |   2 +-
>  gcc/testsuite/gcc.dg/init-bad-7a.c            |  12 ++
>  gcc/testsuite/gcc.dg/init-excess-3.c          |   4 +-
>  gcc/testsuite/gcc.dg/missing-header-fixit-1.c |   2 +-
>  .../gcc.dg/missing-header-fixit-1a.c          |  37 ++++
>  gcc/testsuite/gcc.dg/missing-header-fixit-2.c |   2 +-
>  .../gcc.dg/missing-header-fixit-2a.c          |  31 +++
>  gcc/testsuite/gcc.dg/missing-header-fixit-4.c |   2 +-
>  .../gcc.dg/missing-header-fixit-4a.c          |  27 +++
>  gcc/testsuite/gcc.dg/missing-header-fixit-5.c |   2 +-
>  .../gcc.dg/missing-header-fixit-5a.c          |  42 ++++
>  .../gcc.dg/noncompile/incomplete-3.c          |   2 +-
>  gcc/testsuite/gcc.dg/noncompile/pr79758-2.c   |   6 +
>  gcc/testsuite/gcc.dg/noncompile/pr79758.c     |   1 +
>  gcc/testsuite/gcc.dg/overflow-warn-1.c        |   4 +-
>  gcc/testsuite/gcc.dg/overflow-warn-3.c        |   4 +-
>  gcc/testsuite/gcc.dg/param-type-mismatch-2.c  | 187 ++++++++++++++++++
>  gcc/testsuite/gcc.dg/param-type-mismatch.c    |   2 +-
>  gcc/testsuite/gcc.dg/permerror-default.c      |  85 ++++++++
>  gcc/testsuite/gcc.dg/permerror-fpermissive.c  |  85 ++++++++
>  .../gcc.dg/permerror-gnu89-pedantic.c         |  85 ++++++++
>  gcc/testsuite/gcc.dg/permerror-gnu89.c        |  85 ++++++++
>  gcc/testsuite/gcc.dg/permerror-noerror.c      |  85 ++++++++
>  gcc/testsuite/gcc.dg/permerror-pedantic.c     |  85 ++++++++
>  gcc/testsuite/gcc.dg/permerror-system.c       |  45 +++++
>  gcc/testsuite/gcc.dg/pointer-array-atomic-2.c |  60 ++++++
>  gcc/testsuite/gcc.dg/pointer-array-atomic.c   |   2 +-
>  gcc/testsuite/gcc.dg/pointer-array-quals-1.c  |   6 +-
>  gcc/testsuite/gcc.dg/pr105635-2.c             |  11 ++
>  gcc/testsuite/gcc.dg/pr105635.c               |   2 +-
>  gcc/testsuite/gcc.dg/pr23075-2.c              |  14 ++
>  gcc/testsuite/gcc.dg/pr23075.c                |   2 +-
>  gcc/testsuite/gcc.dg/pr29521-a.c              |  15 ++
>  gcc/testsuite/gcc.dg/pr29521.c                |   2 +-
>  gcc/testsuite/gcc.dg/pr61162-2.c              |   2 +-
>  gcc/testsuite/gcc.dg/pr61162-3.c              |  13 ++
>  gcc/testsuite/gcc.dg/pr61852.c                |   4 +-
>  gcc/testsuite/gcc.dg/pr67730-a.c              |  11 ++
>  gcc/testsuite/gcc.dg/pr67730.c                |   2 +-
>  gcc/testsuite/gcc.dg/spec-barrier-3.c         |   2 +-
>  gcc/testsuite/gcc.dg/spec-barrier-3a.c        |  13 ++
>  .../gcc.dg/spellcheck-identifiers-1a.c        | 136 +++++++++++++
>  .../gcc.dg/spellcheck-identifiers-2.c         |   2 +-
>  .../gcc.dg/spellcheck-identifiers-2a.c        |  33 ++++
>  .../gcc.dg/spellcheck-identifiers-3.c         |   2 +-
>  .../gcc.dg/spellcheck-identifiers-3a.c        |  45 +++++
>  .../gcc.dg/spellcheck-identifiers-4.c         |   2 +-
>  .../gcc.dg/spellcheck-identifiers-4a.c        |  10 +
>  gcc/testsuite/gcc.dg/spellcheck-identifiers.c |   2 +-
>  gcc/testsuite/gcc.dg/transparent-union-1.c    |   2 +-
>  gcc/testsuite/gcc.dg/transparent-union-1a.c   |  85 ++++++++
>  .../gcc.target/aarch64/acle/memtag_2.c        |   4 +-
>  .../gcc.target/aarch64/acle/memtag_2a.c       |  71 +++++++
>  .../sve/acle/general-c/ld1sh_gather_1.c       |   2 +-
>  .../aarch64/sve/acle/general-c/load_2.c       |   4 +-
>  .../aarch64/sve/acle/general-c/load_3.c       |   2 +-
>  .../acle/general-c/load_ext_gather_index_1.c  |   2 +-
>  .../load_ext_gather_index_restricted_1.c      |   2 +-
>  .../acle/general-c/load_ext_gather_offset_1.c |   4 +-
>  .../acle/general-c/load_ext_gather_offset_2.c |   4 +-
>  .../acle/general-c/load_ext_gather_offset_3.c |   4 +-
>  .../acle/general-c/load_ext_gather_offset_4.c |   4 +-
>  .../acle/general-c/load_ext_gather_offset_5.c |   4 +-
>  .../load_ext_gather_offset_restricted_1.c     |   4 +-
>  .../load_ext_gather_offset_restricted_2.c     |   4 +-
>  .../load_ext_gather_offset_restricted_3.c     |   4 +-
>  .../load_ext_gather_offset_restricted_4.c     |   4 +-
>  .../aarch64/sve/acle/general-c/sizeless-1.c   |   8 +-
>  .../aarch64/sve/acle/general-c/sizeless-2.c   |   8 +-
>  .../aarch64/sve/acle/general-c/store_1.c      |   8 +-
>  .../aarch64/sve/acle/general-c/store_2.c      |  10 +-
>  .../acle/general-c/store_scatter_index_1.c    |   8 +-
>  .../store_scatter_index_restricted_1.c        |   8 +-
>  .../acle/general-c/store_scatter_offset_2.c   |   8 +-
>  .../store_scatter_offset_restricted_1.c       |   8 +-
>  .../aarch64/sve/acle/general/attributes_7.c   |  28 +--
>  .../i386/sse2-bfloat16-scalar-typecheck.c     |   4 +-
>  .../i386/vect-bfloat16-typecheck_1.c          |   4 +-
>  .../i386/vect-bfloat16-typecheck_2.c          |   4 +-
>  .../gcc.target/powerpc/conditional-return.c   |   2 +-
>  130 files changed, 2441 insertions(+), 257 deletions(-)
>  create mode 100644 gcc/testsuite/gcc.dg/20030906-1a.c
>  create mode 100644 gcc/testsuite/gcc.dg/20030906-2a.c
>  create mode 100644 gcc/testsuite/gcc.dg/Wimplicit-function-declaration-c99-2.c
>  create mode 100644 gcc/testsuite/gcc.dg/Wimplicit-int-1a.c
>  create mode 100644 gcc/testsuite/gcc.dg/Wimplicit-int-4a.c
>  create mode 100644 gcc/testsuite/gcc.dg/Wincompatible-pointer-types-5.c
>  create mode 100644 gcc/testsuite/gcc.dg/Wint-conversion-4.c
>  create mode 100644 gcc/testsuite/gcc.dg/Wreturn-mismatch-1a.c
>  create mode 100644 gcc/testsuite/gcc.dg/Wreturn-mismatch-2a.c
>  create mode 100644 gcc/testsuite/gcc.dg/anon-struct-11a.c
>  create mode 100644 gcc/testsuite/gcc.dg/anon-struct-13a.c
>  create mode 100644 gcc/testsuite/gcc.dg/assign-warn-4.c
>  create mode 100644 gcc/testsuite/gcc.dg/builtin-arith-overflow-4a.c
>  create mode 100644 gcc/testsuite/gcc.dg/dfp/composite-type-2.c
>  create mode 100644 gcc/testsuite/gcc.dg/diag-aka-1a.c
>  create mode 100644 gcc/testsuite/gcc.dg/diagnostic-range-bad-return-2.c
>  create mode 100644 gcc/testsuite/gcc.dg/diagnostic-types-2.c
>  create mode 100644 gcc/testsuite/gcc.dg/enum-compat-2.c
>  create mode 100644 gcc/testsuite/gcc.dg/func-ptr-conv-2.c
>  create mode 100644 gcc/testsuite/gcc.dg/gnu23-attr-syntax-3.c
>  create mode 100644 gcc/testsuite/gcc.dg/gomp/pr35738-2.c
>  create mode 100644 gcc/testsuite/gcc.dg/init-bad-7a.c
>  create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-1a.c
>  create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-2a.c
>  create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-4a.c
>  create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-5a.c
>  create mode 100644 gcc/testsuite/gcc.dg/noncompile/pr79758-2.c
>  create mode 100644 gcc/testsuite/gcc.dg/param-type-mismatch-2.c
>  create mode 100644 gcc/testsuite/gcc.dg/permerror-default.c
>  create mode 100644 gcc/testsuite/gcc.dg/permerror-fpermissive.c
>  create mode 100644 gcc/testsuite/gcc.dg/permerror-gnu89-pedantic.c
>  create mode 100644 gcc/testsuite/gcc.dg/permerror-gnu89.c
>  create mode 100644 gcc/testsuite/gcc.dg/permerror-noerror.c
>  create mode 100644 gcc/testsuite/gcc.dg/permerror-pedantic.c
>  create mode 100644 gcc/testsuite/gcc.dg/permerror-system.c
>  create mode 100644 gcc/testsuite/gcc.dg/pointer-array-atomic-2.c
>  create mode 100644 gcc/testsuite/gcc.dg/pr105635-2.c
>  create mode 100644 gcc/testsuite/gcc.dg/pr23075-2.c
>  create mode 100644 gcc/testsuite/gcc.dg/pr29521-a.c
>  create mode 100644 gcc/testsuite/gcc.dg/pr61162-3.c
>  create mode 100644 gcc/testsuite/gcc.dg/pr67730-a.c
>  create mode 100644 gcc/testsuite/gcc.dg/spec-barrier-3a.c
>  create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-1a.c
>  create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-2a.c
>  create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-3a.c
>  create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-4a.c
>  create mode 100644 gcc/testsuite/gcc.dg/transparent-union-1a.c
>  create mode 100644 gcc/testsuite/gcc.target/aarch64/acle/memtag_2a.c
>
>
> base-commit: 69d69865a792a93cce2905617c53913769d0f260
> prerequisite-patch-id: f46d6a56470ab459865ba2e45372d60e131b9ee2
> prerequisite-patch-id: 7e0b407ec2bbd5e3b9c7ed1342b08d3677a65283
> prerequisite-patch-id: 02e95117add6ada9d5cdb489399fb2e562db76e2

Florian Weimer Nov. 15, 2023, 6:37 a.m. UTC | #2

* Sam James:

> When posting v3, I guess consider CCing the aarch64 maintainers (or just
> pinging them separately)?

I already pinged them, they are likely busy with posting their patches
before stage 1 closes.

> I'm not really sure how approval of (an earlier version of) this series
> interacts with stage 3 ending on Friday.

The posting date of the patch is what counts, not whether it's been
reviewed and pushed.

Thanks,
Florian