From patchwork Wed May 10 15:37:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Meissner X-Patchwork-Id: 9155 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp3718943vqo; Wed, 10 May 2023 08:39:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5TOjD1eQosMzCOG3DhOy6c5remEg7QO25BK0WfM+EIv+MHgUcle83Rb/4jTBSFeuJUgN3c X-Received: by 2002:a17:907:9718:b0:966:c09:1c57 with SMTP id jg24-20020a170907971800b009660c091c57mr15502642ejc.65.1683733174179; Wed, 10 May 2023 08:39:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683733174; cv=none; d=google.com; s=arc-20160816; b=m5Whb4sJChilOc+d7qyjORHlp7wGTyl/jNYJvVa4/ET303ne6IXKGDV/xungcwGTI7 bPJ/cBKJ94zqvRQWNGfSo6fc9YvnQBBMt2KmEw1+6i6ngNZkCXNgM4U1HmNZbZuvFmKg xkzFJGzsOhxLk5DzsMeP7v7FJnGBfNrGRxBrOyM0ctRFY3qyRuO1FsLM/uADxLcN55Dz 6Bm3UspubfMCFScgNCj2PepoZjUOgj7sU0oLoR8Xu0InMMZlcBX2QmnbF7toIXKZXqH5 SL/3Sk6JUIOKM+kzq/GFyPNo1oZTrsONqN0g/dYwjyE0/B9zn1YPE29VN6XljVHhmsoI 8zUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:mail-followup-to:message-id :subject:to:date:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=Z7nyHLkT+jiK6xYqLMepa8+Rt4Nc+9BjXT4v+v4KdAM=; b=HyCEXZeBNrJ0r79uk4MYOc3L52eauWY3ik41xawPvejNMAPb/iOA9hrfLKjTRnCVqv gYCsglJ56j8PBhnTx9LY2tGAiJdwvPMDwWNh1pVlEVLUVdr56IsRUc6HrT0AF/9OmTQA AQsnTdZRM40/k8jSCLWyJrv3+tjqaNzHWjQdrJyKbkxtG/suhNg6IogcHgUKoweN9/DX E3/QmWWBQ76IiZWD+0y/R+3gWDS7+Q2clv/bhquJah5U1oMh/orXKNM2UAdRSO8cEJ8F p+Um4vPPiPTKSUoMLeGH+BVoev+7cpT4T/VTI7F0B2gCIn7sbEmGU8a4vKASvdYdw7i8 8QxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=vRg0a5ZK; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id b9-20020a170906150900b00932af15caa7si2907556ejd.731.2023.05.10.08.39.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 May 2023 08:39:34 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=vRg0a5ZK; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 742CB384F022 for ; Wed, 10 May 2023 15:39:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 742CB384F022 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1683733171; bh=Z7nyHLkT+jiK6xYqLMepa8+Rt4Nc+9BjXT4v+v4KdAM=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=vRg0a5ZK6652s0n1ATiSlLPrW0F1Uryx8WteqQZFOvBJsctnum0JiW+T8j97cpX6d 9NeDojIbboYvhiRwCQCiTs0eaZsgIR4jU7ilAvIv2Oj4JxFkFx3qrBrTfL0Ke5GPEh 6zz4IA48GEjtqROKVT9wrh/2uy7y0yViEGDCFF/E= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id F3B57385558C for ; Wed, 10 May 2023 15:38:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F3B57385558C Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34AFZgEl001186; Wed, 10 May 2023 15:38:47 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3qgaa2gayd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 May 2023 15:38:45 +0000 Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 34AFZxwq003152; Wed, 10 May 2023 15:37:14 GMT Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3qgaa2gavk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 May 2023 15:37:14 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 34AE3253029893; Wed, 10 May 2023 15:37:10 GMT Received: from smtprelay02.dal12v.mail.ibm.com ([9.208.130.97]) by ppma03dal.us.ibm.com (PPS) with ESMTPS id 3qf7y93wtj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 May 2023 15:37:10 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay02.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 34AFb9M019792516 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 May 2023 15:37:09 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 63B425803F; Wed, 10 May 2023 15:37:09 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E35B55805A; Wed, 10 May 2023 15:37:08 +0000 (GMT) Received: from toto.the-meissners.org (unknown [9.160.59.115]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTPS; Wed, 10 May 2023 15:37:08 +0000 (GMT) Date: Wed, 10 May 2023 11:37:07 -0400 To: gcc-patches@gcc.gnu.org, Michael Meissner , Segher Boessenkool , "Kewen.Lin" , David Edelsohn , Peter Bergner Subject: [PATCH V5, 0/2] PR target/105325: Fix constraint issue with power10 fusion Message-ID: Mail-Followup-To: Michael Meissner , gcc-patches@gcc.gnu.org, Segher Boessenkool , "Kewen.Lin" , David Edelsohn , Peter Bergner MIME-Version: 1.0 Content-Disposition: inline X-TM-AS-GCONF: 00 X-Proofpoint-GUID: z9OIiAhMRbFlJS5S4kVzomb-mnkoqmEn X-Proofpoint-ORIG-GUID: TB8EqMvdSaS9_vr87GwEud55n4sjPzKS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-10_04,2023-05-05_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=911 spamscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 phishscore=0 clxscore=1015 suspectscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305100126 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Michael Meissner via Gcc-patches From: Michael Meissner Reply-To: Michael Meissner Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765522196493329625?= X-GMAIL-MSGID: =?utf-8?q?1765522196493329625?= I have posted 4 previous versions of this patch (April 26th, March 28th, March 24th, and March 21st). In this patch, rather than just add changes to the existing code in genfusion.pl, I rewrote the function completely. There are two patches within this patch set: * The first patch rewrites the perl function to be more readable. This patch produces the same output for fusion.md that the current version generates. * The second patch then using the rewrite in the first patch adds the changes to fix the problem. The issue with the original bug is the power10 load GPR + cmpi -1/0/1 fusion optimization generates illegal assembler code when the -fstack-protector option is used. Ultimately the code was dying because the fusion load + compare -1/0/1 patterns did not handle the possibility that the load might be prefixed. The main cause is the constraints for the individual loads in the fusion did not match the machine. In particular, LWA is a ds format instruction when it is unprefixed. The code did not also set the prefixed attribute correctly. These patch hav been tested on: * Little endian power9 with both IEEE and IBM long double * Little endian power10 * Big endian power8 using both 32-bit and 64-bit code generation. Can I check these into the master branch? Assuming I can check this in, I will also commit to the active GCC branches after a burn-in period.