Message ID | 20231219065957.70665-1-xry111@xry111.site |
---|---|
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp1757820dyi; Mon, 18 Dec 2023 23:00:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IH8STJ2AJ6aIZBYtTd7hY3hO1Q0CzFXeSKM9rHmxiGJVA4NeyI25tb5bIwwSfUCWXhy9P1R X-Received: by 2002:a05:622a:15ce:b0:423:93aa:9765 with SMTP id d14-20020a05622a15ce00b0042393aa9765mr24417111qty.67.1702969242636; Mon, 18 Dec 2023 23:00:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1702969242; cv=pass; d=google.com; s=arc-20160816; b=V18GLspLzxd+iwvVjKTYSaZ9gsNYWCQ28IVqkTr62crq1onFblUZ7GkokZYha5v0hR axS3Yx/f8h4jfMAHHVzVC3UnJY9KhyoVqLMNj29gjWGPVpJA2Bz+Dbojm9qrJi7hX46R BB3TQobrPLuvJ19CrmWQJPcS8HpRFsQdFvx/JOnQkNkN9vinKjtP7ItiNKmR3CWbK0po bmIjl6r0s67y+9LkWc3PmfIeLKnCklYeJ7Ahn/zDMhz9qFpRXibUwfPI9bew0AdLZGQy ei5HOT/dsD97a6tfmZfzudADzC9HuTQwlpKbadDlSZie+FVZ6VKmznquZaGOA9+WJvQD xVrQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=fZMXI+d9xK1jjmlR0oAXs0aTNDkFPnsH8tkToIvx8Cs=; fh=lAZEJv+juT1q6RYyAreaw+ZnRPAcRoheJ20Uybha2qY=; b=zU4x8pAMT17FpJL/KEFjcPekr1f6nKzfGxuWpYyCEEn7SoK0z1u2evUk9noCH++68K weO5CA4XlYkT1cc9Jai8i1HWBoxygXVVqQTz0gJDW7mRX/BTac29iTrJUa+SOTMvmz7r ZTWUVkK4ZNpd9TcyF0FGfrwY7Blnp9d7uGm7bUILbKCiUYeYkrWJW7mN2G8kEm29RZH3 YfS/++vxJAgjrcEZ9lQ4Rf4L8Jc9wxW1HzS59mTDfWqBpY/duLzo0eEEey1ob/CONzRR UhpZGK8DNRLu2qSPCSnMOCnXha7xR/ryVB/4+fk2OaQJnEvf0ZgztaYM9191oPTp2tEP 7OmA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@xry111.site header.s=default header.b=nnmpflDY; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=xry111.site Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id o1-20020a05622a008100b00425b2c6f53fsi22334198qtw.5.2023.12.18.23.00.42 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 23:00:42 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@xry111.site header.s=default header.b=nnmpflDY; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=xry111.site Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7ED7D3860015 for <ouuuleilei@gmail.com>; Tue, 19 Dec 2023 07:00:37 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id B2F0C3858439 for <gcc-patches@gcc.gnu.org>; Tue, 19 Dec 2023 07:00:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B2F0C3858439 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B2F0C3858439 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=89.208.246.23 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702969215; cv=none; b=a99+lY2s0ESbN8coydFbBiIF3HDRTUzmtPcTCSmLy3FFGw/G2KTNnpnc897xTiaPigF7UZTUhuOISJFqlw3KPs78rMNEuoaHAJsJUxZX0lNR3GvKtkXfw/TpEq+OVUM9Ib57S/IG3/5CbuoE/Wf9QhxwvUEyhaHgiq2Y6qkuOJM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702969215; c=relaxed/simple; bh=vxJYjUSkxgENpX0XsYr8pRN3WmOgoq5UH8EKgJjfFkk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=DXCGfhUi3ss6sUY44fuVGGnoOZTYjR/uo5zoopIRsaaTR/F+DXJey0o+XjCOKga6PlQAQJaObIENuoq3I1sEfYBofmAMnu8EFkVS8NRaU8R7IAKo1mdtoHvTHWGxo2N5xCF9U3m0dlQVQbR6sggMa7ElrA+2WSxCoE9QL0zB95g= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1702969211; bh=vxJYjUSkxgENpX0XsYr8pRN3WmOgoq5UH8EKgJjfFkk=; h=From:To:Cc:Subject:Date:From; b=nnmpflDY5pEtLgyu/bggcEpZ4pwzztteji1XaH1sFr79q+jVD4KNS7S9d8Cb03FzI 8uwTxCsKaRp3eV6qUNE+F08mUU+sVmhMezb42xkre7WlwMgTDLUl15pFBjXLAXITk6 qy9k8NMCQHwQH5QmsKrcQI/4NXv3HjTwbDFbJWhY= Received: from stargazer.. (unknown [IPv6:240e:358:119f:400:dc73:854d:832e:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id E228066A04; Tue, 19 Dec 2023 02:00:08 -0500 (EST) From: Xi Ruoyao <xry111@xry111.site> To: gcc-patches@gcc.gnu.org Cc: chenglulu <chenglulu@loongson.cn>, i@xen0n.name, xuchenghua@loongson.cn, c@jia.je, Xi Ruoyao <xry111@xry111.site> Subject: [PATCH 0/2] LoongArch: Fix PR113033 and clean up code Date: Tue, 19 Dec 2023 14:59:55 +0800 Message-ID: <20231219065957.70665-1-xry111@xry111.site> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, LIKELY_SPAM_FROM, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785692676388320664 X-GMAIL-MSGID: 1785692676388320664 |
Series |
LoongArch: Fix PR113033 and clean up code
|
|
Message
Xi Ruoyao
Dec. 19, 2023, 6:59 a.m. UTC
Superseds https://gcc.gnu.org/pipermail/gcc-patches/2023-December/640871.html. Per Jakub's response, vec_init patterns do not have a predicate on the input operand so the operand can be *anything*. It's not safe to simply move it into an reg, and we have to use force_reg instead. The code clean up is separated into the 2nd patch to make reviewing easier. Bootstrapped and regtested on loongarch64-linux-gnu. Ok for trunk? Xi Ruoyao (2): LoongArch: Use force_reg instead of gen_reg_rtx + emit_move_insn in vec_init expander [PR113033] LoongArch: Clean up vec_init expander gcc/config/loongarch/loongarch.cc | 54 +++++++------------ gcc/testsuite/gcc.target/loongarch/pr113033.c | 23 ++++++++ 2 files changed, 43 insertions(+), 34 deletions(-) create mode 100644 gcc/testsuite/gcc.target/loongarch/pr113033.c
Comments
We will read and test these patches as soon as possible. Thanks! 在 2023/12/19 下午2:59, Xi Ruoyao 写道: > Superseds > https://gcc.gnu.org/pipermail/gcc-patches/2023-December/640871.html. > > Per Jakub's response, vec_init patterns do not have a predicate on the > input operand so the operand can be *anything*. It's not safe to simply > move it into an reg, and we have to use force_reg instead. > > The code clean up is separated into the 2nd patch to make reviewing > easier. > > Bootstrapped and regtested on loongarch64-linux-gnu. Ok for trunk? > > Xi Ruoyao (2): > LoongArch: Use force_reg instead of gen_reg_rtx + emit_move_insn in > vec_init expander [PR113033] > LoongArch: Clean up vec_init expander > > gcc/config/loongarch/loongarch.cc | 54 +++++++------------ > gcc/testsuite/gcc.target/loongarch/pr113033.c | 23 ++++++++ > 2 files changed, 43 insertions(+), 34 deletions(-) > create mode 100644 gcc/testsuite/gcc.target/loongarch/pr113033.c >
The patches are look ok and no problem in spec2017 correctness check. On 2023/12/19 15:26, chenglulu wrote: > We will read and test these patches as soon as possible. > > Thanks! > > 在 2023/12/19 下午2:59, Xi Ruoyao 写道: >> Superseds >> https://gcc.gnu.org/pipermail/gcc-patches/2023-December/640871.html. >> >> Per Jakub's response, vec_init patterns do not have a predicate on the >> input operand so the operand can be *anything*. It's not safe to simply >> move it into an reg, and we have to use force_reg instead. >> >> The code clean up is separated into the 2nd patch to make reviewing >> easier. >> >> Bootstrapped and regtested on loongarch64-linux-gnu. Ok for trunk? >> >> Xi Ruoyao (2): >> LoongArch: Use force_reg instead of gen_reg_rtx + emit_move_insn in >> vec_init expander [PR113033] >> LoongArch: Clean up vec_init expander >> >> gcc/config/loongarch/loongarch.cc | 54 +++++++------------ >> gcc/testsuite/gcc.target/loongarch/pr113033.c | 23 ++++++++ >> 2 files changed, 43 insertions(+), 34 deletions(-) >> create mode 100644 gcc/testsuite/gcc.target/loongarch/pr113033.c >>