mbox series

[v2,0/1] Set _M_string_length before calling _M_dispose()

Message ID 20230503021713.1146069-1-tchaikov@gmail.com
Headers
Series Set _M_string_length before calling _M_dispose() |

Message

kefu chai May 3, 2023, 2:17 a.m. UTC 
  Hi Jonathan,

Thank you for your review and suggestion. The change looks great!
Assigning a value with an immediate zero is indeed much faster.

in v2:

* revised the commit message a little bit, I found it a little bit
  difficult to parse when re-reading it.
* associated the commit with PR/libstdc++/109703. as I just filed 
  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109706, which turns out
  to be a dup of https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109703

The rest of the v2 patch is identical to the one attached in your reply.

Would you please taking another look?

Kefu Chai (1):
  libstdc++: Set _M_string_length before calling _M_dispose() [PR109703]

 libstdc++-v3/include/bits/basic_string.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jonathan Wakely May 3, 2023, 12:22 p.m. UTC | #1 
On Wed, 3 May 2023 at 03:17, Kefu Chai via Libstdc++ <libstdc++@gcc.gnu.org>
wrote:

> Hi Jonathan,
>
> Thank you for your review and suggestion. The change looks great!
> Assigning a value with an immediate zero is indeed much faster.
>
> in v2:
>
> * revised the commit message a little bit, I found it a little bit
>   difficult to parse when re-reading it.
> * associated the commit with PR/libstdc++/109703. as I just filed
>   https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109706, which turns out
>   to be a dup of https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109703
>
> The rest of the v2 patch is identical to the one attached in your reply.
>
> Would you please taking another look?
>

Thanks. I've pushed it to trunk as
 cbf6c7a1d16490a1e63e9a5ce00e9a5c44c4c2f2 and will backport it too.

I altered the commit msg again, because "input_iterator" is a C++20
concept, and here we're just talking about types meeting the old
C[[17InputIterator requirements, not types modelling the concept. I also
added references to the commit and PR that added the
__builtin_unreachable().



> Kefu Chai (1):
>   libstdc++: Set _M_string_length before calling _M_dispose() [PR109703]
>
>  libstdc++-v3/include/bits/basic_string.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.40.1
>
>
kefu chai May 3, 2023, 12:30 p.m. UTC | #2 
Le mer. 3 mai 2023 à 20:22, Jonathan Wakely <jwakely@redhat.com> a écrit :

>
>
> On Wed, 3 May 2023 at 03:17, Kefu Chai via Libstdc++ <
> libstdc++@gcc.gnu.org> wrote:
>
>> Hi Jonathan,
>>
>> Thank you for your review and suggestion. The change looks great!
>> Assigning a value with an immediate zero is indeed much faster.
>>
>> in v2:
>>
>> * revised the commit message a little bit, I found it a little bit
>>   difficult to parse when re-reading it.
>> * associated the commit with PR/libstdc++/109703. as I just filed
>>   https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109706, which turns out
>>   to be a dup of https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109703
>>
>> The rest of the v2 patch is identical to the one attached in your reply.
>>
>> Would you please taking another look?
>>
>
> Thanks. I've pushed it to trunk as
>  cbf6c7a1d16490a1e63e9a5ce00e9a5c44c4c2f2 and will backport it too.
>
> I altered the commit msg again, because "input_iterator" is a C++20
> concept, and here we're just talking about types meeting the old
> C[[17InputIterator requirements, not types modelling the concept. I also
> added references to the commit and PR that added the
> __builtin_unreachable().
>

Awesome! The commit message is much better now. Thank you very much for
your help!


>
>
>> Kefu Chai (1):
>>   libstdc++: Set _M_string_length before calling _M_dispose() [PR109703]
>>
>>  libstdc++-v3/include/bits/basic_string.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --
>> 2.40.1
>>
>> --
Regards
Kefu Chai