From patchwork Fri Jan 27 11:35:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 49267 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp784498wrn; Fri, 27 Jan 2023 03:36:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXvSKd4aiDd9T8dzrG2N9fJEd66fUe5+XSN/gGyMXY/RBHDUis8BbZsHdLNpY5yFrCvCT8Gn X-Received: by 2002:a17:906:99d1:b0:845:bb21:f638 with SMTP id s17-20020a17090699d100b00845bb21f638mr42688460ejn.75.1674819381473; Fri, 27 Jan 2023 03:36:21 -0800 (PST) Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id v18-20020a1709064e9200b008779cf266c3si4603857eju.628.2023.01.27.03.36.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 03:36:21 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=tbrE8752; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 026B63857B93 for ; Fri, 27 Jan 2023 11:36:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 026B63857B93 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1674819378; bh=UbbME0CGg1zFcvNLOKqNbvVuTtr4Q/UIc8XpryO7FQ4=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=tbrE8752X5wm8a5IGNkesiriIN7sWX5oyBxCBarUAFKBhlEhnFKDFzigzCLgfGs5g TA0713yfqxWOLTK6BTqKtZbjx4zG4ch6rq4rrEqvuAy7Uh0CqoNjO2rOhGVDtkMm8V REPSW75zrQFujTBdYwnAORzMGsKtcUvupiuMatCQ= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2043.outbound.protection.outlook.com [40.107.247.43]) by sourceware.org (Postfix) with ESMTPS id 7256A3858404 for ; Fri, 27 Jan 2023 11:35:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7256A3858404 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W+5J48MZAugEHAEIiv5No2SnQwQRvlowY9P/0ogx05JtlZk5+aSPmvy099PAOP8tMXw7t14wvSsEH9Ru44PybGfIIMPT2orZKVw+QYagaT1HVHLBvq+De0H9HHHyZRP4en6yFfmS3/ihH91eLdQuC5GzalV4x54k84wJ63RLhNcWDjSO/FvCtQw5WJ3zmKu/Cnj/62SaUi4N0O3gFRyl3IwPcMbghaWJwoAO0FgrLoZlIPvi/aDtQECjca8LgPiJXGKZE1W+nhCP6iFk+nnW5YbvQ01xKRShyZZqPSt2C/z0lmSEcdx/JV9hddoADw+ZBiQJy8/PmWmUZbZOjVeQ9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UbbME0CGg1zFcvNLOKqNbvVuTtr4Q/UIc8XpryO7FQ4=; b=Ho8PTAbChrjNwq1h1dhcXwu8P7hreJnt1oeigwPgehPIzbBeyjiUqqICFKQ2L9YPo9780yuwcVsEz79/DLtqkk9dytgmuBEvc5O1SEg9GHlBtPrEp/X4ixnjVoa2EVRyB9GeQ1qpA0f07vfFPeeG6Pfi1WRVZbuMCtYdkbJTG8hsPFd/UOFw6IusgxbvX5pIbgc44+ccgiLEnSRDaLXwr3kDbauBh0LpV/9h1BAYw1GRzlAGgucPCKtvl7n017A1ARnAnfuyjCGxdV3Fhgf1B5EC16PhOLUXIPeG5+NZ7AzgO+S4doWpuh124H+O0TBWh/9ui6eyG3Swgq5kCJCqhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8136.eurprd04.prod.outlook.com (2603:10a6:20b:3f7::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.23; Fri, 27 Jan 2023 11:35:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6043.022; Fri, 27 Jan 2023 11:35:34 +0000 Message-ID: Date: Fri, 27 Jan 2023 12:35:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH 2/3] x86-64: respect {nooptimize} when building VEX prefix Content-Language: en-US To: Binutils Cc: "H.J. Lu" References: In-Reply-To: X-ClientProxiedBy: FR0P281CA0106.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8136:EE_ X-MS-Office365-Filtering-Correlation-Id: 3f8a346f-650f-47b6-ba49-08db005a9a9e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dxMt8SJUBbmxZaI5dZ9Zb7LPha+EVeMA2YpgY8Bf5R3v9nfD2XxaWBisHEV8w2tUY1kVHsGC6yGV9yA7DsckURpfaaQYTmMWTjO27LZV7WV9m7qjmgOVvwvYXrccV8z1uUwthF1bUTx1Edt5h0ki217eDR4VO2/4l+UuJ1SsOMAYkNdE5fyrQO+saWKEY8zXxQKDnrGB0mTqvXd20iwhp5NAaULSJb1sqsbG9QrqmPRdpYYVlf01GYPlCSpZu7ajKmB5c8z7S+A2xWEqTN36gzL3SxBmsZHnhmxJ9nM/6KyqvAn1xZFYHxGUag+Ur0zHQN5/7WcLHG9XkEpVXvtp+UW6IOizU58tp6cb4GjXD2GFhJByQ5KrvXrf9sahVSCoOc+Ks/+thBeE1hGGYF7JgHhCbaFHrhNInRrUVF26OBpIuutmavkNkHS1xu/11waN/ZMg2G5jbqg2Z6FfQV0vrNjaO8DnC0f2btnzt60iajggRItM4ZAhI9s5VuOPhry5TJRX6kEqnBrOk3iZxWyZnAKb63qRwHYgq2PL3AhHpijzz9R2JFHd/UK9yysugxQm6wFFwy06dIiY4NnVQfSdO6TOtSWwlqMLmV28N40bAxsGiynPdL/YQnATKxRf8rlhOAEyPXG9RgJ9Q9zPSHqkHLhrRnUfo1g/viAjVMj6HAKNi+74mOOLa516z8FdPLHDYgzht3rm+PY7sAzKPUp3RzZnaTXF+iZMkuX4eF3WW9I= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(346002)(376002)(39860400002)(136003)(396003)(366004)(451199018)(31686004)(6506007)(5660300002)(2906002)(36756003)(316002)(8936002)(41300700001)(31696002)(2616005)(4326008)(6916009)(66476007)(26005)(66556008)(186003)(6512007)(83380400001)(8676002)(66946007)(86362001)(38100700002)(6486002)(478600001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Dtp8Ey0EVFOvNr78f/Fuzy0PbEWv?= =?utf-8?q?4KU3tXPmuvM0gHY9gAFK3D5osxEPHDZL4W+GBHrR+C0hHdm4ZD2x3Y6vRe4HmgdM0?= =?utf-8?q?1dQKfL9S1hjgBw44WGMUTFiXvqkSDjKU6JXzjP3v0Bw20BpaGN0DpGhLuSrsTqFuu?= =?utf-8?q?DowWU0dDKfthFi99RVTwmSh7bTsiu7LHwAvfHcCER47ra6ZZ4AwHYPzLpnIAMGkYS?= =?utf-8?q?us/NHUqwWYTIKBco4gpXCm4GnT1KvUtYWP+VYSy8J9qnmWRkgWi33w2Xxiyz24gMH?= =?utf-8?q?qWIs4Tub5BrLIoLA9yHL+5GDCUP5X+h4zoWwmd6VZ/2CP9ezKyeXcZk7AJ3LQkSHH?= =?utf-8?q?HJ8FA/FVMJs9baqoPoIRI6PicVUNJd/RZyTNmJ9sf6+qamDF4mXiylT5koQIoTz22?= =?utf-8?q?7BB9ytseES4ac8Wg8OXfwLPXADoFH7FZdX12QI09MvGUnPVPYU0ir5qey2tGl5Sf0?= =?utf-8?q?8hTsosbp36sVpFYbXqBYLhZ2n9YVKWl+vs/aftMLxOwhXWGLcFW86I05if3TJYLvM?= =?utf-8?q?1fenlP7eBzCwVSU76XJoeT6raf4Hv0GhgWchBSUJPjaV8y/g+HP7eJozHpKO1vIaU?= =?utf-8?q?w9sZeFbFo5+TOQcpcETmlChv3BnLsdsATx41xCxrQkjOUwDIvYGKbhLUWqaMxhJYy?= =?utf-8?q?cKkLdHBmudGI/U9cBvz94V7K0Zga7SzckDERh2XrAM5qs5muoTFj0btsT+J6Tbbj9?= =?utf-8?q?PEca8/cJAKw8v8nDD/Id9x/NE2/b/p0g+iAH1wUS+4CbuNfzJaZktCf6P0v985Qc0?= =?utf-8?q?t1Qypg7ePiej0vBBbyc7+B9zCNQxI4A6jlWws9SQd4kBDFqUS36xfnWnB0rm9b5bV?= =?utf-8?q?akXsUs+J3QSIwoVkgc99EyVdCpa19p/tU9yFiGsWMrcsIRFgMzdfvaCna8/M71gNN?= =?utf-8?q?ZefvL9OaBs41Zxy9VSu0Zl2MZa/oMZ4QAutSYTG+66+dteE6jhAODPGd8kKG/9xJM?= =?utf-8?q?O1YGpdvXCG6ZhykVYuTT5LPqVu6fbsRA5Qtk0nrbjPT0aiS3RMAYNHtB/zIXGUsqT?= =?utf-8?q?f4qVuObgfF7i+brvG+Ju3gVw8577SJL9eYBuBzPV9OUCtcuycLZJk8l8BVH3o59/r?= =?utf-8?q?MqYDgKGVT41y7nlfKNNIZZG4MLevGo7ocjX/JCnq9BwX/KFcVUo0VjpeDudFbzvmw?= =?utf-8?q?7/66OPkfxvLjmIl44idym1bDxPAnFL+42PMdIrw1g3Sxo6mzz4ZSZRyf6B1aAHy58?= =?utf-8?q?9op6KFKITSDHI1uR9LjPCaf5vW6r7yr4415ssCh1W54Mx9TkxUWMCGy5x+FmCpFxC?= =?utf-8?q?WCNpTg/4533E7uNGWy0GjjqHVcJM1l5kW0B5I5w8ALmBWMvx0B49+7z0GsEz3jeiC?= =?utf-8?q?boyNLWScWFIJYIfkp13A4PU+lHoRgdJOCekGjHkBRMSiK8YvDwCDis9izqFedoSpG?= =?utf-8?q?V+j8V+OoKz7ALWw4ALrvCkq2mbeiUqcaqXg+S2CBXNvriQEfH+Yz7pmULaY0yx54G?= =?utf-8?q?JsMNwlwKUJGLtvidc7MSVd0RpYCb/GQ6oZKj/T9D9ZC0eihzg4XVx8W/a9jXVlhMW?= =?utf-8?q?7DzacLWeMhB9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f8a346f-650f-47b6-ba49-08db005a9a9e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2023 11:35:34.5769 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eW5S8z/is6LLvgOOYFBJ+XCpQ8rPC9ynou2N3MlpxxAa1DK0Nps+ByxmJjiqDh2/HR6+MGwnLqXiDppSND9qzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8136 X-Spam-Status: No, score=-3028.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Beulich via Binutils From: Jan Beulich Reply-To: Jan Beulich Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756175407938571133?= X-GMAIL-MSGID: =?utf-8?q?1756175407938571133?= Swapping operands for commutative insns occurs outside of optimize_encoding() and hence needs explicit checking for a request to avoid any optimizations. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -3624,7 +3624,8 @@ build_vex_prefix (const insn_template *t && i.reg_operands == i.operands - i.imm_operands && i.tm.opcode_modifier.vex && i.tm.opcode_modifier.commutative - && (i.tm.opcode_modifier.sse2avx || optimize > 1) + && (i.tm.opcode_modifier.sse2avx + || (optimize > 1 && !i.no_optimize)) && i.rex == REX_B && i.vex.register_specifier && !(i.vex.register_specifier->reg_flags & RegRex)) --- a/gas/testsuite/gas/i386/x86-64-optimize-4.d +++ b/gas/testsuite/gas/i386/x86-64-optimize-4.d @@ -9,6 +9,8 @@ Disassembly of section .text: 0+ <_start>: +[a-f0-9]+: a9 7f 00 00 00 test \$0x7f,%eax + +[a-f0-9]+: c4 c1 61 db e4 vpand %xmm12,%xmm3,%xmm4 + +[a-f0-9]+: c5 91 db e2 vpand %xmm2,%xmm13,%xmm4 +[a-f0-9]+: 62 f1 7d 28 6f d1 vmovdqa32 %ymm1,%ymm2 +[a-f0-9]+: 62 f1 fd 28 6f d1 vmovdqa64 %ymm1,%ymm2 +[a-f0-9]+: 62 f1 7f 08 6f d1 vmovdqu8 %xmm1,%xmm2 --- a/gas/testsuite/gas/i386/x86-64-optimize-4.s +++ b/gas/testsuite/gas/i386/x86-64-optimize-4.s @@ -5,6 +5,9 @@ _start: {nooptimize} testl $0x7f, %eax + {nooptimize} vpand %xmm12, %xmm3, %xmm4 + {nooptimize} vpand %xmm2, %xmm13, %xmm4 + {nooptimize} vmovdqa32 %ymm1, %ymm2 {nooptimize} vmovdqa64 %ymm1, %ymm2 {nooptimize} vmovdqu8 %xmm1, %xmm2