diff mbox series

SCFI: correct test names

Message ID f9e0ab9a-acf4-4856-9582-fb664e0565c6@suse.com
State Unresolved
Headers
Series SCFI: correct test names |

Checks

Context Check Description
snail/binutils-gdb-check warning Git am fail log

Commit Message

Jan Beulich Feb. 9, 2024, 6:58 a.m. UTC 
  Having multiple tests with the same name is confusing.
---
I only noticed these because I had to make further adjustments to the
overly strict expectations, to accommodate a local change of mine
(adding

#define EH_FRAME_ALIGNMENT 2

to tc-i386.h). I've yet to decide whether I actually want to upstream
that change.

Comments

Indu Bhagat Feb. 9, 2024, 7:29 a.m. UTC | #1 
On 2/8/24 22:58, Jan Beulich wrote:
> Having multiple tests with the same name is confusing.
> ---
> I only noticed these because I had to make further adjustments to the
> overly strict expectations, to accommodate a local change of mine
> (adding
> 
> #define EH_FRAME_ALIGNMENT 2
> 
> to tc-i386.h). I've yet to decide whether I actually want to upstream
> that change.
> 
> --- a/gas/testsuite/gas/scfi/x86_64/scfi-indirect-mov-4.d
> +++ b/gas/testsuite/gas/scfi/x86_64/scfi-indirect-mov-4.d
> @@ -1,7 +1,7 @@
>   #as: --scfi=experimental -W
>   #as:
>   #objdump: -Wf
> -#name: Synthesize CFI for indirect mem op to stack 3
> +#name: Synthesize CFI for indirect mem op to stack 4
>   #...
>   Contents of the .eh_frame section:
>   
> --- a/gas/testsuite/gas/scfi/x86_64/scfi-pushsection-2.d
> +++ b/gas/testsuite/gas/scfi/x86_64/scfi-pushsection-2.d
> @@ -1,7 +1,7 @@
>   #as: --scfi=experimental -W
>   #as:
>   #objdump: -Wf
> -#name: Synthesize CFI for demarcated code blocks 2
> +#name: Synthesize CFI with pushsection 2
>   #...
>   Contents of the .eh_frame section:
>   

Thanks for fixing these.

Indu
diff mbox series

Patch

--- a/gas/testsuite/gas/scfi/x86_64/scfi-indirect-mov-4.d
+++ b/gas/testsuite/gas/scfi/x86_64/scfi-indirect-mov-4.d
@@ -1,7 +1,7 @@ 
 #as: --scfi=experimental -W
 #as:
 #objdump: -Wf
-#name: Synthesize CFI for indirect mem op to stack 3
+#name: Synthesize CFI for indirect mem op to stack 4
 #...
 Contents of the .eh_frame section:
 
--- a/gas/testsuite/gas/scfi/x86_64/scfi-pushsection-2.d
+++ b/gas/testsuite/gas/scfi/x86_64/scfi-pushsection-2.d
@@ -1,7 +1,7 @@ 
 #as: --scfi=experimental -W
 #as:
 #objdump: -Wf
-#name: Synthesize CFI for demarcated code blocks 2
+#name: Synthesize CFI with pushsection 2
 #...
 Contents of the .eh_frame section: