diff mbox series

gprofng/testsuite: restrict testing to native configurations

Message ID f8cae085-3ed5-a6ec-cedf-f78d0c4b0ae1@suse.com
State Accepted
Headers
Series gprofng/testsuite: restrict testing to native configurations |

Checks

Context Check Description
snail/binutils-gdb-check success Github commit url

Commit Message

Jan Beulich Dec. 19, 2022, 3:06 p.m. UTC 
  The binaries involved in testing gprofng are native ones, and hence a
cross build of binutils won't really test intended functionality. Since
this testing takes quite a bit of time (typically more than running all
of binutils, gas, and ld testsuites together), restrict the testing to
native configurations only.

Comments

Vladimir Mezentsev Dec. 20, 2022, 5:37 p.m. UTC | #1 
LGTM.

Thank you for the gprofng improvement.
-Vladimir

On 12/19/22 07:06, Jan Beulich wrote:
> The binaries involved in testing gprofng are native ones, and hence a
> cross build of binutils won't really test intended functionality. Since
> this testing takes quite a bit of time (typically more than running all
> of binutils, gas, and ld testsuites together), restrict the testing to
> native configurations only.
>
> --- a/gprofng/testsuite/gprofng.display/display.exp
> +++ b/gprofng/testsuite/gprofng.display/display.exp
> @@ -24,6 +24,13 @@ if {[info exists env(LC_ALL)]} {
>   set env(LC_ALL) "C"
>   
>   set pltf [exec uname -i]
> +
> +# Native testing only for now.
> +if { ![istarget $pltf-*-*]
> +     && (![string match i?86 $pltf] || ![istarget i?86-*-*]) } then {
> +    return
> +}
> +
>   switch $pltf {
>     x86_64 {
>       # Columns in the table represent:
diff mbox series

Patch

--- a/gprofng/testsuite/gprofng.display/display.exp
+++ b/gprofng/testsuite/gprofng.display/display.exp
@@ -24,6 +24,13 @@  if {[info exists env(LC_ALL)]} {
 set env(LC_ALL) "C"
 
 set pltf [exec uname -i]
+
+# Native testing only for now.
+if { ![istarget $pltf-*-*]
+     && (![string match i?86 $pltf] || ![istarget i?86-*-*]) } then {
+    return
+}
+
 switch $pltf {
   x86_64 {
     # Columns in the table represent: