RISC-V: as_warn() already emits a newline

Message ID f055cbdb-e706-3a74-ab63-725ed8a047fd@suse.com
State Unresolved
Headers
Series RISC-V: as_warn() already emits a newline |

Checks

Context Check Description
snail/binutils-gdb-check warning Git am fail log

Commit Message

Jan Beulich Feb. 16, 2023, 8:56 a.m. UTC
  Therefore there shouldn't be any at the end of the format string.
  

Comments

Nelson Chu Feb. 20, 2023, 2:46 a.m. UTC | #1
OK, thanks for fixing this.

Nelson

On Thu, Feb 16, 2023 at 4:56 PM Jan Beulich <jbeulich@suse.com> wrote:
>
> Therefore there shouldn't be any at the end of the format string.
>
> --- a/gas/config/tc-riscv.c
> +++ b/gas/config/tc-riscv.c
> @@ -4179,7 +4179,7 @@ s_riscv_option (int x ATTRIBUTE_UNUSED)
>      }
>    else
>      {
> -      as_warn (_("unrecognized .option directive: %s\n"), name);
> +      as_warn (_("unrecognized .option directive: %s"), name);
>      }
>    *input_line_pointer = ch;
>    demand_empty_rest_of_line ();
  

Patch

--- a/gas/config/tc-riscv.c
+++ b/gas/config/tc-riscv.c
@@ -4179,7 +4179,7 @@  s_riscv_option (int x ATTRIBUTE_UNUSED)
     }
   else
     {
-      as_warn (_("unrecognized .option directive: %s\n"), name);
+      as_warn (_("unrecognized .option directive: %s"), name);
     }
   *input_line_pointer = ch;
   demand_empty_rest_of_line ();