From patchwork Mon Aug 14 13:48:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 135439 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b824:0:b0:3f2:4152:657d with SMTP id z4csp2757653vqi; Mon, 14 Aug 2023 06:49:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHdkocNkCedZr8RnOGig6+z/IPhplZAyfatp4XDRos3vyZWZcopsW0cfso3BKgGzmm5krny X-Received: by 2002:a05:6402:1345:b0:525:6c74:5e58 with SMTP id y5-20020a056402134500b005256c745e58mr1054804edw.23.1692020976058; Mon, 14 Aug 2023 06:49:36 -0700 (PDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id w24-20020a056402129800b005221eb09887si8419351edv.86.2023.08.14.06.49.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Aug 2023 06:49:36 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=KfomSwOq; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AF7D63857030 for ; Mon, 14 Aug 2023 13:49:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AF7D63857030 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1692020950; bh=u5rWV9r0Mif5QAhuZq0PgsnbpY6/pQzWWhyRAl37HNM=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=KfomSwOqNEQA0c9kyTpQN8KrmO/A26TljyVub1YEjXRWniWket3sQ8uUleePNT2HP t9Fi+diiK6LH7XOUlYCHKPD/yt/XpL6Rym/L0Vu8X6dwoOfSFYajWYp7VDDm0cCbvy 8FiEySnkykUobW33KnZuX1sPW8ZVZqA0gdJ7aUP8= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2072.outbound.protection.outlook.com [40.107.14.72]) by sourceware.org (Postfix) with ESMTPS id 9A01E3856263 for ; Mon, 14 Aug 2023 13:49:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9A01E3856263 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UMmKsg4wkYKL8kvLrBYPWpSFplh/C201D15H9oYyJOXJc8jU1Vn0y52EdcW+Bz/BGQ9LLea/33EB7e+OHP4wql9NGsPOwrCViJl/KJKnMWkKY9RAygSo1KFlas+pTLPfrH6beB/5kkZnvLXLqHsCcZrkfuHycXUafukIGHJrOIdF7jnLSCcuCxAE3sq/g1JK1Q1xS3h1G8iR0lIHqsCYlQzKL4W3G3NEOzAGA05wBNF2JXlmoAQHtwvodzyZkRTByoJdPxjcAaP/M64G1VNHJFfs1qYolbI+BKpN47IWCTE3/7lQkWdF9w0N0Omgcn0bMBRULVzI65yqFb67UU3XRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u5rWV9r0Mif5QAhuZq0PgsnbpY6/pQzWWhyRAl37HNM=; b=VE/MIeyhHPIJFz5sZ2GlecDBjZB7LskRSM+ZGyq1FuSk73UuyoMJ/C8WtX7j7vzdzixTfnQ2tLouAQod6xKv053OVVdzU7qfJpKWg3zf3gZwwIqkfK/a8+TJSOPYoxdDqEKUkdTEQRz/i1LNmfNNDbkD7b1vUS+Kj+DROL6ZiVbRvjlQVyvrrERLVyd6KXJCKhIY4GD3jEOYvPuHofHQupMFToYL0oHNK5WddyTZyExrIopiNAJmzthTYAj4LGzniNydEucHnqQ5x2qDZApfuJunltUNbr0NBIAS2baoNAJ8asXXym2F0Lc+18G+oxFAWDMJ5Ge9FSwi5JU4Vc2eNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM7PR04MB7109.eurprd04.prod.outlook.com (2603:10a6:20b:117::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.24; Mon, 14 Aug 2023 13:48:58 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::79a:54ba:8003:fbe7]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::79a:54ba:8003:fbe7%6]) with mapi id 15.20.6678.022; Mon, 14 Aug 2023 13:48:58 +0000 Message-ID: Date: Mon, 14 Aug 2023 15:48:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: [PATCH 2/2] gas/ELF: widen use of $dump_opts in testsuite Content-Language: en-US To: Binutils Cc: Nick Clifton , Alan Modra References: <9ccf6770-66bd-c924-93e1-fd54a6daf610@suse.com> In-Reply-To: <9ccf6770-66bd-c924-93e1-fd54a6daf610@suse.com> X-ClientProxiedBy: FR0P281CA0013.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::18) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM7PR04MB7109:EE_ X-MS-Office365-Filtering-Correlation-Id: 702b1fd6-605e-43fa-1d0e-08db9ccd356d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dEFxV9M7BorSERwC/h9mXHrHl3+AqVdZ5mwZv2KefDoTuLeATeGuymdc7LEFvkBuKdntFYXBtdFXMMCCIoYF7I5w4yRrxH9w83y2QrsTh0Mvsqibv/v6sCzO75u/C8fySgf6vbiFofsqcc1T8+idO7XweKHoiAcEUq4xbWlcs+bzY3vOPhhzZYzdUpbo7q2O7mdbX5jisJYh90oinNk6F5n30t4zMWFwal7KuVakmLt02MOy4z+cWRFMqmhEuRKYNdt/aMmEwLYVGKXyFGE6Ro0p7/GdjsTZVcLKMlQQilxI0j57XO3yTBdsGNUAMpMM5TGKysWvoeQqm5kIbJ5eBmRQ60oLDTqVc/3XqOvW+hhR7lFKkcWm+blyZxlQ9D2yoLSYHk+TKpqD+HSUH+M+l9v6bya9wjj8cRYrvyG8ka8TEaiHECWx+9SK6Yenzf/mbaLfOCZy7N+QhSwW7L0aE06B89lh2d4SieWYw7QJ/OOu2Uglml6r9xYcQ0br1fvUH0ddzeOxmvOMxcHNCIpC3bgj7i6HS09CWFGF5eYcC+aOu3OEjgACt/DnEt3Tbr/KSRiIq6HzPb48a0HwroZSiYuabGJeBHhx1fQKrwpeG0t3Ds/Oo4V+m+auMz5WQdZ9wfm9t7JOOGSks4wLVpZWjjLJHFMUDy9Csa1eZhVp8ek= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8790.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39850400004)(346002)(136003)(396003)(376002)(366004)(1800799006)(186006)(451199021)(26005)(6506007)(41300700001)(8936002)(66476007)(66556008)(66946007)(316002)(8676002)(6512007)(31686004)(2616005)(83380400001)(6486002)(478600001)(38100700002)(54906003)(31696002)(36756003)(86362001)(4326008)(6916009)(5660300002)(2906002)(43740500002)(45980500001)(357404004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?W3kKSlHx79iaHFrdIiv/e4TbAezR?= =?utf-8?q?BCqAaXJtyQl4/+Z3OA+O4E+2lpVOJKtIyrz2tlWDzj9gznE8GGbRMaSporu2DBBgr?= =?utf-8?q?pv8Z6+4Y1A1aNttge04IuRqKz9QBpdNzQ9xf3XeIjWfJMBqw3wtLAm/HDOVsffGTS?= =?utf-8?q?bnVPXKxMT2xCyIAXdBkXte26Kqk3/9zQFvvlhnwp75R9LEY7Uzg9JS/hXzJuNYovE?= =?utf-8?q?cPhY+YQPZacvfIdmdO10YNY6+Q2iuv1s8cxSlwvrbMhzw+NdXMIiArbpZBKu8V/j0?= =?utf-8?q?nwqCTGmt+i+vlMAUspA0aZ/pPU4xKYNCpc6hOSQInL7Rt/PCpELHgsTpGrINGMXuX?= =?utf-8?q?jR9nsciF4KXFO/TZghGBD7WTtb+0brIc6Z6wUvtM/F8DGKn054kaf1+StGRwUkPQ8?= =?utf-8?q?6ZXZdP+wA/SckJ7l3UFBsMDxdlh0pF/Pf4kM4FwBp5WAGpcKtbYkQRsBKP7xWokEE?= =?utf-8?q?zKH6wWmFN3Svtg5gH8K0pXsZXag9YvvpSSsSR5B79gzn9lCgKgym7D/QlfXc7JVzR?= =?utf-8?q?hDudKjwBV+bByLoRqs8jDWCqlZW5OIu5apcVe2n4v2v86RKtRMEnAb+brlIiqmOmK?= =?utf-8?q?CxI9RZvZKwl58pcTmKSHc8lpcoSxsJ+31PnrjDv8OUnOi2DMWQ95LmbFij7gCcvgM?= =?utf-8?q?rtuQswHm1nzAGp45WwkGELf0dQn6M9dA1gFCjGBTCkK7oSNAzFANpj1Cee4O9hiXo?= =?utf-8?q?jt3LzM0ZNbx1Na7pboOZ12VMLfOOBIpIrZgIcDdrsuAxunE8UMN/5IWykTJg+oy1v?= =?utf-8?q?SMNVbeZ5zwqaAW1df8TeBgAvxD9BdXfGldEZHIq1D6TOp4Ogh/SZktJCgT3L9R57s?= =?utf-8?q?Zl/3pTWegwaj6AhUAEwxg+9bS7pi82ejmslRwqiJuIaSm7J027lcYfE9P8Dt9wfqW?= =?utf-8?q?QKruh1MMT1Sj0xIWZWOMklMRVGPYlfjtwvZWbcoSexxau3RrUVDOaYG8jluZAEGcs?= =?utf-8?q?BRAXEjaOnJGOuZqqJFkbZItIONLfEFvBe6I0hUNuVEADKAaDJhH/yGsxSOyR89nlg?= =?utf-8?q?piziYuY0tScPBZzCtn1x0sTQ3EwGace9OeG1r671Bdr8I6L83Imzo0usrXm0iWI/9?= =?utf-8?q?5R8b7ghO+G+P2puG4zizuprCm0DJvket1eEUiC+RZkhPviUKUAzcRXqc5elR8TqDc?= =?utf-8?q?9leo6ft8S/kbREiZEOa+NRWUuTidPLvOw4EVvJpMsacVGNN/wGW0EHdYvEB/yqrMg?= =?utf-8?q?5fA6glWVPObZ90bA0slHSKzy/9I8mBDCwk5Jb6HKe3POOGGErtUtxE7du47gGnsf5?= =?utf-8?q?yJKdi3dnTD5LZwd5OgbqCZi4AvOYKF6CbC9Y0yh/IOZV4s9vYDD25u+AQ8Pge9U5F?= =?utf-8?q?bO8XZswdZr8caF5zgXhuETWho+dpxq6HksOdelmqAR3RZSTiDRCkRJGuMGu2DckR6?= =?utf-8?q?nRBL3cPQ3rupo/EfN2VX2YH5r1UwF5MwgsKhdb4A/hPhT+QUukHfeEw82rDh4szNU?= =?utf-8?q?b7PHoTio4eNIjafs6lhrckcTUN5obNe4LRTQ70ArlgcpGJTKVJFnrwpXIqd8xL7xg?= =?utf-8?q?c2kSF6Zg7yf0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 702b1fd6-605e-43fa-1d0e-08db9ccd356d X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2023 13:48:58.2565 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l2Idsdh8PwXBQC6EcYzNXeJeu8KkIN+u0EoX7mq5Lv26oCrbPwqbiQL3BjD2694TtZwwKkyeOOtxWnC8cn9emQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7109 X-Spam-Status: No, score=-3027.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Beulich via Binutils From: Jan Beulich Reply-To: Jan Beulich Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1774212586564317571 X-GMAIL-MSGID: 1774212586564317571 Rather than special-casing rx-*-* for section30, force use of conventional section names uniformly. By further passing $dump_opts to a few more tests, a number of xfail-s (and one notarget) can be eliminated (some of which had wrong justifications in associated comments anyway). Note that section7 and section15 need to be left alone: The harness fiddling with section names there didn't help before and is getting in the way now. For section12b, section16b, and most of the Dwarf tests nothing changes. Interestingly by passing $dump_opts the need to xfail section11 for LoongArch and RISC-V also goes away. --- a/gas/testsuite/gas/elf/bignums.d +++ b/gas/testsuite/gas/elf/bignums.d @@ -1,8 +1,6 @@ #readelf: -x .data #name: bignum byte values -#xfail: rx-* -# The RX target sometimes calls its data section D_1. -# + # Test that 8-bit and 16-bit constants can be specified via bignums. # # Note - we should really apply this test to all targets, not just --- a/gas/testsuite/gas/elf/dwarf2-5.d +++ b/gas/testsuite/gas/elf/dwarf2-5.d @@ -1,11 +1,11 @@ #as: --gdwarf-3 #readelf: -x.rodata -wlL #name: DWARF2 5 -# The am33 cr16 crx ft32 mn10 msp430 nds32 rl78 and rx targets do not evaluate the subtraction of symbols at assembly time. +# The am33 cr16 crx ft32 mn10 msp430 nds32 and rl78 targets do not evaluate the subtraction of symbols at assembly time. # The mep target tries to relay code sections which breaks symbolic view computations. # The riscv targets do not support the subtraction of symbols. # The loongarch targets do not support the subtraction of symbols. -#xfail: am3*-* cr16-* crx-* ft32*-* loongarch*-* mep-* mn10*-* msp430-* nds32*-* riscv*-* rl78-* rx-* +#xfail: am3*-* cr16-* crx-* ft32*-* loongarch*-* mep-* mn10*-* msp430-* nds32*-* riscv*-* rl78-* Hex dump of section '\.rodata': 0x00000000 01010201 010203 *.* --- a/gas/testsuite/gas/elf/elf.exp +++ b/gas/testsuite/gas/elf/elf.exp @@ -96,6 +96,7 @@ if { [is_elf_format] } then { } if {[istarget "rx-*-*"]} then { set target_machine -rx + set dump_opts {{as -muse-conventional-section-names}} } if {[istarget "score-*-*"]} then { set target_machine -score @@ -142,7 +143,7 @@ if { [is_elf_format] } then { run_dump_test "group0a" run_dump_test "group0b" run_dump_test "group0c" - run_dump_test "group1a" + run_dump_test "group1a" $dump_opts run_dump_test "group1b" run_dump_test "group2" run_dump_test "group3" @@ -154,7 +155,7 @@ if { [is_elf_format] } then { hppa64*-*-hpux* { } riscv*-*-* { } default { - run_dump_test "groupautoa" + run_dump_test "groupautoa" $dump_opts } } switch -glob $target_triplet { @@ -211,7 +212,7 @@ if { [is_elf_format] } then { run_elf_list_test "section2" "$target_machine" "$as_flags" "-s" "" } run_dump_test "section3" - run_dump_test "section4" + run_dump_test "section4" $dump_opts if {! [istarget "h8300-*-*"] && ! [istarget "rx-*-*"]} then { # The h8300 port issues a warning message for # new sections created without atrributes. @@ -255,8 +256,8 @@ if { [is_elf_format] } then { run_dump_test "section7" run_dump_test "section8" run_dump_test "section9" - run_dump_test "section10" - run_dump_test "section11" + run_dump_test "section10" $dump_opts + run_dump_test "section11" $dump_opts run_dump_test "section12a" run_dump_test "section12b" run_dump_test "section13" @@ -279,11 +280,7 @@ if { [is_elf_format] } then { run_dump_test "section27" run_dump_test "section28" run_dump_test "section29" - if { ![istarget "rx-*-*"] } then { - run_dump_test "section30" - } else { - run_dump_test "section30" {{as -muse-conventional-section-names}} - } + run_dump_test "section30" $dump_opts run_dump_test "sh-link-zero" run_dump_test "size" run_dump_test "dwarf2-1" $dump_opts @@ -370,7 +367,7 @@ if { [is_elf_format] } then { run_dump_test "strtab" - run_dump_test "bignums" + run_dump_test "bignums" $dump_opts run_dump_test "section-symbol-redef" run_dump_test "pr27228" } --- a/gas/testsuite/gas/elf/group1a.d +++ b/gas/testsuite/gas/elf/group1a.d @@ -1,8 +1,6 @@ #readelf: -SW #name: group section with multiple sections of same name (using readelf -SW) #source: group1.s -# The RX port uses non-standard section names. -#xfail: rx-* #... [ ]*\[.*\][ ]+\.group[ ]+GROUP.* --- a/gas/testsuite/gas/elf/groupautoa.d +++ b/gas/testsuite/gas/elf/groupautoa.d @@ -1,8 +1,6 @@ #readelf: -SW #name: automatic section group a #source: groupauto.s -# The RX port uses non-standard section names. -#notarget: rx-* #... [ ]*\[.*\][ ]+\.group[ ]+GROUP.* --- a/gas/testsuite/gas/elf/section10.d +++ b/gas/testsuite/gas/elf/section10.d @@ -1,7 +1,5 @@ #readelf: -N --wide #name: numeric section flags and types -# The RX port annoyingly reorders the sections so that they do not match the sequence expected below. -#xfail: rx-*-* #... [ ]*\[.*\][ ]+.text --- a/gas/testsuite/gas/elf/section11.d +++ b/gas/testsuite/gas/elf/section11.d @@ -1,11 +1,6 @@ #as: --no-pad-sections #readelf: -S --wide #name: Disabling section padding -# The RX port uses non standard section names. -#xfail: loongarch*-* rx-*-* -# LoongArch and RISC-V handles alignment via linker relaxation, so object files don't have -# the expected alignment. -#xfail: riscv*-*-* #... \[ .\] .text[ ]+PROGBITS[ ]+0+00 0+[0-9a-f]+ 0+0(1|4|5) 00 AX 0 0 16 --- a/gas/testsuite/gas/elf/section4.d +++ b/gas/testsuite/gas/elf/section4.d @@ -1,7 +1,5 @@ #readelf: --sections #name: label arithmetic with multiple same-name sections -# The RX port uses non-standard section names. -#xfail: rx-* #... [ ]*\[.*\][ ]+\.group[ ]+GROUP.*