From patchwork Fri Dec 15 12:14:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 179238 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp9225150dys; Fri, 15 Dec 2023 04:14:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IFjVc2R+ymIZja7wOc+/Lf0zEy/PrcIkqGWDWVWngKOOfaAZwvLKcxe3elpjCTRaypA41VX X-Received: by 2002:ac8:5802:0:b0:418:1ce4:72ae with SMTP id g2-20020ac85802000000b004181ce472aemr14091062qtg.54.1702642493142; Fri, 15 Dec 2023 04:14:53 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1702642493; cv=pass; d=google.com; s=arc-20160816; b=ky9P5TQmgwndASkphx72muespbCu6eSl4WJMTMQrZ1qx6pIP5ojz2ztV7E/V2OdFlD 6jkEStWTkWTvZICiQBgHnK6ZXZhRyM29VCesb4MLDjfRzT2X0a+uQ3yhcMXSq5C632Fg G4jCRUfmA/utts8oL6ZmkT7olH8u32LNB8gcpmtrx57jxsr49q4mqFnbrUOynhTpwup5 XhLgXrCZO+9CiLeB1TddBK4xCHdobt+St1M2kvvabBaUmOz6+dFLtMjf+XeZgN4Bdazj KqgNyYqFGf3p9+ameIcudddrsrg8FBLlhV3nrcLMZmTJQUUBU3doOfB1FCf53HNrLjK7 6KBw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :in-reply-to:autocrypt:references:cc:to:from:content-language :subject:user-agent:mime-version:date:message-id:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=hFEn9vHkBwV21ChWpPol71Rm2jMghTsS4UQ9n4Yws5U=; fh=fl2hWRsm7syaPDF0inlJCxwhtB5XpFVkYEfkZZT/1AI=; b=K2APnxO3HXFuTfP5FsAPu3ZG4+oXZG17FW7cMafHEHPC5Hg+/1w5EC4Bvy1lOAHfEw HQkJZnhB7aoFA3Etm51IYsbXrFEpygsxRkUCAreWmA19cauUbCXvVVGA4oLxY1+USlRE yilzucN2d8zEkiESj6vOnSTMkzBBt3ZCpuSKQ5WYyml/mCosMbo4IMDnchWSc5o7CNbp j6X6tSLmewIoqCRj14v6p7UoK7wymwc/NwMy9QyGLX/Le4oQj/ELCo/UDpSX+g1E5fOg Y62HFlh+xRyXFl9JQJbo8ipZSpKIbmod/IRDNQLrcH6rmurS8JtHtLY/whz/7Z9F/oHH EKKw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.com header.s=google header.b=RzgJzwsn; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id x5-20020ac87ec5000000b004254e6fa552si6238546qtj.339.2023.12.15.04.14.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 04:14:53 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=google header.b=RzgJzwsn; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DABCF3847819 for ; Fri, 15 Dec 2023 12:14:52 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by sourceware.org (Postfix) with ESMTPS id 8D04C3847718 for ; Fri, 15 Dec 2023 12:14:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8D04C3847718 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8D04C3847718 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::22d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702642488; cv=none; b=wvim5S79Cup190BYM6AZ+cbGe5lGQ38xHYeIWUZGGPni0Ux+3w4V/viZTk2HCHzCCe207nUNMRwC/3Oy3kscXZOYPbaz04pC/ersN3RuTPiy6YJWPuLjD5zxMpL70k167xG1QpRrk6RzPPfooPaRx6O0bpCvvy924WJhSDwxbdU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702642488; c=relaxed/simple; bh=mp/0+0dZJjW9D58t9GRYcoqyB6eJ/b5uxbqaj29udJ4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=nC/G8IKvx58iOJxUX0mJ5FMlgpCcLpPAnBOajW+MVz7Gh9WCtQ3wmy6Db6L8Q8P9okMlCJa/0fi4HlES8Q6PPqjkasUAJC/BPj+6DtwOZHnkePu2890uquMbOzF/mTruqNozl+6u2sr2mhPBO1otQ9HnHqM6CiSboEDDc7J9t1k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2ca00dffc23so6792561fa.2 for ; Fri, 15 Dec 2023 04:14:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1702642485; x=1703247285; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=hFEn9vHkBwV21ChWpPol71Rm2jMghTsS4UQ9n4Yws5U=; b=RzgJzwsnyYneo5jxaUSnYjxnZ4RCWgNOV3DVp7UY2txOMyKvCQhgHwvLcHg0Uqsm4P Q/0n/+RJ03hOCzwyd8GPd7lFIfqh3uspNXSgA0qAMrL6XUJvi1rt3ugnbcVwh2ubkZA/ raB0+H0CZtQb28MsZZKUyK+ZK5J8lLqWTjrJjdbS0Js5b/LyyafjTP6nEpMyAS8LLVb3 V5ni5miFXJlCMmZ8UHLQUlPJwX8uBHxdsJUzzjtQLJxBP8lVINi1gPbQhzpFFKllpAZ2 oqqCUabfd/699/mQwWV6OK9sTC1VZb2kfftlP2v045X/ZVMAj7G8vgzNB8Onp8Ws12Yw TLoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702642485; x=1703247285; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hFEn9vHkBwV21ChWpPol71Rm2jMghTsS4UQ9n4Yws5U=; b=jiIOJZKXwx2HELb9oNmJFt+0opvMahvVqtgD9Xwt5uUpOgNONKMiwe08FhO7XRcmKn 9+0V0neTh5BHkPttTi/AYVjK2y4CrKrWaJwpB3+7mhfL6oAuk4a9RYw2u85PobrfZFj/ 9l2E/vplFuqr+xCFakgmtMk9pGOwnL8RY/X45BgkSbnSBh3TOBprcCF/rQgZQcpXAl+5 CHsxVSGE5XIm+USF8bcmKId8LOv7a9lAQdhEAmqPqlH5GwiKhjiYAWwoGtu122pKLtmB TfZzEeXyRedKe0HVPuzMy3cAtok1YhpyGMgwsnsnuXa6aDx40Fm5bOZDjXggipxTY2+Z JFXA== X-Gm-Message-State: AOJu0YxKevxO/vLr6ftUFB5L+kP3SH4OpSUCCyMfyPuR5qygLoBay0H3 Ga2XVByjzuEINMxsAmTllQwznOf5TuS0mrXNnY5a X-Received: by 2002:a2e:b8c4:0:b0:2cb:7b4c:18de with SMTP id s4-20020a2eb8c4000000b002cb7b4c18demr4840656ljp.25.1702642485050; Fri, 15 Dec 2023 04:14:45 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id k9-20020a056e02156900b0035da74cd896sm4764564ilu.77.2023.12.15.04.14.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Dec 2023 04:14:44 -0800 (PST) Message-ID: Date: Fri, 15 Dec 2023 13:14:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 12/22] score: drop .bss override Content-Language: en-US From: Jan Beulich To: Binutils Cc: Nick Clifton , Alan Modra References: <5e1fe3bc-78ca-4c54-a19c-f8efa015f839@suse.com> Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <5e1fe3bc-78ca-4c54-a19c-f8efa015f839@suse.com> X-Spam-Status: No, score=-3026.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785350054700198986 X-GMAIL-MSGID: 1785350054700198986 The comment looks bogus (perhaps simply stale, or wrongly copied from another target). It also doesn't look to be a good idea to override the custom handler that ELF has (afaict doing so broke .previous as well as sub-section specification). While there also fold the identical handlers for .text (there likely is more room for such folding). --- a/gas/config/tc-score.c +++ b/gas/config/tc-score.c @@ -24,8 +24,6 @@ #include "tc-score7.c" -static void s3_s_score_bss (int ignore ATTRIBUTE_UNUSED); -static void s3_s_score_text (int ignore); static void s3_score_s_section (int ignore); static void s3_s_change_sec (int sec); static void s3_s_score_mask (int reg_type ATTRIBUTE_UNUSED); @@ -39,7 +37,6 @@ static void s3_s_score_gpword (int ignor static void s3_s_score_cpadd (int ignore ATTRIBUTE_UNUSED); static void s3_s_score_lcomm (int bytes_p); -static void s_score_bss (int ignore ATTRIBUTE_UNUSED); static void s_score_text (int ignore); static void s_section (int ignore); static void s_change_sec (int sec); @@ -196,7 +193,6 @@ symbolS *GOT_symbol; const pseudo_typeS md_pseudo_table[] = { - {"bss", s_score_bss, 0}, {"text", s_score_text, 0}, {"word", cons, 4}, {"long", cons, 4}, @@ -5532,22 +5528,6 @@ s3_do_dsp3 (char *str) s3_inst.relax_inst = 0x8000; } - -/* If we change section we must dump the literal pool first. */ -static void -s3_s_score_bss (int ignore ATTRIBUTE_UNUSED) -{ - subseg_set (bss_section, (subsegT) get_absolute_expression ()); - demand_empty_rest_of_line (); -} - -static void -s3_s_score_text (int ignore) -{ - obj_elf_text (ignore); - record_alignment (now_seg, 2); -} - static void s3_score_s_section (int ignore) { @@ -6324,21 +6304,10 @@ s3_build_dependency_insn_hsh (void) } static void -s_score_bss (int ignore ATTRIBUTE_UNUSED) -{ - if (score3) - return s3_s_score_bss (ignore); - else - return s7_s_score_bss (ignore); -} - -static void s_score_text (int ignore) { - if (score3) - return s3_s_score_text (ignore); - else - return s7_s_score_text (ignore); + obj_elf_text (ignore); + record_alignment (now_seg, 2); } static void --- a/gas/config/tc-score7.c +++ b/gas/config/tc-score7.c @@ -5367,21 +5367,6 @@ s7_build_reg_hsh (struct s7_reg_map *map -/* If we change section we must dump the literal pool first. */ -static void -s7_s_score_bss (int ignore ATTRIBUTE_UNUSED) -{ - subseg_set (bss_section, (subsegT) get_absolute_expression ()); - demand_empty_rest_of_line (); -} - -static void -s7_s_score_text (int ignore) -{ - obj_elf_text (ignore); - record_alignment (now_seg, 2); -} - static void s7_s_section (int ignore) {