diff mbox series

x86: remove indirection from bx[] and di_si[]

Message ID e05223c9-40d4-ae46-5b5a-3d0f7e1e6d79@suse.com
State Accepted
Headers
Series x86: remove indirection from bx[] and di_si[] |

Checks

Context Check Description
snail/binutils-gdb-check success Github commit url

Commit Message

Jan Beulich Aug. 14, 2023, 11:56 a.m. UTC 
  The longest register name is 3 characters (plus a nul one), so using a
4- or 8-byte pointer to get at it is neither space nor time efficient.
Embed the names right into the array. For PIE this also slightly reduces
the number of base relocations in the final image.
---
di_si[], looking at its contents, also is somewhat misnamed, I would
say.
diff mbox series

Patch

--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -12250,13 +12250,13 @@  i386_index_check (const char *operand_st
       /* Memory operands of string insns are special in that they only allow
 	 a single register (rDI, rSI, or rBX) as their memory address.  */
       const reg_entry *expected_reg;
-      static const char *di_si[][2] =
+      static const char di_si[][2][4] =
 	{
 	  { "esi", "edi" },
 	  { "si", "di" },
 	  { "rsi", "rdi" }
 	};
-      static const char *bx[] = { "ebx", "bx", "rbx" };
+      static const char bx[][4] = { "ebx", "bx", "rbx" };
 
       kind = "string address";