From patchwork Mon Nov 28 11:32:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 26640 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp5594067wrr; Mon, 28 Nov 2022 03:32:37 -0800 (PST) X-Google-Smtp-Source: AA0mqf4foOCkDN4BCLnxIkOgIXICkSQVog1smGEMbati7vlOG/ETkQ958NL6xYlkNj6bUYTb394m X-Received: by 2002:a17:906:2345:b0:7ad:adfe:1ceb with SMTP id m5-20020a170906234500b007adadfe1cebmr34834430eja.89.1669635157788; Mon, 28 Nov 2022 03:32:37 -0800 (PST) Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id n12-20020aa7d04c000000b004549b880c67si8890554edo.42.2022.11.28.03.32.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 03:32:37 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=aNxQJlDJ; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4D2E5384F6C6 for ; Mon, 28 Nov 2022 11:32:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4D2E5384F6C6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669635139; bh=uv2noujoBqXak0dW5I4MB2dTVxX+y6ZnCKpwoaUxTGU=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=aNxQJlDJkQQ4tPtj4djU2dInQpbtqu+yPMLffwVE8s7WDA81UhW9eZIuo7Gp/Ktnj RoHsoxqOnrbWEyXkCnNCl2OxMdyFo4lSIpAgSqqCsXlyMggLjaeNaMSyRTqRH8RiQf rqszaoOjDRNd5JhBw2rewSBS3eMSOx/aXZJ8bhec= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2051.outbound.protection.outlook.com [40.107.241.51]) by sourceware.org (Postfix) with ESMTPS id 46B5A3852C63 for ; Mon, 28 Nov 2022 11:32:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 46B5A3852C63 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OGcrLt9JfgUc9SeCoNHSM+7Jsa1awnzCYFpI0HbSeTO4E3YpWYlHqOnaZ3OO/xQ5gHfxf7BZc4cb/D38fQ3u23rVPyHs4Nd9XPLvd7KMOAv5PAgLdUG4MGwJT74DHgy3gEqonVOgUiijz+nBda7mR/n91lSXv/ZWHfSUqzcT3LwuhffhnG/+geUqqS30QqHaIzTg6d1tt+k4AsMxSIdxN4xePs2QgDZxpeO7f1Am81knDJ1OiMEEU4c40/O4nlkQ3T5sYYMtQPwhetVIALsu05bWwpviizgm34cIzwkOzdO2/aw78WnEB7FTb+doj1HskcvwPEi+APurReC5IPziJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uv2noujoBqXak0dW5I4MB2dTVxX+y6ZnCKpwoaUxTGU=; b=CsDUjcFCj0N2HRZN/AWyCf01hN+XwBrGUYyw9p+dm28KhOxoEutqLBBTc7ZzrF/fdyp0hwhj0evGFHDGG6DZjCR9o8WAVAJ9LMW98GPg6mhfKJSxVmRwmiybz9yH38oJozFRpIRdWdR3jP2Gg8i9x03rEuU5PX3mH+/A+r83UWZp6BgbDafzOiPnH6Avxl1vqq6ZlAa9bikKXmSRQXpa5QSbxX7k34UTOjKjC+w7ubsUx4OJeSO4O+OLAQLslcvwQtl7jLI6B/ecY2lEiqxceqnrbXtfwD1nRQ2xeAjUYF5vpOV7npp4xtBGVBz5B7kAusHqtBQUJ+4G9IG7pBRd8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6929.eurprd04.prod.outlook.com (2603:10a6:208:181::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Mon, 28 Nov 2022 11:32:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Mon, 28 Nov 2022 11:32:08 +0000 Message-ID: Date: Mon, 28 Nov 2022 12:32:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: [PATCH v3 4/6] x86: add generated tables dependency check to gas Content-Language: en-US To: Binutils Cc: "H.J. Lu" References: <8f385c36-cfe5-1b0a-45b6-ea6c008b20c8@suse.com> In-Reply-To: <8f385c36-cfe5-1b0a-45b6-ea6c008b20c8@suse.com> X-ClientProxiedBy: FR2P281CA0075.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6929:EE_ X-MS-Office365-Filtering-Correlation-Id: 04391b40-1eed-4c6e-ec92-08dad1342f2d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2eOF1t4j/SZOJj5/1ip2bAOfAqSJuEnm7s2z0U6WrDmmiu8RZBBH7jF9X++E6dlxQZPlIp6JK2xS0JyP4SmfSB1jUagVUzj8KDcDr1UWeEeN86+KxHSAL9FurD+dw9b4wosl4DRbbcXoQaw0PbkQ4qkQhrC3iIQfX9yplHuOPMd0A9Rmz50iG4oJIBWay5W8mVJnHMJyuqD2Jx5H7kppjwkprrGxJJ4X9E+j8V+JeXLunY3Kfw5SwlR3PCJxtxPrLN3vShOcXHWrpQ45K+PBCk9/oHot0WhbC+62uoEiFXSxzwUYIoYE0WtCg4nybqR5CoSsd7u1oeWXSN1pZIMfQcLpYNCzqqp0RezBLwpyAQueHwUjP7Eg5piaNZ776EQdsnKqMZ6bLcWXHvJU3mlqI0sjkADoMTFC9txvQbGUVYD5wtRCZ8hjdRegDsnZ6c35f+oVrmsEE0JvtSm4B89JoWNkvfHYw9TQQuQmZYltpDwL2TjrBDXQzJEa/lWsqICOLYc8Vqvd3+rlUCs/rVkU6ukYwJ8q6ZzJqtylKKFYjKx2EuO3g3IjlsK7bDhZPhYv2QYaYSX2ZVZt0MVVdqDU+0SuAFm5tYcag2IzqtegtM3LYb3gf2a4G4UMGcyJPH+tnKDZmJ7vNJeRFb1JmQ3pquDwsrDMk6aZohYlnIAQEDzs1JwUsr2r/FeN5LiH98jb/6I/9WSGhwCD8KVm2/eg7bm/JvC2w3ThGCrj4RsjF0g= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(396003)(136003)(376002)(346002)(39860400002)(451199015)(2616005)(31686004)(2906002)(83380400001)(6512007)(6506007)(38100700002)(66946007)(66476007)(41300700001)(66556008)(8676002)(6486002)(36756003)(26005)(478600001)(186003)(5660300002)(8936002)(4326008)(86362001)(31696002)(316002)(6916009)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?iFKm1RvI++IFJhkkvQVRhZFJnZ3M?= =?utf-8?q?pvDE4u2TnPdehv0NsiNV5+vFq3bw3UMrwHKaTPcRKEIHkzqzbQ6GuoSmZKEMsFars?= =?utf-8?q?l3PQTvOXFKVPvmagAbnyPRNn2nQV9JsBdgRAVrNwU2WfMS3R9GwTmcNptfTrFRJ0r?= =?utf-8?q?YynlszvI3Gt9PEBopeSildkO7tkH3GhYFRq1SI44oNdWnUXlVGGCsO61dTwwKOC79?= =?utf-8?q?nojF3/QskRMcRtnXUTUGbb26xbf7HHr1mnxl3fy4N3V66BJMCJ/2wWtmIF9vv1hiq?= =?utf-8?q?qpAozhu9p3XvBABU72OCq4vRdaL4Tfw9CRrNV/L7cdfQWFAyWPS86hjOvmRdKpzHd?= =?utf-8?q?kTc7/6l+48V/97BT+k3dShF4w7HpbXqx5e8u94RMXwQgSlmvnAtn8P68TD7F/oOr4?= =?utf-8?q?XpxXtGf48KFEqpZqWoLbimHkF0joFnKbvQacOVMD6hyHr09gRasdXUkp4fIy6AkdM?= =?utf-8?q?ltlUZbjoLJH6K9GJg5U+QSt21JDrn2LRsDs0cRNaMF/GPBfB8AHAVex55sgEUVkc3?= =?utf-8?q?PycEs8pT8qiek8nBJGPalfAwCZ/qzTaT43Zf0E+toYWfXnfRufYysQ3HzbwscrD4y?= =?utf-8?q?w7bsQ23f8s2GoHZ+urvtFzQqVEqi8mXJpL5St8QoLYf9Mubb9g9fVWDiUU9gflp79?= =?utf-8?q?GtWrIPwbQqqNiVC3e5UT23yIbwGOnhHopk8g5sXGPry8qBENW3mlRFxqP25TsMOAA?= =?utf-8?q?Fr+dKP3zB9q0zetrqg+kLvshgKue56hMAJxM4TlCcuIRIwoiSBfJmMqbhVO/Wcs39?= =?utf-8?q?5OncsL3QEdY6DDCFlwQ34Jk91kRAH9+1z9WW6kd/LJbSm8dI34tTPz6sW9OuuC42v?= =?utf-8?q?KTp+J2vlh7GBKKS4yvO/RQbRqwB4UlxUVCWKNgA5z48LemSXxmtfe9xhj+Sq6txV2?= =?utf-8?q?QKKLMrC3Ek2/F3byQsxUqHq/S93DOFLJWP9+gN8MrDvFABnly41qyDterVOoo6aUj?= =?utf-8?q?iDOgnt5LCl45e9T63DhNUanN0pzp4HFZzjEsrwDoT3O41ZGAMnfTuAfteqhPYsdCu?= =?utf-8?q?WuSNeRFUy1NBCgpygwhC0OJgn2pnFMo13Zrgn0+AwDTacu/vu8RP8+Oc5dM4t3Wix?= =?utf-8?q?uQ+slmhUOo+FcfimfH9oRZPznJv9MknBQAW4cwdCUx/f8iVRrg+k263sr5GLWB6UM?= =?utf-8?q?cON5VZFR11xKJMhjkmr5D/zbjStzHdWqammlwY00+KFlF2EJAnGtXCkoM4DuLg5j7?= =?utf-8?q?ZELSeWiiM/0oM4OBiLNCzgF96X+I11BVV6nm/pd/VSpUz34k9wXVJiF3dkX9nRqHr?= =?utf-8?q?HvxNj9BF81heM8iprdFdbm1OFJYN+QU//fFeoqSnqz5MINk/dQxg+RQLkv4W2Lt+S?= =?utf-8?q?+1VuO885/1diqWQjcKN2b7xcKyFfGnFfF32y7tp+fmq6cLAi9yZQsHECCE9iFJWIj?= =?utf-8?q?IQ7lo6fhfhNC1J9HtRban+MptK78tij2zIyITzMdx6GUKffxYmPvTSwS7E4zFXwuk?= =?utf-8?q?oJKBxHXZQGEfflJQkPvMPBSim+YHuN5Q7LpwUwa1slrolkwmiGmo5tlficMhNQrrZ?= =?utf-8?q?GhJR0kVVblZB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04391b40-1eed-4c6e-ec92-08dad1342f2d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 11:32:08.7639 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HXj/6TqKcOmNdUa1xbTDramjC+lwAhU3fo3wI2bZWE7RMyZr5+Tqwl+uyKVJmSsQ1yQ/JDyo+i7/CyVIBJdDKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6929 X-Spam-Status: No, score=-3029.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Beulich via Binutils From: Jan Beulich Reply-To: Jan Beulich Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750739355055137353?= X-GMAIL-MSGID: =?utf-8?q?1750739355055137353?= As requested by H.J., just for the sake of people potentially building in gas/ alone, add a check that the generated files in opcodes/ are actually up-to-date. Personally I think this should at best be a warning, but I can see how this may not be easily noticable among other make output (depending in particular on the verbosity level). --- v3: New. --- a/gas/Makefile.am +++ b/gas/Makefile.am @@ -446,6 +446,17 @@ development.exp: $(BFDDIR)/development.s $(EGREP) "(development|experimental)=" $(BFDDIR)/development.sh \ | $(AWK) -F= '{ print "set " $$1 " " $$2 }' > $@ +config/tc-i386.o: $(srcdir)/../opcodes/i386-init.h $(srcdir)/../opcodes/i386-tbl.h + +i386_tbl_deps = $(srcdir)/../opcodes/i386-opc.tbl \ + $(srcdir)/../opcodes/i386-reg.tbl \ + $(srcdir)/../opcodes/i386-gen.c $(srcdir)/../opcodes/i386-opc.h + +$(srcdir)/../opcodes/i386%init.h $(srcdir)/../opcodes/i386%tbl.h: @MAINT@ $(i386_tbl_deps) + @echo '"$@" is outdated wrt "$?"' >&2 + @echo 'Please rebuild from the top level or in $(CURDIR)/../opcodes/' >&2 + @false + EXTRA_as_new_SOURCES += config/m68k-parse.y config/m68k-parse.c: $(srcdir)/config/m68k-parse.y $(SHELL) $(YLWRAP) $(srcdir)/config/m68k-parse.y y.tab.c $@ -- $(YACCCOMPILE) --- a/gas/Makefile.in +++ b/gas/Makefile.in @@ -902,6 +902,10 @@ EXTRA_as_new_SOURCES = $(CFILES) $(HFILE EXPECT = expect RUNTEST = runtest RUNTESTFLAGS = +i386_tbl_deps = $(srcdir)/../opcodes/i386-opc.tbl \ + $(srcdir)/../opcodes/i386-reg.tbl \ + $(srcdir)/../opcodes/i386-gen.c $(srcdir)/../opcodes/i386-opc.h + itbl_test_SOURCES = itbl-parse.y itbl-lex.l itbl_test_LDADD = itbl-tops.@OBJEXT@ itbl-test.@OBJEXT@ $(GASLIBS) @LEXLIB@ @@ -2060,6 +2064,13 @@ check-DEJAGNU: site.exp development.exp: $(BFDDIR)/development.sh $(EGREP) "(development|experimental)=" $(BFDDIR)/development.sh \ | $(AWK) -F= '{ print "set " $$1 " " $$2 }' > $@ + +config/tc-i386.o: $(srcdir)/../opcodes/i386-init.h $(srcdir)/../opcodes/i386-tbl.h + +$(srcdir)/../opcodes/i386%init.h $(srcdir)/../opcodes/i386%tbl.h: @MAINT@ $(i386_tbl_deps) + @echo '"$@" is outdated wrt "$?"' >&2 + @echo 'Please rebuild from the top level or in $(CURDIR)/../opcodes/' >&2 + @false config/m68k-parse.c: $(srcdir)/config/m68k-parse.y $(SHELL) $(YLWRAP) $(srcdir)/config/m68k-parse.y y.tab.c $@ -- $(YACCCOMPILE) config/m68k-parse.h: config/m68k-parse.c