From patchwork Mon Nov 28 04:47:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tsukasa OI X-Patchwork-Id: 26505 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp5434262wrr; Sun, 27 Nov 2022 20:52:06 -0800 (PST) X-Google-Smtp-Source: AA0mqf5Y3SknFHUQDKm5TBr5NQP6isv6sqyhOyvmUFoVvX/WNdswlIsALe2TZfHQwij8F/TX5H+r X-Received: by 2002:a05:6402:5011:b0:469:9c84:3bdd with SMTP id p17-20020a056402501100b004699c843bddmr5401782eda.302.1669611126346; Sun, 27 Nov 2022 20:52:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669611126; cv=none; d=google.com; s=arc-20160816; b=blLmwXj+Eop0vyoSlehGn9IfMVfz2j3oQDBGBfsPv5z9PrOzSCgt3utPvepVHzBJYe mvyFdMg470QdIiU/tXcO7aqniu8C1eeliOS0z5y3zyV803Ta5b2Ad+0GpTYgcMRZDSua BquZN8hTnd3J6xDQqzfsmUkFRtsrfNHoJrGIEA99pHx+p3ijuM/vS6LK1gnF/PXIFcUo XD3UQeuxBUkzKxGoMWdqQ3maHP9Qo4LAj02ll5R+XvrMPgmI2P8qgK0B4xZ6Fev/HbK0 Onjtl/YMFwhs6gzAx3eqBmaZXFsY0yBbcouEUanljZN7x7XEVIf3vtS7UeBdBoxPSd23 PI0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=uAgpZsDVSo0FlFcs6R8Bh3QMLwLjF6ak+6JuXjkjWI0=; b=xVviJzMFeUhL77UuDbJ+4CnaSi62/gRUlYUHAhHm8da0IUrfEk4xZgI2XZBQhuhMjY Kpx6sB6tt8hFxqTlF+6iBpxjEMiqHhioEEb4fQt148B9phgIXTPCKbrtCj/S3XxbP8O5 zHoQ7dOj4H1iv2qZosqShvNEjAGT2JGbUg0IFkwI6X96z4PijLkcQbEx0LS62Gnv2ARl cliqMv59nm//k8/E8q61FDl6J2WZT7y1Dentrb4+jvVR+9cAvXSWJJmoSbVZvqmiXn0c +D0Ts+WTRw4ZVxXDVIigrtrWVMiznlhMQiY5GLiCwD9PnBejdWd67/jW5qaDTBu/SNH4 wseg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b="ykIC9Z/N"; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id z3-20020a1709067e4300b0078dd12d0a9fsi6575364ejr.548.2022.11.27.20.52.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Nov 2022 20:52:06 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b="ykIC9Z/N"; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9C7903959C73 for ; Mon, 28 Nov 2022 04:48:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9C7903959C73 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669610894; bh=uAgpZsDVSo0FlFcs6R8Bh3QMLwLjF6ak+6JuXjkjWI0=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=ykIC9Z/NTgNcXLne2U8JbNCkrJy5LtdgjyaYXnmXFNV/UE6D9pVMi5zjzlT/zYvi3 yyO6u8iJrRhdwBZNNH3lYGmrKDtGjL2lHTl65DprbtcDUnV1sQA8iz7iw3Q/drn/ok NLESIxbRQZJhS2+Hh+6Fqfu7483RWHf4KZ48Gxx4= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id DC2D03954416 for ; Mon, 28 Nov 2022 04:47:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DC2D03954416 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 3C391300089; Mon, 28 Nov 2022 04:47:38 +0000 (UTC) To: Tsukasa OI , Nelson Chu , Kito Cheng , Palmer Dabbelt Cc: binutils@sourceware.org Subject: [PATCH v2 1/3] RISC-V: Easy optimization on riscv_search_mapping_symbol Date: Mon, 28 Nov 2022 04:47:21 +0000 Message-Id: In-Reply-To: References: Mime-Version: 1.0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tsukasa OI via Binutils From: Tsukasa OI Reply-To: Tsukasa OI Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749975471592077723?= X-GMAIL-MSGID: =?utf-8?q?1750714156833709012?= From: Tsukasa OI Before further optimization, we can optimize the function riscv_search_mapping_symbol a bit for clarity. opcodes/ChangeLog: * riscv-dis.c (riscv_search_mapping_symbol): Make MAP_INSN default considering major usecases. Remove setting found here as no one uses the value after setting this. memaddr cannot be negative so simplify and change comment. Idea-by: Nelson Chu --- opcodes/riscv-dis.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c index eb3e64816bf6..bb7c03ad5fbf 100644 --- a/opcodes/riscv-dis.c +++ b/opcodes/riscv-dis.c @@ -1134,18 +1134,16 @@ riscv_search_mapping_symbol (bfd_vma memaddr, /* Decide whether to print the data or instruction by default, in case we can not find the corresponding mapping symbols. */ - mstate = MAP_DATA; - if ((info->section - && info->section->flags & SEC_CODE) - || !info->section) - mstate = MAP_INSN; + mstate = MAP_INSN; + if (info->section && (info->section->flags & SEC_CODE) == 0) + mstate = MAP_DATA; if (info->symtab_size == 0 || bfd_asymbol_flavour (*info->symtab) != bfd_target_elf_flavour) return mstate; - /* Reset the last_map_symbol if we start to dump a new section. */ - if (memaddr <= 0) + /* Reset the last_map_symbol if the address is zero. */ + if (memaddr == 0) last_map_symbol = -1; /* If the last stop offset is different from the current one, then @@ -1197,7 +1195,6 @@ riscv_search_mapping_symbol (bfd_vma memaddr, if (riscv_get_map_state (n, &mstate, info, true)) { symbol = n; - found = true; break; } }