diff mbox series

RISC-V: Remove support for non-existing 'Zve32d'

Message ID	c49785eeb1885a92491782d9a7da60353013fdbb.1691025541.git.research_trasio@irq.a4lg.com
State	Accepted
Headers	Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7CF3D3858280 To: Tsukasa OI <research_trasio@irq.a4lg.com>, Palmer Dabbelt <palmer@dabbelt.com>, Andrew Waterman <andrew@sifive.com>, Jim Wilson <jim.wilson.gcc@gmail.com>, Nelson Chu <nelson@rivosinc.com>, Kito Cheng <kito.cheng@sifive.com> Cc: binutils@sourceware.org Subject: [PATCH] RISC-V: Remove support for non-existing 'Zve32d' Date: Thu, 3 Aug 2023 01:19:19 +0000 Message-ID: <c49785eeb1885a92491782d9a7da60353013fdbb.1691025541.git.research_trasio@irq.a4lg.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list From: Tsukasa OI via Binutils <binutils@sourceware.org> Reply-To: Tsukasa OI <research_trasio@irq.a4lg.com> Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" <binutils-bounces+ouuuleilei=gmail.com@sourceware.org> X-getmail-retrieved-from-mailbox: INBOX
Series	RISC-V: Remove support for non-existing 'Zve32d' \| RISC-V: Remove support for non-existing 'Zve32d'

Checks

Context	Check	Description
snail/binutils-gdb-check	success	Github commit url

Commit Message

Tsukasa OI Aug. 3, 2023, 1:19 a.m. UTC

  From: Tsukasa OI <research_trasio@irq.a4lg.com>

Since this "extension" does not exist (on the other hand, 'Zve64d' exists)
and it's not useful if we keep it (as other code portions just ignore
"zve32d"), this commit just removes it.

bfd/ChangeLog:

	* elfxx-riscv.c (riscv_supported_std_z_ext): Remove 'Zve32d'
	extension from the list.
---
 bfd/elfxx-riscv.c | 1 -
 1 file changed, 1 deletion(-)


base-commit: 4b177a76d5b759ba631568fb69e8750e99b43647

Comments

Tsukasa OI Aug. 9, 2023, 11:37 p.m. UTC | #1

Note that GCC counterpart is merged.

<https://gcc.gnu.org/pipermail/gcc-patches/2023-August/626747.html>
<https://gcc.gnu.org/pipermail/gcc-patches/2023-August/626862.html>

Thanks,
Tsukasa

On 2023/08/03 10:19, Tsukasa OI wrote:
> From: Tsukasa OI <research_trasio@irq.a4lg.com>
> 
> Since this "extension" does not exist (on the other hand, 'Zve64d' exists)
> and it's not useful if we keep it (as other code portions just ignore
> "zve32d"), this commit just removes it.
> 
> bfd/ChangeLog:
> 
> 	* elfxx-riscv.c (riscv_supported_std_z_ext): Remove 'Zve32d'
> 	extension from the list.
> ---
>  bfd/elfxx-riscv.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
> index ba5165766b2b..1971e6ba6a6b 100644
> --- a/bfd/elfxx-riscv.c
> +++ b/bfd/elfxx-riscv.c
> @@ -1280,7 +1280,6 @@ static struct riscv_supported_ext riscv_supported_std_z_ext[] =
>    {"zkt",		ISA_SPEC_CLASS_DRAFT,		1, 0,  0 },
>    {"zve32x",		ISA_SPEC_CLASS_DRAFT,		1, 0,  0 },
>    {"zve32f",		ISA_SPEC_CLASS_DRAFT,		1, 0,  0 },
> -  {"zve32d",		ISA_SPEC_CLASS_DRAFT,		1, 0,  0 },
>    {"zve64x",		ISA_SPEC_CLASS_DRAFT,		1, 0,  0 },
>    {"zve64f",		ISA_SPEC_CLASS_DRAFT,		1, 0,  0 },
>    {"zve64d",		ISA_SPEC_CLASS_DRAFT,		1, 0,  0 },
> 
> base-commit: 4b177a76d5b759ba631568fb69e8750e99b43647

Nelson Chu Aug. 11, 2023, 12:38 a.m. UTC | #2

Okay, seems it's just a typo,
https://github.com/riscv/riscv-v-spec/commit/3af89ab16dd0ea85b15db35a2cd3c94aae5859a5
.

Thanks
Nelson

On Thu, Aug 3, 2023 at 9:19 AM Tsukasa OI <research_trasio@irq.a4lg.com>
wrote:

> From: Tsukasa OI <research_trasio@irq.a4lg.com>
>
> Since this "extension" does not exist (on the other hand, 'Zve64d' exists)
> and it's not useful if we keep it (as other code portions just ignore
> "zve32d"), this commit just removes it.
>
> bfd/ChangeLog:
>
>         * elfxx-riscv.c (riscv_supported_std_z_ext): Remove 'Zve32d'
>         extension from the list.
> ---
>  bfd/elfxx-riscv.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
> index ba5165766b2b..1971e6ba6a6b 100644
> --- a/bfd/elfxx-riscv.c
> +++ b/bfd/elfxx-riscv.c
> @@ -1280,7 +1280,6 @@ static struct riscv_supported_ext
> riscv_supported_std_z_ext[] =
>    {"zkt",              ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>    {"zve32x",           ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>    {"zve32f",           ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
> -  {"zve32d",           ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>    {"zve64x",           ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>    {"zve64f",           ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>    {"zve64d",           ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>
> base-commit: 4b177a76d5b759ba631568fb69e8750e99b43647
> --
> 2.41.0
>
>

Palmer Dabbelt Aug. 11, 2023, 1:51 a.m. UTC | #3

On Thu, 10 Aug 2023 17:38:37 PDT (-0700), nelson@rivosinc.com wrote:
> Okay, seems it's just a typo,
> https://github.com/riscv/riscv-v-spec/commit/3af89ab16dd0ea85b15db35a2cd3c94aae5859a5
> .

Ya

Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>

>
> Thanks
> Nelson
>
> On Thu, Aug 3, 2023 at 9:19 AM Tsukasa OI <research_trasio@irq.a4lg.com>
> wrote:
>
>> From: Tsukasa OI <research_trasio@irq.a4lg.com>
>>
>> Since this "extension" does not exist (on the other hand, 'Zve64d' exists)
>> and it's not useful if we keep it (as other code portions just ignore
>> "zve32d"), this commit just removes it.
>>
>> bfd/ChangeLog:
>>
>>         * elfxx-riscv.c (riscv_supported_std_z_ext): Remove 'Zve32d'
>>         extension from the list.
>> ---
>>  bfd/elfxx-riscv.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
>> index ba5165766b2b..1971e6ba6a6b 100644
>> --- a/bfd/elfxx-riscv.c
>> +++ b/bfd/elfxx-riscv.c
>> @@ -1280,7 +1280,6 @@ static struct riscv_supported_ext
>> riscv_supported_std_z_ext[] =
>>    {"zkt",              ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>>    {"zve32x",           ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>>    {"zve32f",           ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>> -  {"zve32d",           ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>>    {"zve64x",           ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>>    {"zve64f",           ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>>    {"zve64d",           ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>>
>> base-commit: 4b177a76d5b759ba631568fb69e8750e99b43647
>> --
>> 2.41.0
>>
>>

Tsukasa OI Aug. 11, 2023, 2 a.m. UTC | #4

On 2023/08/11 9:38, Nelson Chu wrote:
> Okay, seems it's just a
> typo, https://github.com/riscv/riscv-v-spec/commit/3af89ab16dd0ea85b15db35a2cd3c94aae5859a5 <https://github.com/riscv/riscv-v-spec/commit/3af89ab16dd0ea85b15db35a2cd3c94aae5859a5>.

Oh, that was also a very "close-to-ratified-1.0" change.

On 2023/08/11 10:51, Palmer Dabbelt wrote:
> Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>

Thanks you two for reviewing! Committed.

Thanks,
Tsukasa

> 
> Thanks
> Nelson
> 
> On Thu, Aug 3, 2023 at 9:19 AM Tsukasa OI <research_trasio@irq.a4lg.com
> <mailto:research_trasio@irq.a4lg.com>> wrote:
> 
>     From: Tsukasa OI <research_trasio@irq.a4lg.com
>     <mailto:research_trasio@irq.a4lg.com>>
> 
>     Since this "extension" does not exist (on the other hand, 'Zve64d'
>     exists)
>     and it's not useful if we keep it (as other code portions just ignore
>     "zve32d"), this commit just removes it.
> 
>     bfd/ChangeLog:
> 
>             * elfxx-riscv.c (riscv_supported_std_z_ext): Remove 'Zve32d'
>             extension from the list.
>     ---
>      bfd/elfxx-riscv.c | 1 -
>      1 file changed, 1 deletion(-)
> 
>     diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
>     index ba5165766b2b..1971e6ba6a6b 100644
>     --- a/bfd/elfxx-riscv.c
>     +++ b/bfd/elfxx-riscv.c
>     @@ -1280,7 +1280,6 @@ static struct riscv_supported_ext
>     riscv_supported_std_z_ext[] =
>        {"zkt",              ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>        {"zve32x",           ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>        {"zve32f",           ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>     -  {"zve32d",           ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>        {"zve64x",           ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>        {"zve64f",           ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
>        {"zve64d",           ISA_SPEC_CLASS_DRAFT,           1, 0,  0 },
> 
>     base-commit: 4b177a76d5b759ba631568fb69e8750e99b43647
>     -- 
>     2.41.0
>

diff mbox series

Patch

diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
index ba5165766b2b..1971e6ba6a6b 100644
--- a/bfd/elfxx-riscv.c
+++ b/bfd/elfxx-riscv.c
@@ -1280,7 +1280,6 @@  static struct riscv_supported_ext riscv_supported_std_z_ext[] =
   {"zkt",		ISA_SPEC_CLASS_DRAFT,		1, 0,  0 },
   {"zve32x",		ISA_SPEC_CLASS_DRAFT,		1, 0,  0 },
   {"zve32f",		ISA_SPEC_CLASS_DRAFT,		1, 0,  0 },
-  {"zve32d",		ISA_SPEC_CLASS_DRAFT,		1, 0,  0 },
   {"zve64x",		ISA_SPEC_CLASS_DRAFT,		1, 0,  0 },
   {"zve64f",		ISA_SPEC_CLASS_DRAFT,		1, 0,  0 },
   {"zve64d",		ISA_SPEC_CLASS_DRAFT,		1, 0,  0 },