From patchwork Fri Sep 30 11:59:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 1591 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp444889wrs; Fri, 30 Sep 2022 04:59:19 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7wWwtVwk4J6pkZPi4vMwMrhXQvVZXMlEi6a0aq37Vwg5S0CaKl09EZLHXlSe3kpx0D1tbo X-Received: by 2002:a17:907:3f1e:b0:782:fd7a:5c27 with SMTP id hq30-20020a1709073f1e00b00782fd7a5c27mr6144203ejc.349.1664539159271; Fri, 30 Sep 2022 04:59:19 -0700 (PDT) Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id u21-20020a1709064ad500b0078193d65ae6si1494631ejt.614.2022.09.30.04.59.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 04:59:19 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=Jv8HVINL; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A9486385483A for ; Fri, 30 Sep 2022 11:59:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A9486385483A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664539155; bh=gtjH2A2qjLtwYqdMfSWfQEdQFiccYGYwpzCmKKxRuQ4=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Jv8HVINLRY94zs1/aurhrfIaQ2+oraEI9b2V5WBgb8QCc289dBj/8HbHqZgXFHlA0 alOz7Xj/PzlUlz+5OKSNE7ScNrPAUFKsuI5PXQWE2YhjrcBwp0Hcj4Em2JgoU/AxhC 0cXRcSJVMGsqRTDofR/StejuHGj3GKmm5EKXuyWY= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2051.outbound.protection.outlook.com [40.107.104.51]) by sourceware.org (Postfix) with ESMTPS id 6C4A83858D1E for ; Fri, 30 Sep 2022 11:59:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6C4A83858D1E ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qik2lStcl0aUViEOTLkZaDyEJ2XT9ODf7IoakKFuIc1Aakp+2u+LqfhIsFUehm/yGhIqmy6ljaexMOhuCPkDnIwduPpsd0dLaHaaiyviUmi1T01RCOy9EWwHfhND79ZAJn6KZpIitVu4ocCwG+t+rMBVWobLOD2NVDJTvittHd2zAqI39N4WG2sgx3HBj2eI4HrwcboM9pmGpFuU9rxV6jNlhbI2IyIyd51EZqgfq4SRS5OfsXjlxc8faMnBGugxggXWa3Dzm6P/uFR1j+13FcaPRcqOZk9rt223gwtDsLTM3Sz4xCDG2O+n15JEVDbtMrsdvIiTUj5o41DuYJpbmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gtjH2A2qjLtwYqdMfSWfQEdQFiccYGYwpzCmKKxRuQ4=; b=FArOgDq+Ta18A4j3+c4qWYk+LRFU7Ce+JEd5M46UGlx1sLEZa6KmI8bZuUYkthhfpEUbJlGTHI11neuuWnzELw88DWyPqcRQiOU8T+OrJQF0ilkN+0i4thcuYBsfB5giSs/N1siNNvU/w7thXFBdSmLGkkQ+Mn+pkojvtrAtoMSDAgn3XRfNJGdTUsQSs8MXCTnE3D/vMOzbQCDt1blwaNv5tDrHIp/PKkfWtLpOkTb5eHpuL31LdtXqkXnIUKrnNv6Zdr3FcoAPDfueQNd9ju1bAJdYWXCU/CX+d7Cq33J3aFs+wYVyNI65UhTHTHDfk4yrumlCXs58uq404sgrlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB8009.eurprd04.prod.outlook.com (2603:10a6:10:1ef::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 11:59:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 11:59:05 +0000 Message-ID: Date: Fri, 30 Sep 2022 13:59:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: [PATCH 1/4] RISC-V/gas: drop riscv_subsets static variable Content-Language: en-US To: Binutils References: In-Reply-To: X-ClientProxiedBy: FR3P281CA0063.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB8009:EE_ X-MS-Office365-Filtering-Correlation-Id: ab1dea26-6c1b-4bf2-9aa2-08daa2db2c66 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6325TeCRC1URy5aKtquU2XrSSPYEi70m2FDXaKGexo3qAhozPTaEcHrbA31KZBBQnV5b5gxhiYfc9rys1Zv1dn+nXcR/zyCB/+NxKF/y9HbPB68J3eaXMKVrB2TxWH9qzcbSUv0AtPborLZu+Q+aH+4bZ+WblZDW4tKRUAzuR6nIcw2APgrWoxqzJGJQGqcH89UwNr7JilF/PhRoSuwlf4J4oQI2X+0zjbneFILNFrmeIheTPPgwtT0Q2fB+/ejsAYEBky8KBN8+2LQvbYjNn3rZPejw/2S14S8jHvjCyw5R334mQyZGztX9Hc3qvmeADcckXBi8ys25AHDhsIP+Sxx8cnXBNocbkXApGSbw1zZwV3xhGhQEfDwIjiSKE7g+prU3l9crZKPG669HUAfKXyuDKUJ2gnSXxVxODZwQalV+u8yUcDg0PbGpaAAaHgPb5boC8fOT56WDjiNqXWdH8L3iDe1bv8sL/b3VrmMU7Ua0AndE5EtXMsoyqP4Qv+tEI2ADXCeW1zKtp8CaAvxW4Ir09zXEwj2yrgVnuBIej2xIhANXlyg3kPJnQIsZ7R60jq+wq8/Qu5iAIcHyOumK23aH+Un+4Jl6jIMdaNB+xbcH2EGzecQQUC/8sy7iveYBVGyZsY2roVh/UZs1QdQArr0pN4Ezo2LjMfuaVSnuMdxbyxfT9t/tidm9kPF5lsIUWeLZWcezt31WLDlTNj4l9fIiiqxf8WBEpJ1xrOVRO2JmNfy/j5hwxcXkePyGlgBcWh/pzttwXjUOG2MvCzIWDs1sHQiqA8Ovg2cYG5Zjo3c= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(136003)(396003)(366004)(376002)(346002)(451199015)(31686004)(2906002)(5660300002)(36756003)(8936002)(38100700002)(66476007)(66556008)(41300700001)(6916009)(8676002)(316002)(66946007)(2616005)(6512007)(26005)(186003)(6506007)(86362001)(478600001)(31696002)(6486002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?qRvNFdmotsqFtI2slJ6JicUdWxab?= =?utf-8?q?ID7rpiETSl/GXcYIil3DWrsA3Uq2zBCqDSPp59sj4lv5ZvGaRERGLKCfHD3BEnNZU?= =?utf-8?q?CyN5z1BFzCJMdTvsM1z39f057374iRiDEdkBAOxRXjMCYXzZYS3DauobmOK6SmxXU?= =?utf-8?q?jkjehHeJ5q6acrRQ8Mw3RWb9yQZkxz95iPezWTItk48kk+kBJeJUmihCfwrrsRj0D?= =?utf-8?q?HNkifG2lS5fpM0B1Fzl7FOLSKL9rgpzlKJ4Z6FPDl3gqDWk8nvyBwrDHnS4NGZ/gn?= =?utf-8?q?jYk9XCCwr57Mm5W6+J4FBI9aipzluicXxW5HGVwWwSBMEaylQa7B7Uc9z8mvq3khD?= =?utf-8?q?sAeknukja0WvyQAH1nyQI9HCe13pSMuVOTrlVLaAgF9do6GFh9N1m760uA8YoUMgz?= =?utf-8?q?9d2mp981F4JNJKLciwCOZhJHONWqm8Kzd/rj9HrgK3fnH2ElN5357qVA+W3QLchDB?= =?utf-8?q?8xZ0ocTweVEBhnjmX20Ea4tKZTB7HgQ46AY8i6lwG30ixfBpuxQ75UtDfHp604Cjl?= =?utf-8?q?0zlHSld1du3SGwH6IslMTS9bphrIIODN8HZzSL0UlduNczjY9jN9oXSk6MPYWf3Rx?= =?utf-8?q?jQpTNTAogc+o9ok/IQrJo3y4HfOX02vTddavCYX7+T2qRTiu3FR9vKWChBHHxiIIm?= =?utf-8?q?7ywHvx/8qJnCC/0v5MdIi45Jov1m2WKz2df9GlG3WAsJM1gxeDiTSIXmw9yGXmkCV?= =?utf-8?q?FldCanNKIEnWXhzTh6HNew4rnCrLd4gU6wdzGveWGePWsfz9e29SlFmzbUFXCxXKl?= =?utf-8?q?idAMZiZDkXI+xdLnqpm24x0I+0VBJHSI/gz+nwkG88yM0Bn30vItvpfXlJI/7brG5?= =?utf-8?q?BF+0GVfL3NtUsQGYP8rCKttUlCF7gRK+bvxIiHf34OtGd/GO8IMBfgfJoK8EdXM+u?= =?utf-8?q?XocHswhUQtdHuMHMW/9zwkxmKMxCF4rg+6W3N4Mykpb65FvNtRYr7dxsINHtIjajc?= =?utf-8?q?qbdiX7WogAX4Jied6QVSkn1q6pHDuRcZ1kTGJ8PYTVClj7WGiB+bvi+G5o6GRdR+u?= =?utf-8?q?mGa+jJSRMyUZbqgClq/TFOGfgMCoGtS2841TckcGnb2lj45vyMoO8u7rd/PfopbFx?= =?utf-8?q?y4LxW/kxGV1zeQKxpt61oJ236jgh9vmbRKgqcgCse+OzrA6xelsOdtEwVpZ6saWkI?= =?utf-8?q?DwnlNnLok2RuoY2FmGJaPJbtuP2PTupha1Cj1O7YmOwk+3PFVmpChKmDSd7GF+NS/?= =?utf-8?q?exIgTiX+o9UgESi6IvfZ7gGHrVEs/c/MENL07nt2c86wq2EER44/Kpg0JBaFOt65s?= =?utf-8?q?WBJk5a8x56aBYZayVtGU6SY0fCCcxmDQ6LGPoDKcvNXYDh1CoO+r3uJuSa9BD1qFe?= =?utf-8?q?9+rpTGZ10NBEUN6Jfw4noa5uttMrGVDLPGqyrwZCt5Soy4v2+Qxic2UPmG51PxRRm?= =?utf-8?q?A6xVFXDwhz+rlCI4lc4amDfflNEfPTfR9LBldcWpq5clWyJOh0UZHLs4wn2QpdQ4q?= =?utf-8?q?GYHtM6ft8APB1kBLnmM3uztO+sOW69TWXEbQXmt0jJtthiFftuhNKqovIObS+gJHh?= =?utf-8?q?i2jj6sDNWPEC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab1dea26-6c1b-4bf2-9aa2-08daa2db2c66 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 11:59:05.4055 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5qSnUZuKdC4Gs6C6JclFcepxxnkrK/N+djimamKU2f5Qea8f4kDoAjoNTZWbH0Ps3YeAyrk//nBFDDlSN/ZPLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8009 X-Spam-Status: No, score=-3030.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Beulich via Binutils From: Jan Beulich Reply-To: Jan Beulich Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1745395813712741336?= X-GMAIL-MSGID: =?utf-8?q?1745395813712741336?= It's fully redundant with the subset_list member of riscv_rps_as. --- a/gas/config/tc-riscv.c +++ b/gas/config/tc-riscv.c @@ -265,11 +265,10 @@ riscv_set_tso (void) elf_flags |= EF_RISCV_TSO; } -/* This linked list records all enabled extensions, which are parsed from - the architecture string. The architecture string can be set by the - -march option, the elf architecture attributes, and the --with-arch - configure option. */ -static riscv_subset_list_t *riscv_subsets = NULL; +/* The linked list hanging off of .subsets_list records all enabled extensions, + which are parsed from the architecture string. The architecture string can + be set by the -march option, the elf architecture attributes, and the + --with-arch configure option. */ static riscv_parse_subset_t riscv_rps_as = { NULL, /* subset_list, we will set it later once @@ -302,14 +301,13 @@ riscv_set_arch (const char *s) return; } - if (riscv_subsets == NULL) + if (riscv_rps_as.subset_list == NULL) { - riscv_subsets = XNEW (riscv_subset_list_t); - riscv_subsets->head = NULL; - riscv_subsets->tail = NULL; - riscv_rps_as.subset_list = riscv_subsets; + riscv_rps_as.subset_list = XNEW (riscv_subset_list_t); + riscv_rps_as.subset_list->head = NULL; + riscv_rps_as.subset_list->tail = NULL; } - riscv_release_subset_list (riscv_subsets); + riscv_release_subset_list (riscv_rps_as.subset_list); riscv_parse_subset (&riscv_rps_as, s); riscv_set_rvc (false); @@ -3986,10 +3984,9 @@ s_riscv_option (int x ATTRIBUTE_UNUSED) s = XNEW (struct riscv_option_stack); s->next = riscv_opts_stack; s->options = riscv_opts; - s->subset_list = riscv_subsets; + s->subset_list = riscv_rps_as.subset_list; riscv_opts_stack = s; - riscv_subsets = riscv_copy_subset_list (s->subset_list); - riscv_rps_as.subset_list = riscv_subsets; + riscv_rps_as.subset_list = riscv_copy_subset_list (s->subset_list); } else if (strcmp (name, "pop") == 0) { @@ -4000,11 +3997,10 @@ s_riscv_option (int x ATTRIBUTE_UNUSED) as_bad (_(".option pop with no .option push")); else { - riscv_subset_list_t *release_subsets = riscv_subsets; + riscv_subset_list_t *release_subsets = riscv_rps_as.subset_list; riscv_opts_stack = s->next; riscv_opts = s->options; - riscv_subsets = s->subset_list; - riscv_rps_as.subset_list = riscv_subsets; + riscv_rps_as.subset_list = s->subset_list; riscv_release_subset_list (release_subsets); free (s); } @@ -4502,7 +4498,7 @@ riscv_write_out_attrs (void) unsigned int i; /* Re-write architecture elf attribute. */ - arch_str = riscv_arch_str (xlen, riscv_subsets); + arch_str = riscv_arch_str (xlen, riscv_rps_as.subset_list); bfd_elf_add_proc_attr_string (stdoutput, Tag_RISCV_arch, arch_str); xfree ((void *) arch_str);