diff mbox series

ld: yet another PDB build fix (or workaround)

Message ID b7e9975b-086f-a9f6-ab6b-0181d50187e1@suse.com
State Accepted
Headers
Series ld: yet another PDB build fix (or workaround) |

Checks

Context Check Description
snail/binutils-gdb-check success Github commit url

Commit Message

Jan Beulich Jan. 6, 2023, 9:33 a.m. UTC 
  Older bash looks to improperly deal with backslashes in here-documents,
leaving them in place on the escaped double quotes inside the parameter
expansion. Convert to a model without using such a construct, by simply
splitting the here-documents into three ones.
---
In pep.em I question, btw, the checking for i?86-*-* targets.

Comments

Alan Modra Jan. 6, 2023, 10:14 a.m. UTC | #1 
On Fri, Jan 06, 2023 at 10:33:00AM +0100, Jan Beulich wrote:
> Older bash looks to improperly deal with backslashes in here-documents,
> leaving them in place on the escaped double quotes inside the parameter
> expansion. Convert to a model without using such a construct, by simply
> splitting the here-documents into three ones.

Thanks, I was about to send you a slightly different work-around, but
since you already posted I won't bother.  :-)
Jan Beulich Jan. 6, 2023, 12:38 p.m. UTC | #2 
On 06.01.2023 11:14, Alan Modra wrote:
> On Fri, Jan 06, 2023 at 10:33:00AM +0100, Jan Beulich wrote:
>> Older bash looks to improperly deal with backslashes in here-documents,
>> leaving them in place on the escaped double quotes inside the parameter
>> expansion. Convert to a model without using such a construct, by simply
>> splitting the here-documents into three ones.
> 
> Thanks, I was about to send you a slightly different work-around, but
> since you already posted I won't bother.  :-)

Yeah, the easy solution occurred to me right after having sent the
initial problem report.

Nick - is this okay for the branch as well?

Jan
Nick Clifton Jan. 6, 2023, 1:05 p.m. UTC | #3 
Hi Jan,

> Nick - is this okay for the branch as well?

Yes - that is fine.

Cheers
   Nick
diff mbox series

Patch

--- a/ld/emultempl/pe.em
+++ b/ld/emultempl/pe.em
@@ -15,13 +15,6 @@  case ${target} in
     ;;
 esac
 
-case ${target} in
-  x86_64-*-mingw* | x86_64-*-pe | x86_64-*-pep | x86_64-*-cygwin | \
-  i[3-7]86-*-mingw32* | i[3-7]86-*-cygwin* | i[3-7]86-*-winnt | i[3-7]86-*-pe)
-    pdb_support=" ";;
-  *)
-esac
-
 rm -f e${EMULATION_NAME}.c
 (echo;echo;echo;echo;echo)>e${EMULATION_NAME}.c # there, now line numbers match ;-)
 fragment <<EOF
@@ -73,7 +66,18 @@  fragment <<EOF
 #include "ldctor.h"
 #include "ldbuildid.h"
 #include "coff/internal.h"
-${pdb_support+#include \"pdb.h\"}
+EOF
+
+case ${target} in
+  x86_64-*-mingw* | x86_64-*-pe | x86_64-*-pep | x86_64-*-cygwin | \
+  i[3-7]86-*-mingw32* | i[3-7]86-*-cygwin* | i[3-7]86-*-winnt | i[3-7]86-*-pe)
+fragment <<EOF
+#include "pdb.h"
+EOF
+    ;;
+esac
+
+fragment <<EOF
 
 /* FIXME: See bfd/peXXigen.c for why we include an architecture specific
    header in generic PE code.  */
--- a/ld/emultempl/pep.em
+++ b/ld/emultempl/pep.em
@@ -17,13 +17,6 @@  case ${target} in
     ;;
 esac
 
-case ${target} in
-  x86_64-*-mingw* | x86_64-*-pe | x86_64-*-pep | x86_64-*-cygwin | \
-  i[3-7]86-*-mingw32* | i[3-7]86-*-cygwin* | i[3-7]86-*-winnt | i[3-7]86-*-pe)
-    pdb_support=" ";;
-  *)
-esac
-
 rm -f e${EMULATION_NAME}.c
 (echo;echo;echo;echo;echo)>e${EMULATION_NAME}.c # there, now line numbers match ;-)
 fragment <<EOF
@@ -82,7 +75,18 @@  fragment <<EOF
 #include "ldctor.h"
 #include "ldbuildid.h"
 #include "coff/internal.h"
-${pdb_support+#include \"pdb.h\"}
+EOF
+
+case ${target} in
+  x86_64-*-mingw* | x86_64-*-pe | x86_64-*-pep | x86_64-*-cygwin | \
+  i[3-7]86-*-mingw32* | i[3-7]86-*-cygwin* | i[3-7]86-*-winnt | i[3-7]86-*-pe)
+fragment <<EOF
+#include "pdb.h"
+EOF
+    ;;
+esac
+
+fragment <<EOF
 
 /* FIXME: See bfd/peXXigen.c for why we include an architecture specific
    header in generic PE code.  */