From patchwork Sat Oct 8 04:34:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tsukasa OI X-Patchwork-Id: 1834 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp608852wrs; Fri, 7 Oct 2022 21:38:17 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7dLtNaYLwKi27RjAwWh1bROrzcaU2HEgBJfhLYnoXd+q49c4glgiV1xkckhVt/tP9gV5LS X-Received: by 2002:a05:6402:3806:b0:450:bad8:8cd5 with SMTP id es6-20020a056402380600b00450bad88cd5mr7643378edb.305.1665203897304; Fri, 07 Oct 2022 21:38:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665203897; cv=none; d=google.com; s=arc-20160816; b=oemYy40xlBmI9KKA1Cegd54a+Z2p5iT5mXrFiYyOSd2/3uxEzGgvj/dqZSm/ar8AQy WcF9JUdp7tci8kAu1gQF43xSrK/aOejz7VNmxAPCYoR47T7uOl0UE4aOjwCy3nYnUNk3 VMXO0o9wkQVU5SmzK+AklTq0jw8yPxz79XvRl7KiPKn4sV2EB4rc7R/DMfqpYAgim/RI mA32ngCbQ6fAaq2/ywsZB3Kle4fCEz1Y9FLmCQlGDfbg3+gUwIko7LQkUGxMriOHLyOr IfSVlG6YH1IdSQKJhuae+5psTWD1Te6bxW6I93l6gO/kV00r4IfT6Zefrw6X2NF1lRmd jgbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=MUQGE3Wc9vh8DdGshamFB+89NN4CEoflsmMVyBjr0/E=; b=ImhqWXheRiKyDxxiKFIe7hc9ur7Q9wASoQDnkyaOO6WSPvHeKAv9V5wztoLACeS6xl nx+p/S3iuPeO1a0o3mNSiVz0OwvwiE5kWWblgoVh0ISejYf8whoyaXoMitdvVoKCkU/C 1A1axmzSYlHFwnDskK7gfe2LnO2nbizkHRrC63UmHPZNZ2opLSbLuA8iWpu7kA6mJbNO sTr4k9k8Su8YT+qicO3SY4HRCFIUqe3Itd3Cm09ed1X7zyoC/CJt0qM1tLyWclXZNSm2 QrGwgzzqH/lcskLOWhCj8vkxpPEOU7bniGVL3RUVsRMA1rT1e+BAb5kPO0Oz9rlAx4w0 iKtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=ErppLH1N; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id h8-20020a05640250c800b00457dac9ce7esi4814048edb.322.2022.10.07.21.38.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Oct 2022 21:38:17 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=ErppLH1N; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C3611398AC22 for ; Sat, 8 Oct 2022 04:37:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C3611398AC22 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1665203836; bh=MUQGE3Wc9vh8DdGshamFB+89NN4CEoflsmMVyBjr0/E=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ErppLH1NPKuyXI1vSVvXe0iyBTXSxSAyn9WCi4tVhphGv/Cyrcw/Tqli1C4CyVwNs /zSQZJqkJnimQc3nYY0NxpVcmZCX4IxdMlI6fsLqYtfOXQytxTgUNu9siPOIe5xifR ZHKlXcJrxpWKYKzqPY2JHXC4cLfbjVJnZOcHnKK4= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 8284C39730DB for ; Sat, 8 Oct 2022 04:35:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8284C39730DB Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id D5C1C300089; Sat, 8 Oct 2022 04:35:21 +0000 (UTC) To: Tsukasa OI , Nelson Chu , Kito Cheng , Palmer Dabbelt Subject: [PATCH 5/5] opcodes/riscv-dis.c: Remove last_map_state Date: Sat, 8 Oct 2022 04:34:27 +0000 Message-Id: In-Reply-To: References: Mime-Version: 1.0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tsukasa OI via Binutils From: Tsukasa OI Reply-To: Tsukasa OI Cc: binutils@sourceware.org Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746092841421303621?= X-GMAIL-MSGID: =?utf-8?q?1746092841421303621?= Before changing the core disassembler, we take care of minor code clarity issues and improve readability. This commit removes unused variable last_map_state (set by the print_insn_riscv function but not read anywhere else). opcodes/ChangeLog: * riscv-dis.c (last_map_state): Remove. (print_insn_riscv): Remove setting last_map_state. --- opcodes/riscv-dis.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c index 27e1978d428..daeb1b5fd15 100644 --- a/opcodes/riscv-dis.c +++ b/opcodes/riscv-dis.c @@ -64,7 +64,6 @@ struct riscv_private_data /* Used for mapping symbols. */ static int last_map_symbol = -1; static bfd_vma last_stop_offset = 0; -enum riscv_seg_mstate last_map_state; /* Register names as used by the disassembler. */ static const char * const *riscv_gpr_names; @@ -1041,8 +1040,6 @@ print_insn_riscv (bfd_vma memaddr, struct disassemble_info *info) set_default_riscv_dis_options (); mstate = riscv_search_mapping_symbol (memaddr, info); - /* Save the last mapping state. */ - last_map_state = mstate; /* Set the size to dump. */ if (mstate == MAP_DATA