From patchwork Fri Oct 28 06:53:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tsukasa OI X-Patchwork-Id: 12122 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp661588wru; Thu, 27 Oct 2022 23:53:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4+L8WjIVaffjkRVfckZCSO8ps5lii0fMkrT29kF8FBsvDc0i7aDpReTvE/L0ZmbVx751DB X-Received: by 2002:a05:6402:1454:b0:461:9b5c:2fbc with SMTP id d20-20020a056402145400b004619b5c2fbcmr26594672edx.276.1666940004376; Thu, 27 Oct 2022 23:53:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666940004; cv=none; d=google.com; s=arc-20160816; b=aZ4xPNO6KFDSrXHwsHjL6UIaRKttnOe5NsrKzGN/8EFuti5wdP5fb/KhDk6civtb41 c8rXWp6zD7492xYG8Svx0LPdGjoev2OhYfu/lf/AOwQ9sT4x44x2D7irwpCAw8xK08DT /q5XtCtDmtHVfDnjfq+HR4T1CC1/WtTdHL5Em8x0An4DcBXvbRRnswjRKhoop3qyCKK/ 5mtYDMSOqtw5QeAlCJoNAcJsLwt7O6uZriN/O0xeUJfILKg6EgABrauFiXkFwlU0vz9l yLb/HHwc3SPWdMfOn1RBdC4cU/HAwmxztxut5eS/hZ0bbbvpBqiiN0r/HjHkVoFweLTz PBig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:to :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=Auh0nWenFFAoGBm2khp0ftbBkMMln1UMhVz+gswOmZI=; b=h9JJHCNse/VEo8SfFVKxH3TDqrjWCrEDH3WKw3Id8RXrzJXG1DmKBv6L4ld8OlHX6p qIE/PFEKEHsDc/3qOsTtKGV5UofIUG0y4vk61aUOdGn1PRB1kC0gWQeJsEr9nv4A4dJu OdoscscowasjlM4oQQrqnYCoubxQESiZiwm5gBaw4hNSj9wAa395scS5QVZTeMHdH83M 25EDZWKdJ6Xt/Ym9X/3dqWZwAAeqoGOSJHS4D7Uip7i8bTHAxZCYQKvhk+TRrX+H3w0n zs76ZCk2BQyEnnKx3gJ/kvy1/goZytsNab1UtPpk1P8eA5Yk20cCOEqa4HhcvHgiVjb8 GvZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=tM0E17Tf; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id s19-20020a170906455300b0078d9cec6a5asi3263067ejq.191.2022.10.27.23.53.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 23:53:24 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=tM0E17Tf; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BB4163857001 for ; Fri, 28 Oct 2022 06:53:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB4163857001 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666940001; bh=Auh0nWenFFAoGBm2khp0ftbBkMMln1UMhVz+gswOmZI=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=tM0E17TfF55YboASj03KumN5pXFzrMtuelRqJ/exrQR6qvvvxHVMvowYZviPGWsuC 8oMIVJYsyc2zI7gw45/abYFmyfE+yuaMvC7d5IjY7nqiEBbIOhdAQ0kDtZd9JHe0l9 E/wDT1OSpM1TsnqhXYIMVhee9IdamQd4kt8wtTII= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id CF4DC385702D for ; Fri, 28 Oct 2022 06:53:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CF4DC385702D Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 6935B300089; Fri, 28 Oct 2022 06:53:08 +0000 (UTC) To: Tsukasa OI , Nelson Chu , Kito Cheng , Palmer Dabbelt Subject: [PATCH] RISC-V: Fix build failure for -Werror=maybe-uninitialized Date: Fri, 28 Oct 2022 06:53:02 +0000 Message-Id: Mime-Version: 1.0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tsukasa OI via Binutils From: Tsukasa OI Reply-To: Tsukasa OI Cc: binutils@sourceware.org Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747913282441823314?= X-GMAIL-MSGID: =?utf-8?q?1747913282441823314?= Commit 40f1a1a4564b ("RISC-V: Output mapping symbols with ISA string.") caused a build failure on GCC 12 as follows: make[3]: Entering directory '$(builddir)/gas' CC config/tc-riscv.o In file included from $(srcdir)/gas/config/tc-riscv.c:23: $(srcdir)/gas/as.h: In function ‘make_mapping_symbol’: $(srcdir)/gas/as.h:123:15: error: ‘buff’ may be used uninitialized [-Werror=maybe-uninitialized] 123 | #define xfree free | ^~~~ $(srcdir)/gas/config/tc-riscv.c:487:9: note: ‘buff’ was declared here 487 | char *buff; | ^~~~ cc1: all warnings being treated as errors make[3]: *** [Makefile:1425: config/tc-riscv.o] Error 1 This is caused by a false positive of "maybe uninitialized" variable detection (-Wmaybe-uninitialized). To avoid this error, this commit initializes the local variable buff to NULL first in all cases. gas/ChangeLog: * config/tc-riscv.c (make_mapping_symbol): Initialize variable buff with NULL to avoid build failure caused by a GCC's false positive of maybe uninitialized variable detection. --- gas/config/tc-riscv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 56d4450bdfc873ff3c2d1ebb194c7a076d4d13f6 diff --git a/gas/config/tc-riscv.c b/gas/config/tc-riscv.c index 91cff7de604..f4478eac11e 100644 --- a/gas/config/tc-riscv.c +++ b/gas/config/tc-riscv.c @@ -484,7 +484,7 @@ make_mapping_symbol (enum riscv_seg_mstate state, bool reset_seg_arch_str) { const char *name; - char *buff; + char *buff = NULL; switch (state) { case MAP_DATA: