diff mbox series

PR23877, bad value (n32r5900) for default CPU

Message ID Zd+zjY4wvu/VnDWq@squeak.grove.modra.org
State Accepted
Headers
Series PR23877, bad value (n32r5900) for default CPU |

Checks

Context Check Description
snail/binutils-gdb-check success Github commit url

Commit Message

Alan Modra Feb. 28, 2024, 10:28 p.m. UTC 
  Catching this at configure time would be nicer, but we'd need to exactly
match mips_parse_cpu in configure.ac and keep it all in sync.

	PR 23877
	* config/tc-mips.c (mips_after_parse_args): Don't assert that
	mips_parse_cpu returns non-NULL, call as_fatal with an informative
	message instead.
diff mbox series

Patch

diff --git a/gas/config/tc-mips.c b/gas/config/tc-mips.c
index 43c12de2c8a..8f54cb8937a 100644
--- a/gas/config/tc-mips.c
+++ b/gas/config/tc-mips.c
@@ -15287,7 +15287,9 @@  mips_after_parse_args (void)
   if (arch_info == 0)
     {
       arch_info = mips_parse_cpu ("default CPU", MIPS_CPU_STRING_DEFAULT);
-      gas_assert (arch_info);
+      if (!arch_info)
+	as_fatal  (_("gas doesn't understand your configure target %s"),
+		   TARGET_ALIAS);
     }
 
   if (ABI_NEEDS_64BIT_REGS (mips_abi) && !ISA_HAS_64BIT_REGS (arch_info->isa))