From patchwork Wed Feb 7 12:14:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 197880 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp2182412dyb; Wed, 7 Feb 2024 04:14:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IFu0eGgbh/qkDTrKqcFOd73GfLThIGVE3tuqzEOJPVn4pmDeaXLIKLT5GjexKAa0bwaSYq0 X-Received: by 2002:ae9:f30d:0:b0:783:b98a:80d with SMTP id p13-20020ae9f30d000000b00783b98a080dmr5086780qkg.63.1707308066590; Wed, 07 Feb 2024 04:14:26 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707308066; cv=pass; d=google.com; s=arc-20160816; b=AgOLKNeE/IpzTRT519AShJ3KzOIiLSgjrXo72TAwwNIdqBEp2gcW1RGvaO9Sc9D97i 7/32bugM/77ERhxi3jGNa17VQzyjjMATiqjOGivdudCe/0GlqLrGzqkCd6n1BrBckqLq oCgfnASK2WoGzBob5PLyXZ4dD0G8zTOCyXSn9DpwljaQfFWLwqqczoafJvWIZFuCRDje T1n5lxhlE7BDZVuGJFW/7AXZFEtd84bMU6QEC+bIdo4OO8sXC3mmTxlN7+2HgWMRLya7 Mtj3nv3Xzr91wEdwvhzTsRsJIPUJwdbLl2YYg7wN4zhlbFr6TU+Ox8DKIl54MDimDcIE SAmQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-disposition :mime-version:message-id:subject:to:from:date:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=4g/peHDH98XmXGYcHMY5+sNvwBoDSBIik9zqdakpC20=; fh=1MRTsNTn2/WI/YlMlf+H+FpX53R5MDkVoHTKG8Wxg8w=; b=R0dqoBm3k8r7IZSH8CW4wRlLCoknj5s0xJT3nT8Ip59uWtJRfiySas9IJexjgGvmSH QEzLsOELKOJbifClHOMS+lVvdHeBX+cfJ/x37WHAXgrVQjj3u6CQhYDrEs2M5yBrNNg7 3vJME/0zncN0GtxhDbZ2G7J031zbJpuA1tDnaYY5VAmE57FnpH9a194hc56lUAmOFiqu RxCKCQHoMuqgO0dWgZSO/fRf1tGg3eEPO9k3ZHqJHlmB9XNRp+hdxC+gR9LKpxEN+OH6 6cPeqoHzQUm+XLFi9hbRHrvsoGJEXHK6F8BRg+5T312DUG/Wqa6a+AwzEtUtkAdH7gHF r/6g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=D73+naBo; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com X-Forwarded-Encrypted: i=2; AJvYcCUmKepyotaZXf+rEN7wxLktvQF48sIAfQ5RlgpmuuK0AaEmgmhFqk/IwLD8ZFhiDR+lpm3n/ORVziTY08aTRolHRrDgRw== Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id i17-20020ae9ee11000000b007839e747700si924576qkg.192.2024.02.07.04.14.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:14:26 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=D73+naBo; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 46A35385841C for ; Wed, 7 Feb 2024 12:14:26 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id AB9103858407 for ; Wed, 7 Feb 2024 12:14:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AB9103858407 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AB9103858407 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707308057; cv=none; b=evIkxIYS5kZFGsXdtx4vPREKHYW7GxRFPoeaRWpf9sJXWCovUbxYKmTLMfBTNFaBFSnWMfp+zGuBnP4OoMx3DNipFOmRYVaCJVF1JWZP6sv2uArQkTwWVHnJpBZMQd0w93t61zzq2EGL7GjKxAdT8w2dUlFsRuV5R1rfQkb6pho= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707308057; c=relaxed/simple; bh=KgAF+3wZrI1gsm6t/EfnTqEO4SCjOodqlNggHOSoKlQ=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=EnSYPJH+pA+wXclS3/Q7BHVFM50IPCbXqJ9WkMHgjGaLnCn7ASkLM/GvphdfCfUqgTfrQSlhBqSbtMh4570/3mkmcZ6DvNYXrEhbp5ZOJX45RG92TFPk65ewTUvG72T0n7dwlTf7NKiIK2DRpAcJIltqQ9AAL4gZEA5PtsR/JMk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1d76671e5a4so4950505ad.0 for ; Wed, 07 Feb 2024 04:14:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707308053; x=1707912853; darn=sourceware.org; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=4g/peHDH98XmXGYcHMY5+sNvwBoDSBIik9zqdakpC20=; b=D73+naBowsAHyDm2S6b1F1pOBw4mNNrC+3FxGDQEfsuMAsTs3fsYzvjS7eLkghMhX2 Iy9+8QxdkxSyA42wTo6rITd+/zjLXC2Pa0u+Ex+Z18ZlZIMkZwhnzDNLAQ662u5iRS2t 6jpX01GMVMYYsxJvT+6/37ynVOfJUtbQIcg0s4d7Vskc+RjcrzPLBbgu538M0THzJqQW Oq1MesZa9al8w+1HuM7QRJkoC4duCAXC1SEAbZGmSqsCoJwdDKKAbJU98Wh9HKgdFGMw dHdva/+Bza839QSkZHHfHffEQ4fbGsmUnnL02NkS++0mO7MHRB7pq/nuX8LRYV603zpa LuTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707308053; x=1707912853; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4g/peHDH98XmXGYcHMY5+sNvwBoDSBIik9zqdakpC20=; b=X60DO9fiJ/o31VvqFHDI3mN15XBLcEjNM1yYmQUm3GBvnmh7nZ+kAZpTNYHXTUp5hB mVtEDFVYRG8HcA602tnWDJ4k9ep2RvUTzDWjE7Emf4RX0Ziz1sljJA5JcLk6pnKDwfMu kc3yRHjSjMIMNnqXbyDZXhg9EH8KSdtCI+kk+p6Y1ygmqphoAgxIQm5lJgOaVRQXYsR4 6FTRYHdATn9tU77WULnmDdL3isaqH66ELxVwv1QDhmWGydedrsryGdRu/G7GsypbhCUf F9xPs/jtubrwJnda86dILMSQE/j9QDIW1N3tHRKEjlJAsqYeLWwvUyPSSPlYk0/Hy/ho aiMg== X-Gm-Message-State: AOJu0YyvjKB//wRGlcuIB+Pa5FRoh3LaWM11cw3777gpW42ewKemKreb TUflFdTxuT8o5EMDbifM3F/0b8b+3LCbf58VFIZzGs2HZ0JJCLWf3Hmfq2Aa X-Received: by 2002:a17:903:595:b0:1d9:f015:b226 with SMTP id jv21-20020a170903059500b001d9f015b226mr1172190plb.13.1707308052836; Wed, 07 Feb 2024 04:14:12 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:cc3f:acc8:6535:82de]) by smtp.gmail.com with ESMTPSA id k11-20020a170902f28b00b001d94c54b3bcsm1283848plc.264.2024.02.07.04.14.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 04:14:12 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id A178D11416D7; Wed, 7 Feb 2024 22:44:09 +1030 (ACDT) Date: Wed, 7 Feb 2024 22:44:09 +1030 From: Alan Modra To: binutils@sourceware.org Subject: memory leak in objdump disassemble_section Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3033.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790242263340760876 X-GMAIL-MSGID: 1790242263340760876 * objdump.c (disassemble_section): Free rel_ppstart on error path. diff --git a/binutils/objdump.c b/binutils/objdump.c index 49e944b1dfd..7beb221cb2f 100644 --- a/binutils/objdump.c +++ b/binutils/objdump.c @@ -3795,6 +3795,7 @@ disassemble_section (bfd *abfd, asection *section, void *inf) { non_fatal (_("Reading section %s failed because: %s"), section->name, bfd_errmsg (bfd_get_error ())); + free (rel_ppstart); return; } @@ -4075,9 +4076,7 @@ disassemble_section (bfd *abfd, asection *section, void *inf) } free (data); - - if (rel_ppstart != NULL) - free (rel_ppstart); + free (rel_ppstart); } /* Disassemble the contents of an object file. */