From patchwork Fri Aug 25 03:23:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 136893 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a7d1:0:b0:3f2:4152:657d with SMTP id p17csp1542086vqm; Thu, 24 Aug 2023 20:23:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF98un24vi0ehjK5PxITtEiOxYI3e+c5SlvbulOVcAh7N8gTznpylEXr4pTIocAq2Iki37Z X-Received: by 2002:a05:6402:b09:b0:523:d363:1627 with SMTP id bm9-20020a0564020b0900b00523d3631627mr13430087edb.33.1692933824672; Thu, 24 Aug 2023 20:23:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692933824; cv=none; d=google.com; s=arc-20160816; b=NAqpZGFGhcTAjW/cMm5qby5B2kvbJzWzhpoSIIlWABfX8eiWjYSUe4JIeTHFhi6LTG ShWFI6UY+txvfZeRpkaImSvUXQpsLkW9QI2wm7lvtj47Fd+D3j4pZ5xYIuZ88alDz1Ft yTTPIZGXMY6tlNO2NUNrE5geynTSdNVaiyZk4EytEAp8BJPUzSXG4fZf/C8Uc13e8PzF ObSfrX1Z+2ay3PZIG0gIaj41cKyTOAHn/97tgBiOETJAlpiya8N7OC8LxHwrY1z99k5t B6Z1swHuRcHdQRgYI90l9E2dlMtNhZlT5ntSZv6LY3nqeIYXL38PiDQcdzqHbFkgx9O9 XHgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:cc:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=GnsxMhpBKjItMutG9o3C+G0SkHCrsfIEWZe7387W+qs=; fh=CSS8mAzf6gEAqTTg1GzM+D7z6e60sK64CEWiO61Vj0E=; b=pp54NjhhGILPRLxnlW4DhR87hMvTr6xwGGdIbadp+2aNF3t90s8CTz0f0yis2tSL3H wFoXEOBWGy5FPnMPlHpgitPHOof30KrbmibinPy6mZh6CHxOmIWfrxXE4YRh8Kt64cZI 2ljGIT6ctfeb15vVbxtgIY601n/vQh8i3+vXbc+ouaUDcDukNoYtNJshUSytzGgrvsFR MASmyPFPU2fQQ1xNi3lWdkbI37qLTfROs6mFLsMvJKmXLHO76WKiQDFD6PMyEhnosP9g RBLYgMSFkKPBooBmDEPOmPfM6Vz5MRXJCD5Rwj6NcTuJTnT7By73QjLfqpHwjmufYRLQ diqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=bnadnfUp; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id x18-20020aa7d6d2000000b005232618b016si522405edr.208.2023.08.24.20.23.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Aug 2023 20:23:44 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=bnadnfUp; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5C3A43858C2D for ; Fri, 25 Aug 2023 03:23:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5C3A43858C2D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1692933823; bh=GnsxMhpBKjItMutG9o3C+G0SkHCrsfIEWZe7387W+qs=; h=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=bnadnfUpuceSCsMOQeM/EfMFRvD+xue9CquBcO3VQXVFmXZMIo21r1BOElTvR+BZH pDCb+SgmT2QPKosZfxakeIhTJYC+HYVzJdNF56cobQJNOw5SpYvwbMY6dzBaaPT4lx l8u9XGun1TEphg7IhOUqPktXnYJN5PBc3cLtiEFs= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by sourceware.org (Postfix) with ESMTPS id 10E653858C53 for ; Fri, 25 Aug 2023 03:23:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 10E653858C53 Received: by mail-oi1-x22a.google.com with SMTP id 5614622812f47-3a7ca8720a0so346431b6e.2 for ; Thu, 24 Aug 2023 20:23:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692933813; x=1693538613; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GnsxMhpBKjItMutG9o3C+G0SkHCrsfIEWZe7387W+qs=; b=ABRytCYf+P/UYJ+u9oYwG4MdHJBrJ2nndVkSDOCEsKipoP31StUoVkM/NNH5WHw6o0 tKv+QBUMPQtQSi9kLPVusl+29uodi8alY4lT99HPPSlUJT4nbEE25LMFD3JTytdqZtoH eRa0CnnruMmNYf2HH9P6kMk1Yl1mviQ8TOg9NP5ZAMXN1XGwSt1Tlm4ON4tkXMOSt1w6 yJIeREAHCeHw61IW21nl2lJR5K2fhj4yIT1xZT2nBRVbhguaLSjHKId05AWZAgAGFgz7 NSJVXOLDqOKTatsD0NDB8psItdUsDj3QUTLE90ag5jFOMXIiqtAmnTNuegzWYC+R4PPh XM5g== X-Gm-Message-State: AOJu0YypvgEEaJU1CzqqsuWFPeVIH+2oipNnp52PgspgYdyZqdsD5Sho qyuSFJyorhsB9B3i39p8y41XZVBLxoyX/A== X-Received: by 2002:a05:6808:df4:b0:3a7:725f:476b with SMTP id g52-20020a0568080df400b003a7725f476bmr1533720oic.41.1692933813271; Thu, 24 Aug 2023 20:23:33 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:bbc3:80aa:5336:69d9]) by smtp.gmail.com with ESMTPSA id j7-20020a62e907000000b00682a27905b9sm488335pfh.13.2023.08.24.20.23.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Aug 2023 20:23:32 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id D711611423DC; Fri, 25 Aug 2023 12:53:29 +0930 (ACST) Date: Fri, 25 Aug 2023 12:53:29 +0930 To: binutils@sourceware.org Cc: Hans-Peter Nilsson Subject: Should we require GNU make in binutils? Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3033.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1775169778449426136 X-GMAIL-MSGID: 1775169778449426136 I see the toplevel Makefile.in makes use of $(filter-out ..) and other GNU Make extensions, and requires GNU Make 3.80 or later when building gcc. gdb also uses GNU make extensions. It seems silly to me that binutils is still trying to avoid GNU make extensions. We could start with the following (originally from Hans-Peter) which avoids a whole lot of entering/leaving messages when building with --enable-targets=all. What do people think? diff --git a/ld/Makefile.am b/ld/Makefile.am index be456275748..fcb93060a14 100644 --- a/ld/Makefile.am +++ b/ld/Makefile.am @@ -633,19 +633,10 @@ GEN_DEPENDS = $(srcdir)/genscripts.sh stringify.sed @TDIRS@ -# We can't use pattern rules as we don't want to depend on GNU -# make, or else these rules could have been expressed in one -# two-liner: 'e%.c:' and ' ${GENSCRIPTS} $* "$(tdir_$*)"'. -# (The recursive variable expansion is portable.) - -run-genscripts: - $(AM_V_at)${GENSCRIPTS} $(script_target) "$($(script_tdirname))" - -.PHONY: run-genscripts +e%.c: + $(AM_V_GEN)${GENSCRIPTS} $* "$(tdir_$*)" $(ALL_EMULATION_SOURCES) $(ALL_64_EMULATION_SOURCES): $(GEN_DEPENDS) - $(AM_V_GEN)base=`echo $@ | sed -e 's,e\(.*\).c,\1,'`; \ - $(MAKE) run-genscripts "script_target=$$base" "script_tdirname=tdir_$$base" # It's a pity we can't generate these include "./deps/e*.Pc" lines # from ALL_EMULATION_SOURCES and ALL_64_EMULATION_SOURCES, but that isn't