From patchwork Wed Aug 23 01:43:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 136619 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a7d1:0:b0:3f2:4152:657d with SMTP id p17csp181074vqm; Tue, 22 Aug 2023 18:43:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGXJiaxqkqveypcgk2Xy8JVJd7CA9u+WoxktkbxS3hDcdA32AjJBZOEzh9ZkB0+h14drx8L X-Received: by 2002:a17:907:2671:b0:99c:e38d:e47d with SMTP id ci17-20020a170907267100b0099ce38de47dmr8908173ejc.27.1692755003605; Tue, 22 Aug 2023 18:43:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692755003; cv=none; d=google.com; s=arc-20160816; b=GR+iPrAAeELMISdNHd1vY7wrCPJZFjXC9Wipjwq+PK9DQ78H2Yyz75yH/D+bNrIfPq IiydXCUoXXrLh5S77ccwWhYa684KcFKiLM/yI8JweIPqeV2ij7/sY4kTQYU/ruWyss4S puubDzrLNo/y54sTEXZlJPcqhc5BWxoIlskmEnm+N2n+ZbwFWDmB88FkyuJzXIHVetOF qofNN85uWETrWXFiICpuEojt207yzeEW4UAJmkKtHrCmlexCt2YJ1teVtHK7YfHyGckH GYY+sxIGxcdvKo8ACyNfswo6bEo45GnFzWCPumLyT+liwiAK4EdgJkx1OFuFw6pStqLm JVtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:cc:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=T4bvdDLjcWsdfC+9CzgtRg3q2omOX+yVWB5qXxB5A4k=; fh=bK1q79qYE95Jh/MZ9798J5v69IDcsS4WUqA6R/2YPko=; b=V5fixUZ9DKiMDdUMGFfEz/F840+Su4D0HfwkMx6mOBDBaPL5egqzeLP9uGsLfjvhcb MKtgmcrutVxPqqnRR6xZgDs/rS7G5+y05U+r6SaPqpdrWTNMR5iXreVMlrki3NK+rpzI 3uStUCu4rk55PDL1q2DGArY/TdaXXUZh1jCX32w1MxKfldLCM2MIbXKTsc93Lo0vyPbT EzC6RktcezMWr+hirfvZfbWBcUY83B76weci/6nR9V5/1abEl+KXBU88crnpEqepGerx SEdGwjW0EVcQu+QlYOz/tSK0s6IJYbNG5F02WVfIXsHIuXiPlNq4jrYMbVu5lSqm/NFr aRDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=DUBhZ2Mq; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id r10-20020a170906a20a00b009925144d755si8278479ejy.461.2023.08.22.18.43.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Aug 2023 18:43:23 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=DUBhZ2Mq; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 422BB385770F for ; Wed, 23 Aug 2023 01:43:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 422BB385770F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1692755002; bh=T4bvdDLjcWsdfC+9CzgtRg3q2omOX+yVWB5qXxB5A4k=; h=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=DUBhZ2MqoeeKkZdqILU1d63q73cmc8Vw9D4sY94DbJt4FO7XegIqAhnZCgb2eFDKM B3Aem1Drxf/wbZUELHXnIp5J0yUCItN3Ar978PhJvo47vqxnm/XHk0pMPsInpw9gLk pqsZnLW+zle2nWfOdwseKAQ5sU6loqzvEPG9Ffrs= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id 462593857C41 for ; Wed, 23 Aug 2023 01:43:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 462593857C41 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1bdca7cc28dso40834515ad.1 for ; Tue, 22 Aug 2023 18:43:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692754992; x=1693359792; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T4bvdDLjcWsdfC+9CzgtRg3q2omOX+yVWB5qXxB5A4k=; b=K7Is/iUi8imsiN80Sq30omScIa1H5MExpW8/iYPXoCNYwrqgtTZtqGaIPMElxufmxI Ea1xh7uA4SkmxCjmnidG8pgVJkzk3GM9Mm73ohsrqtbes7Yp6yCffo8h2Muq2324BMKq D4gMIxMYj/QdM4kQl8lSIXC9r0BuVR8Ap/2+hS1D617WEdEiJvdd43E+eB3tn10VnHJ7 MeN3PjCLxv96Jct/efGq1ihL3cwKhnBsSgQAtS2H7Pyz/wf2neWShqIHigZl8LAAdw0F QzXsnxZ0NfH6SYAi/PM+2t+YV/Hun7XjLnxIpUEV8Gid2EM/ogE4kbWLcMDs91HVJod4 qyow== X-Gm-Message-State: AOJu0Yz0UGOO8OjOMW8TPCKtOjmVtjEoDFRS1/QBWpBvf5CRBEdI8ixw o33qqHVloNSYiP051qVLkKAeFW2o+fY= X-Received: by 2002:a17:903:447:b0:1b8:971c:b7b7 with SMTP id iw7-20020a170903044700b001b8971cb7b7mr10728676plb.56.1692754992175; Tue, 22 Aug 2023 18:43:12 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id e12-20020a170902d38c00b001bdf046ed71sm9644282pld.120.2023.08.22.18.43.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Aug 2023 18:43:11 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id EE9081142918; Wed, 23 Aug 2023 11:13:08 +0930 (ACST) Date: Wed, 23 Aug 2023 11:13:08 +0930 To: binutils@sourceware.org Cc: Paul Iannetta Subject: kvx: asan: out-of-bounds read Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3034.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1774982270709216434 X-GMAIL-MSGID: 1774982270709216434 kvx-parse.c:parse_with_restarts does if (!tok.insn[tok.begin]) tok.class_id = -3; then a little later printf_debug (1, "\nEntering rule: %d (Trying to match: (%s)[%d])\n", jump_target, TOKEN_NAME (CLASS_ID (tok)), CLASS_ID (tok)); This results in a buffer overrun in TOKEN_NAME. Fix that. * config/tc-kvx.h (TOKEN_NAME): Check for tok <= 0, not just -1. diff --git a/gas/config/tc-kvx.h b/gas/config/tc-kvx.h index 11787bf0532..85344cbe179 100644 --- a/gas/config/tc-kvx.h +++ b/gas/config/tc-kvx.h @@ -37,7 +37,8 @@ #define KVX_RA_REGNO (67) #define KVX_SP_REGNO (12) -#define TOKEN_NAME(tok) ((tok) == -1 ? "unknown token" : env.tokens_names[(tok) - 1]) +#define TOKEN_NAME(tok) \ + ((tok) <= 0 ? "unknown token" : env.tokens_names[(tok) - 1]) struct token_s { char *insn;