From patchwork Wed Aug 30 01:55:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 137135 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a7d1:0:b0:3f2:4152:657d with SMTP id p17csp4273443vqm; Tue, 29 Aug 2023 18:59:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHsVMBpx4d06IwVjgz2nAg64Z+66hm3Zk47+Xxjddi8olI3JPE2rF/2rkJeTzXrxl54ZvTB X-Received: by 2002:a17:906:de:b0:9a2:ecd:d963 with SMTP id 30-20020a17090600de00b009a20ecdd963mr550392eji.44.1693360742078; Tue, 29 Aug 2023 18:59:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693360742; cv=none; d=google.com; s=arc-20160816; b=iVbLj29tAkDayhyE6NG4ZymHMczeZ32bk8HyG0Cvu3Kx0tOCUl+jjooh28vEGKOdjX ZhBKeMhUeAQ46q070Z5s/KS0zP79q7EFXYEMUf/OR8EHcVVnd/LOwpVMctdObMLL4tit xYxS1aP4lK7WySKM+OcNFTJ18NlgejdVm9m2iRDtZQk3V4pJSvpLYLHWqlM00WOA0lMa ghgHKKCizz478IgOJBiBEUYxYIfznIq/7Rgulwx9Bd1bn1BeZEb55e1OhYPSJ4OrEZ9r T63Liu0iO2cxzkIuQnOAkoeuN98pkDvj8YWdH6LUINzToE//2PZF+8xprf7afqISX7C2 uODg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=jD/qaQxKac413ibfG+ldjhtiLV6bjGHFZHUuyxXa+4o=; fh=NLxAvL/bDfPg4AGOtxqvQlND8vazkZrNzKLY8+LAbBY=; b=RjYMnjebp38znodz3xlRDybzZdkJrZe+5YMHo1nvQI35O9/nTirZTPoUEjrrRsugi+ Fty1JU8m7uomjf9xJFeiaEJzZS7eNM9xAK0z7jBDjL0fVKBYASDMn7fWO0SyHN+bfIDV lX2lcA/ilUx/LhWqAKLB/6nPfxqiakhjkjYZHxxtoI6JYm9zB9hiaVGAklTPmdNl8P2s WxL48SLql2WpP2v8YVhZlWfS6EdnGHGFJcfjdqMYymFbROMBBdnX1lIyOwqQU4zAVoDJ 6yrFrHDnCd9PpBkuTwNnMJ5jKMF5ohJCb+IDNSlAqUMlcIausiXdt1idF/oiYcGHrw+2 de9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=w95Uk5yM; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id x12-20020a170906148c00b00991df86ac08si6815426ejc.256.2023.08.29.18.59.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Aug 2023 18:59:02 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=w95Uk5yM; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 89D693856DD5 for ; Wed, 30 Aug 2023 01:57:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 89D693856DD5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1693360652; bh=jD/qaQxKac413ibfG+ldjhtiLV6bjGHFZHUuyxXa+4o=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=w95Uk5yMjaL5H2bfClIUnJLrzwzSuc0aQg4XfSQ2H00FYV4O7j2VB4SX2junoCzEf gNx02hRH/3g1ntD3DjzXH9Lj6QjADPfNIKMAT0hkh8WG2CyDTF/IzQOsnfEPJjkz3H iuYgcXnyD3YnVjYu63UxRjThe1cPc4o5t8cp0eDQ= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by sourceware.org (Postfix) with ESMTPS id 31ABB385841D for ; Wed, 30 Aug 2023 01:55:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 31ABB385841D Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1bdca7cc28dso40585245ad.1 for ; Tue, 29 Aug 2023 18:55:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693360505; x=1693965305; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jD/qaQxKac413ibfG+ldjhtiLV6bjGHFZHUuyxXa+4o=; b=B75/ChPDeH7vcrZGGgL/jUbX3gAae4RMogkRGGcEbLNhRIDYGTiHu8q4IEHLqedUuS RUcSlZ+pRsT+I1aDQLNUEr8spSwdZq16KjHjqBgQP1O5SXv2c5F54KX0rfiy/tkrXyaI 8Kh1MOV+rWLGD3DzkendO0RArL76cmM6Ak6Abyl56D4pEDuD9XeS2H7dFJzc5xdErcw/ SEMwbtTho0LwsSBYC1O8VIb4PARpA4tt/DErEPb85BhKi6GV/y9LdgUJJ0vQW/jYmMP9 tJhefa71U6gcztSZgESteWqObqUvsAZxicozp03r55YV8ii7TOAXN9keC79yMEgtr5yJ raVg== X-Gm-Message-State: AOJu0YwqegQgQPzaKzxZGYqHzhy0kd5xbgYY+du8EXDJbSnnHcKILqp1 Ee2hbAv3K/mdNKX5Y4KMJ3AUDRAdnGC1Uw== X-Received: by 2002:a17:903:32c3:b0:1c2:1443:d62 with SMTP id i3-20020a17090332c300b001c214430d62mr109988plr.20.1693360504699; Tue, 29 Aug 2023 18:55:04 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:7fb2:1af4:8cc2:f9eb]) by smtp.gmail.com with ESMTPSA id f11-20020a170902ce8b00b001b53953f306sm10007150plg.178.2023.08.29.18.55.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Aug 2023 18:55:04 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id E046E11425B6; Wed, 30 Aug 2023 11:25:01 +0930 (ACST) Date: Wed, 30 Aug 2023 11:25:01 +0930 To: binutils@sourceware.org Subject: objdump: Free sorted_syms on error path Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3033.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1775617433453253303 X-GMAIL-MSGID: 1775617433453253303 * objdump.c (disassemble_data): Free sorted_syms before returning. diff --git a/binutils/objdump.c b/binutils/objdump.c index fb0db5d4fe8..60813426566 100644 --- a/binutils/objdump.c +++ b/binutils/objdump.c @@ -4151,6 +4151,7 @@ disassemble_data (bfd *abfd) non_fatal (_("can't disassemble for architecture %s\n"), bfd_printable_arch_mach (bfd_get_arch (abfd), 0)); exit_status = 1; + free (sorted_syms); return; }