From patchwork Thu Aug 3 11:45:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 130514 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp1089530vqx; Thu, 3 Aug 2023 04:48:47 -0700 (PDT) X-Google-Smtp-Source: APBJJlGVqZxjCLz1bapNuXVrRr3VTQ4rpevTSr14FD2iNDF5YEFzsnnSlUkZ9sXrmBg+oKOffITK X-Received: by 2002:a17:906:10ca:b0:992:42d4:a7dc with SMTP id v10-20020a17090610ca00b0099242d4a7dcmr7846545ejv.21.1691063327673; Thu, 03 Aug 2023 04:48:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691063327; cv=none; d=google.com; s=arc-20160816; b=bwLSqavJQIcopKAraF4+XeYEjpWg79RvDOhvekgL9VeD+e2mv9+bZs9vlox3z21g5l R8OdxIQ+kyV/weWxob/kS66XVLK1kcsVIF5Oa+PN08yi0r5ckn66dI44+LIu/mnLI20+ CnFnF5S9mPaPdneGO1Aw6zQ/Vg+nXn2vyNnPYuN+iXDj6CyoagS0atdI66mKr/jBlIqN SzRPetByUNTfanJXtibmAgESZyRlRnLc9x17HkTjrMvY5Ga1Vp4EyIvyf9g7jcSsDiqe yarZ2mGlUNH6wE5bLBAgQGrrTZqUsEM60wADvdaFnDnb4kEoeiRehEEthWjG1749HQGb Hqyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=1LLOcdmW2BRNXFU566ld3KxrbPDUUcIkcw/uXsFqF50=; fh=HNIqzTA9Dp00ovCAyCdXfuEvWDT00OlFxFRPLybXRis=; b=08FeRcUZoRsaWP/69ST8LFceD4E3Gbh6iiaOXzwZjznw6raHU/3mN0nDZlwzhTbDS4 zmUlD8F8BCEjlgDpcq9VfMw4yIv0o3T6TcWFxHLYfJGvIX/5ULe3ve3U83RwdQLG1A0K 0SbrFDa9fg1cVd5tuGlfa6uWDE8Fp4FCYliEfxosyKsp5vM+y3/3i/ITqNQgDCnyx9Ix onXRqh70RDUBxi+6c+diYNRofB3+Uc+6DhwgogKWcAFeMVkwcdZO7aScnYhJXxbJcizs 16ZpDNuJzK+emLhBe4Xb+jOaGoxlUm4ebRAs7q4fGtdPCa1U7HNme43Xe+NSt/mhAGmL Kx7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=KSWTPx1R; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id b6-20020a170906d10600b0098e31cd141asi8049868ejz.747.2023.08.03.04.48.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 04:48:47 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=KSWTPx1R; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 06510385DC0A for ; Thu, 3 Aug 2023 11:47:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 06510385DC0A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1691063228; bh=1LLOcdmW2BRNXFU566ld3KxrbPDUUcIkcw/uXsFqF50=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=KSWTPx1RKfosT8rY9EIRYI5U5wVBtH62k7iMzGa9DSo9ahcwomAN27V1wl+uU7Ejs qJq0kEIGpaeAN1VJAa+sJKXBM+YIxiT/NisHafty7NbErb0M+Pub6ywI5Ow7iUxBry ethOb+Vd+sZoMNy4T4Ru2TJmX7CKa/lM7DVEsGqc= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id 714313857711 for ; Thu, 3 Aug 2023 11:45:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 714313857711 Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-686f94328a4so610843b3a.0 for ; Thu, 03 Aug 2023 04:45:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691063115; x=1691667915; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1LLOcdmW2BRNXFU566ld3KxrbPDUUcIkcw/uXsFqF50=; b=ehTBYAd8GYZTRP7BdgZXIO8NJpGbxebJvPSyDiPRQk1asJhg5oF7JRdkb+zKiCu1be r5oAwg8ekNlX0lL7WyoQmLpu9cI17b1va7CgQTsh6bic+lQRww5/xyhDgmwq/FqEG8sd D1Yy47kWsWB/IolFy9NrI4teleh19aj1KFlJyItDZS6kULPD6Xj6bIMAksz96xf2Dxlk GBaZcIud+ZUJu86a0cMYiV29yEkfRNIxKO9us4XtvO2BaAMnUsYVyFdwwXkXBE3CV6Il a2F1SQgZ88TDHNJ1m9AW0jy41WOY/oQo9TjNeh+Egf2xipgwRt3chPQKQSxH9zT1xqp5 GjxA== X-Gm-Message-State: ABy/qLYa+Q9A5B2yBL9MFgFxJ8qTQC98FV03mkQ0Js1OpbPJS+jxcjJB O9mMaoZNZEZ03hZp89468Jwj8Ru2HKs= X-Received: by 2002:a05:6a00:390e:b0:684:bb4a:b86e with SMTP id fh14-20020a056a00390e00b00684bb4ab86emr21770166pfb.1.1691063114554; Thu, 03 Aug 2023 04:45:14 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:a029:aaba:dbee:92cb]) by smtp.gmail.com with ESMTPSA id v24-20020aa78518000000b00679b7d2bd57sm12627387pfn.192.2023.08.03.04.45.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 04:45:13 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 9584611427AD; Thu, 3 Aug 2023 21:15:11 +0930 (ACST) Date: Thu, 3 Aug 2023 21:15:11 +0930 To: binutils@sourceware.org Subject: gprof: sprintf sanitizer null destination pointer Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3033.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773208419604601692 X-GMAIL-MSGID: 1773208419604601692 * basic_blocks.c (annotate_with_count): Use output of sprintf rather than strlen. diff --git a/gprof/basic_blocks.c b/gprof/basic_blocks.c index 6073f556f47..7fbba8c03fa 100644 --- a/gprof/basic_blocks.c +++ b/gprof/basic_blocks.c @@ -360,8 +360,7 @@ annotate_with_count (char *buf, unsigned int width, int line_num, void *arg) execution count (if bb_annotate_all_lines is set). */ if (b->is_func) { - sprintf (p, "%lu", b->ncalls); - p += strlen (p); + p += sprintf (p, "%lu", b->ncalls); last_count = b->ncalls; last_print = last_count; ncalls = b->ncalls; @@ -370,8 +369,7 @@ annotate_with_count (char *buf, unsigned int width, int line_num, void *arg) else if (bb_annotate_all_lines && b->bb_addr[0] && b->bb_addr[0] > b->addr) { - sprintf (p, "%lu", last_count); - p += strlen (p); + p += sprintf (p, "%lu", last_count); last_print = last_count; ncalls = last_count; ncalls_set = 1; @@ -396,8 +394,7 @@ annotate_with_count (char *buf, unsigned int width, int line_num, void *arg) if (p > tmpbuf) *p++ = ','; - sprintf (p, "%lu", last_count); - p += strlen (p); + p += sprintf (p, "%lu", last_count); last_print = last_count; } @@ -410,8 +407,7 @@ annotate_with_count (char *buf, unsigned int width, int line_num, void *arg) if (bb_annotate_all_lines && p == tmpbuf) { - sprintf (p, "%lu", last_count); - p += strlen (p); + p += sprintf (p, "%lu", last_count); ncalls = last_count; ncalls_set = 1; }