From patchwork Thu Aug 3 11:44:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 130509 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp1088642vqx; Thu, 3 Aug 2023 04:46:47 -0700 (PDT) X-Google-Smtp-Source: APBJJlG4ThU565S487SfDFk+Mk8lf6sr3Zm5EKjQlfWdNGdvLhP5Z2t3Kbga9RRu32fhoX1siDx2 X-Received: by 2002:a05:6402:517a:b0:522:582c:f427 with SMTP id d26-20020a056402517a00b00522582cf427mr11355341ede.14.1691063206922; Thu, 03 Aug 2023 04:46:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691063206; cv=none; d=google.com; s=arc-20160816; b=dF4BVlRIVciKqj48LDSaVGF+H+YgOa2lPWeJX396BVd2H4Bkib0w4IFMC3/SD8Fo/n ONDI1phX/9SALGwHbaNJ+G5JnP3OZwzqIcfXqj+y3f6w4jkjgMAoLTcVx32gDA4GGDTr c/R0a6esDx0ZKXKPUUJWxNIWhie+2DTWs7dzWq576zl+TgzeAEbdOSXNzuF6LJvI5SdT o8Yjv+kTBl2SHH7RBOToy2GpGQAxxIs64pU5qZLA9qLKlpNTgq2BSpqwtzegGwkSoZ7P QghhPy9j9i1DVjnuQrFZpBn9L2xkWkKFYAjtKnOavRXAt85WNvGiLdvWKhqhOdRxYlLO 2Mkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=Gw6uvbA+nP0GpDH+JIrpbJCrJ1M28JW12F5oS/lMF7Q=; fh=HNIqzTA9Dp00ovCAyCdXfuEvWDT00OlFxFRPLybXRis=; b=oyqpKmwGcsm/Nj438rZ7x/qBU0F0v3FH3zZ0KymrhbJxWl/TQzdsKzRnTeuOTqDt24 6OFe8w+8r/PIU4IXKvGku/GuzA0IyfTVqn0J8CLRHBLPurFtnM/fXMIPTm1npMZ27loz 3PrSuy2vAXXsXdPqdXESwyU5aFKZHxCFIrjT2l/AQybjqMzzF0Lc0v3R4tjtIRent06f ZLbvSSTJDbN6jZ0rqaxAlAHxFzDhtVAgW/YOK0Ql54Sy3NiNMxFmUMmjb1vpni02M0w1 A6Cxt6E0RtgPImoOhfCKrC2jcMjYocbOgZffp4b9u2s9ocXcsgA9gtlOqG03Ur4scQ8s +5DQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=YroHbalu; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id a7-20020aa7d747000000b005223cf584b9si951704eds.482.2023.08.03.04.46.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 04:46:46 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=YroHbalu; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A4925385C6E2 for ; Thu, 3 Aug 2023 11:46:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A4925385C6E2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1691063167; bh=Gw6uvbA+nP0GpDH+JIrpbJCrJ1M28JW12F5oS/lMF7Q=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=YroHbalu/iPScW9FmQvn1b3fK597tAqcj7fEVcWC3qE4UJHCLpNBsf9JEWhmwnNgZ f7ugrEfwFvuWvIBHZGHGR4RsDMgud5revOTJzQS0azm3N2q3lafgwM7tSDnjH5U2/P WbJ8R9E212WrEXpng+1DcsU+4t3dCnVFzsLYo7VY= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by sourceware.org (Postfix) with ESMTPS id 9E1E9385842D for ; Thu, 3 Aug 2023 11:44:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E1E9385842D Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1b8ad356f03so5903965ad.1 for ; Thu, 03 Aug 2023 04:44:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691063055; x=1691667855; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Gw6uvbA+nP0GpDH+JIrpbJCrJ1M28JW12F5oS/lMF7Q=; b=jOcXOA2sUX/Unci/NRLAJ+sABTwklmt6+vR0LlfrALOt4RjuY4MUhZHtk67j39Th2N /u+IiAOT1Gphcrj/BpS6bF0SDdnDB7WNdk9pziXoXdK7HHIn15FrdEY8Ao8ZUshW1u6C HfgGnIKeRKLhV5duJFz0kzC6y4uzhEpW3Jc/JlNlAygN3BUiPi5p4eep8NLP3adix685 TeYanH/AY3kF8VZB+rMAnEd2KJfRyY2gLeRremMZ/vyM7sIBZ3dBmTltakzyzPCHe/aP bUo353T3cUkGjNKWU9p65IXRYK1+PAka28pIqWgSIxeRdkbrY5Lrx75Y2B6A+IrGkn7w 33+w== X-Gm-Message-State: ABy/qLbzEALHGiZ4kWNBOaU+62L3N+ggs/FWSlRkFRJzgswBMQhuYD6o 2N5kRYgF3DX9Gm8YSM1ICG7gDb7DT/c= X-Received: by 2002:a17:902:e74f:b0:1b8:6cae:4400 with SMTP id p15-20020a170902e74f00b001b86cae4400mr19522793plf.37.1691063054785; Thu, 03 Aug 2023 04:44:14 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id e3-20020a170902b78300b001b9df8f2907sm14183131pls.264.2023.08.03.04.44.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 04:44:14 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id E8CA611427AD; Thu, 3 Aug 2023 21:14:11 +0930 (ACST) Date: Thu, 3 Aug 2023 21:14:11 +0930 To: binutils@sourceware.org Subject: dlltool: sprintf sanitizer null destination pointer Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3034.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773208292914426263 X-GMAIL-MSGID: 1773208292914426263 * dlltool.c (gen_lib_file): Avoid bogus sanitizer error. diff --git a/binutils/dlltool.c b/binutils/dlltool.c index 142d43aff81..efa54f1bd72 100644 --- a/binutils/dlltool.c +++ b/binutils/dlltool.c @@ -3089,20 +3089,22 @@ gen_lib_file (int delay) if (dontdeltemps < 2) { char *name; + size_t stub_len = strlen (TMP_STUB); - name = xmalloc (strlen (TMP_STUB) + 10); + name = xmalloc (stub_len + 10); + memcpy (name, TMP_STUB, stub_len); for (i = 0; (exp = d_exports_lexically[i]); i++) { /* Don't delete non-existent stubs for PRIVATE entries. */ if (exp->private) continue; - sprintf (name, "%s%05d.o", TMP_STUB, i); + sprintf (name + stub_len, "%05d.o", i); if (unlink (name) < 0) /* xgettext:c-format */ non_fatal (_("cannot delete %s: %s"), name, strerror (errno)); if (ext_prefix_alias) { - sprintf (name, "%s%05d.o", TMP_STUB, i + PREFIX_ALIAS_BASE); + sprintf (name + stub_len, "%05d.o", i + PREFIX_ALIAS_BASE); if (unlink (name) < 0) /* xgettext:c-format */ non_fatal (_("cannot delete %s: %s"), name, strerror (errno));