From patchwork Thu Aug 3 11:43:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 130506 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp1087904vqx; Thu, 3 Aug 2023 04:45:18 -0700 (PDT) X-Google-Smtp-Source: APBJJlFd4EwJaF2eBFh+KTvEuudgt5fjG8fPajNI5AL+H/ukqhi1tudQvE/82/Y7q4FtTItlBuqL X-Received: by 2002:a17:906:31d4:b0:99c:22e9:fbe3 with SMTP id f20-20020a17090631d400b0099c22e9fbe3mr7579898ejf.60.1691063117879; Thu, 03 Aug 2023 04:45:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691063117; cv=none; d=google.com; s=arc-20160816; b=U+TetulfkZP68ZwkxLs4YPSTV/ljyuF6bAkgQ2A9mOQ2FNbPH/0aX9E12CQbVkRg9b 8ngx+u5qrn0Py52k2IoGYjIJB6MbGFPk912aMvQ98WOMI2tYX5NAH5fpZGKalJQlafFI m9SqEusVVg5Gsy4BTx8ZaC7+nhT7zRtSeIXxWG0u6iGygqPslC8S/VbNJa4pRqRKwvJe 9o9v+PD467VYvFU+fCYi/TGTDoFnSY1Tvvfm47XRDX6tQ0cMswHLfWmh6iiZ6G18BXIL +JdGxJvS+6wEUKRARZhKVDAORaKanqWjj8sz6tLji+WK7g3MQZJ24tl3pRPfTC+M43vr BDyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=V8OIxvxYsgOav56f9elOXHu7wuPWm2NFkQ10iF+ZJ74=; fh=HNIqzTA9Dp00ovCAyCdXfuEvWDT00OlFxFRPLybXRis=; b=ovozYH8geQjiPkyp6F4Bz9xurEwHJZyK6bAy39ZsThGRlRRhRRYFrP5HcOv85IvY+V EqcAd+ScgYIY/yJMn2iOZHXterBLf2KTibQA6dCCDOg1GJ4+cZq9G49JLie+uBc1jmsL J+r3A5QPODMJdy86UmUlWasDlP2ZABjEzyjibn5nenw4+5HviohCrEHCn89B+jmqQsSw OPsPeWOE/rBaf5/tRsAS+qBDNLOypP3mmzmQnDT6nbQlb+GO3DQANipAyaAkoRqBHw8l lWhqJjKG3VFz/1kbAXjSAfMwB1qxxCzL/BNTNSeOkbOUApgMSEzzaR7bIPGGkw7wayf7 b0Yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=b8U3XWK2; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id j25-20020a170906255900b0098f99532db7si9148428ejb.673.2023.08.03.04.45.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 04:45:17 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=b8U3XWK2; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A1EE038582AC for ; Thu, 3 Aug 2023 11:45:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A1EE038582AC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1691063108; bh=V8OIxvxYsgOav56f9elOXHu7wuPWm2NFkQ10iF+ZJ74=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=b8U3XWK2V47Vc009H42InlLyYKchLYzae6XPCN7hyl768ESa96TGNiZ3b9R8MCumE lG3f66hDZ0hexYUTX9CLmP7j2uUKOM4IOiGNpNkMpjFGio8kUUw0A2jbHwwMqwNO6c LKEgKdSzZmCDCqW9rUbjsSgrZivdiCOv3wmJ7HAY= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id 0DCDA3857806 for ; Thu, 3 Aug 2023 11:43:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0DCDA3857806 Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-68706b39c4cso556671b3a.2 for ; Thu, 03 Aug 2023 04:43:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691063025; x=1691667825; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V8OIxvxYsgOav56f9elOXHu7wuPWm2NFkQ10iF+ZJ74=; b=GGVt4xVrJ/XgzhPMPocDxJvF4XPqjY0iMvuESvTOHwiAn6pH+JNDd61xMI0xHAtqIt rbhiu8NmWfpPWC9+KM5cFnJEUiRccL47z1bqOh2zXRKBGSogmiPBfZhBW2t8b1Yl6N0b eHa8g3GhcBvV+Nuo44QO5hNbmnAlXrZoqpZf3oQXDnnQtzOup5cQX0N8QRnBCEvLQ7uW fmau6WYkVStd8LY2Xv5/O0+PlkKAgDwHffioPur4nPiBOKBKs2SzrBPRoO+lkIsZtsiz H8Blsse/zh7hmYyNfQwM8ViIt8/N8T8e6hxEHRQ4AXgt+muAng49GZorDXtTf9D/xQBo Rb4g== X-Gm-Message-State: ABy/qLZr2MWfQFnAnv9Hkul4oT1t0hLoZmUC4NirTBXBitiK1b/3Ecyd szV6BMHsMRqRBTSc4T40k2EvbtQpl5c= X-Received: by 2002:a17:902:7595:b0:1bb:cd10:823a with SMTP id j21-20020a170902759500b001bbcd10823amr14756357pll.39.1691063025463; Thu, 03 Aug 2023 04:43:45 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id o3-20020a170902d4c300b001b9d8688956sm14183976plg.144.2023.08.03.04.43.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 04:43:44 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id B022911427AD; Thu, 3 Aug 2023 21:13:42 +0930 (ACST) Date: Thu, 3 Aug 2023 21:13:42 +0930 To: binutils@sourceware.org Subject: wrstabs: sprintf sanitizer null destination pointer Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3034.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773208200212508602 X-GMAIL-MSGID: 1773208200212508602 gcc-2.12 seems to be ignoring __attribute__((__returns_nonnull__)) on xmalloc. * wrstabs.c (stab_method_type): Use stpcpy rather than sprintf or strcat. diff --git a/binutils/wrstabs.c b/binutils/wrstabs.c index 234a96f98a3..955b610cd59 100644 --- a/binutils/wrstabs.c +++ b/binutils/wrstabs.c @@ -1202,17 +1202,21 @@ stab_method_type (void *p, bool domainp, int argcount, len += strlen (args[i]); buf = xmalloc (len); - - sprintf (buf, "#%s,%s", domain, return_type); + char *out = buf; + *out++ = '#'; + out = stpcpy (out, domain); + *out++ = ','; + out = stpcpy (out, return_type); free (domain); free (return_type); for (i = 0; i < argcount; i++) { - strcat (buf, ","); - strcat (buf, args[i]); + *out++ = ','; + out = stpcpy (out, args[i]); free (args[i]); } - strcat (buf, ";"); + *out++ = ';'; + *out = 0; free (args);