From patchwork Wed Jul 19 01:42:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 122356 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp2130539vqt; Tue, 18 Jul 2023 18:43:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlF2poT/6w/9YfKuOc8AIucKghEhT4J4rq1Ro6EX36m41v+DM3H7vnXCLNOZKOF35guRWJd1 X-Received: by 2002:a17:906:8488:b0:970:1b2d:45cc with SMTP id m8-20020a170906848800b009701b2d45ccmr997575ejx.57.1689730989250; Tue, 18 Jul 2023 18:43:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689730989; cv=none; d=google.com; s=arc-20160816; b=Bldf9z0TW9kyQqAjEEvSzCEQuUM2c+yv8cbSwAzoDy60AlNYh5M0DPGQXt44x+00jx BQILW9tYuHlFJNDyYGVFaBs1SYtsfX7AHf3O2lSmKgo6uc+Jk5pHvTpXsTFDVC1p4loC nn2M5evKSoRv3X6w9qMv8y615MRIkwXpE+pGTzmF974dsyMsLfaV/KeAmgE5hOGpaDdL BsqZWGsAwVYroehBzbKzyvh+W94t8QKF13cqCfjmOahqHx6eMteCcwFcWoav3zbRNmpW bp0HhY5MqznCaRUTPke/u7GVzkylJfqWAPjTxw7qN3n/0Z/lD6LthOtGburv/Bc1f5nH FrRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=FaWqSajwpix7DJlgY9wSMY/1bCkOIxnS6PlAr/kQ84I=; fh=HNIqzTA9Dp00ovCAyCdXfuEvWDT00OlFxFRPLybXRis=; b=v3TCcQSpDgSLGTWqhpgiCD9qDXWqROieN7FL0sOW+kYwomt1UsLU274v3CmYkXfN3R Mmk8bEO9s+3dgo6dQpHQSdJIIbAhT73PxRtm7sOCrOQpxcO09anGkYEpznkFz4dZW4Sb kGFq8Td24kfLDw2d4kOLUHKleEey6asqTwNvjU5KiGwj/OJyZ7690+z9xuwb+AbSgPSJ DmlvZX7MnAlByGEbgiDZXJatPlDAGWcMtRcmspO1wBrFKs/C3HlyIi6YV8ttByd9dM23 Om06mXu4VsGWI3F7By+oGKOynH8kw4NGb7ofvrcjEojGDf0vbMQOWTkF7lYjvZTIPRvW EYFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=OWWtzN2I; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id lr23-20020a170906fb9700b00997124ebc83si2197621ejb.6.2023.07.18.18.43.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 18:43:09 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=OWWtzN2I; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6B31538515DB for ; Wed, 19 Jul 2023 01:42:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6B31538515DB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1689730944; bh=FaWqSajwpix7DJlgY9wSMY/1bCkOIxnS6PlAr/kQ84I=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=OWWtzN2I4ZEz4+sctU0L5A/jkFBRhqjKDahdP4HNmLVDQaoV9kaigA15G1HNvYSLt SVBClHDDgQ4cVvwO9VgaKmpXOj/yDKbB3fwg2SNHGtRHXqXrSb7qJJXK+/Rx2PLb/E JP/SBcN4t5kE9zSq87VWC4vZE1dxGyuRrLajso+k= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id 723AF3853D29 for ; Wed, 19 Jul 2023 01:42:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 723AF3853D29 Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1b8bd586086so51206535ad.2 for ; Tue, 18 Jul 2023 18:42:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689730933; x=1692322933; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FaWqSajwpix7DJlgY9wSMY/1bCkOIxnS6PlAr/kQ84I=; b=MDag66JN0Jw2Uso7JkIdz/d7SBR4yEYiZzTgUKmyLO/V73gqjqOZ+3llmue69P+9AP ewMNIftEI/a3+VSb2xdJXkJXCHjvQ1Z++SrVIQQoGNG9a0IirvjTBM9lr1zVLU4rTrMs gBL4VO6amvTpQm0IGIvkpSDJm3q6yTZqM9IUDgZtI9YO0f/1QjPqvED50JJBttfP0/JZ 0oyOp2mTI2nYSwjNPmIs0At3ocgIm5JJQscXg5fqOH1y0euFoccqGcEVy11/P2EBgU56 I8WIUDHFhZ50av3a6HajwWc9HweoXMZGQ/9mfed9yckkcKf7tivCKhMNC3MRyivP7g+F fGLw== X-Gm-Message-State: ABy/qLa8wvw1WmCpY78tvmUs4u8A9mhhRbyIxmV0eOkqxc1aw/bcSdEX yyqwX0PXp2G4BoE4hfC0cln4nVemM1I= X-Received: by 2002:a17:90a:77cb:b0:262:b3b8:7c3d with SMTP id e11-20020a17090a77cb00b00262b3b87c3dmr859628pjs.16.1689730933349; Tue, 18 Jul 2023 18:42:13 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id s13-20020a17090a440d00b00263154aab24sm160805pjg.57.2023.07.18.18.42.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 18:42:12 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 9F5F81142A4E; Wed, 19 Jul 2023 11:12:10 +0930 (ACST) Date: Wed, 19 Jul 2023 11:12:10 +0930 To: binutils@sourceware.org Subject: [GOLD, PowerPC64] Debug info relocation overflow Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3034.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771811361660817141 X-GMAIL-MSGID: 1771811361660817141 It is possible to build huge binaries on powerpc64, where 32-bit addresses in debug info are insufficient to descibe locations in the binary. Help out the user, and only warn about debug overflows. * powerpc.cc (Target_powerpc::Relocate::relocate): Warn on relocation overflows in debug info. diff --git a/gold/powerpc.cc b/gold/powerpc.cc index 96fef7b8dde..d62bdea7ecb 100644 --- a/gold/powerpc.cc +++ b/gold/powerpc.cc @@ -12420,10 +12420,19 @@ Target_powerpc::Relocate::relocate( && gsym->is_undefined() && is_branch_reloc(r_type)))) { - gold_error_at_location(relinfo, relnum, rela.get_r_offset(), - _("relocation overflow")); - if (has_stub_value) - gold_info(_("try relinking with a smaller --stub-group-size")); + if (os->flags() & elfcpp::SHF_ALLOC) + { + gold_error_at_location(relinfo, relnum, rela.get_r_offset(), + _("relocation overflow")); + if (has_stub_value) + gold_info(_("try relinking with a smaller --stub-group-size")); + } + else + { + gold_warning_at_location(relinfo, relnum, rela.get_r_offset(), + _("relocation overflow")); + gold_info(_("debug info may be unreliable, compile with -gdwarf64")); + } } return true;