macho-o.c don't leak strtab

Message ID ZJKWtMcKv3ZBw0Cq@squeak.grove.modra.org
State Accepted
Headers
Series macho-o.c don't leak strtab |

Checks

Context Check Description
snail/binutils-gdb-check success Github commit url

Commit Message

Alan Modra June 21, 2023, 6:20 a.m. UTC
  * mach-o.c (bfd_mach_o_write_symtab_content): Free strtab on
	success path.
  

Patch

diff --git a/bfd/mach-o.c b/bfd/mach-o.c
index 55407fa347d..4d414fd95db 100644
--- a/bfd/mach-o.c
+++ b/bfd/mach-o.c
@@ -2073,6 +2073,8 @@  bfd_mach_o_write_symtab_content (bfd *abfd, bfd_mach_o_symtab_command *sym)
   if (!_bfd_stringtab_emit (abfd, strtab))
     goto err;
 
+  _bfd_stringtab_free (strtab);
+
   /* Pad string table.  */
   padlen = bfd_mach_o_pad4 (abfd, sym->strsize);
   if (padlen < 0)