From patchwork Thu Jun 15 02:40:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 108238 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp354818vqr; Wed, 14 Jun 2023 19:40:30 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7Rcf4Wzn/hOKUhrDQTTGdA4elQHN97QodTTAHC/PNrTaN6lvijaZKYlQ6oFf3HNqqct8F+ X-Received: by 2002:a17:907:97c6:b0:961:800b:3f1e with SMTP id js6-20020a17090797c600b00961800b3f1emr19345744ejc.73.1686796830706; Wed, 14 Jun 2023 19:40:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686796830; cv=none; d=google.com; s=arc-20160816; b=zYcBN2nIbv5s+0L6ut15ZAAbIFGrmlAEJfDiCB5tRrK7nisGxo2Cdz1AKl575BbeO8 EbeQ2mkpgfjR2t/hOoBSKhM1q2ygifDm/PIDEaVAS2Vlr8bQW8H7LI8IMlkf695z8pOa YsNlHSPmeNM7uApyDpsaq5mdszmJ9dwQBg7e0KKFx7/b0AUcGYNgV9SNKD1a307Rg15H G4eK1Zkix4rdcR4PsppGq1C5DH6nOcP4VqPbz54r/qUbmo8zFKZWaMEldfPsskRECatL nv5wkGfg8tntlDorAyT3pXaHWI/VTpuRY/Mpd/FDrYChdKo17V57eaSsMLm+h/E/lnyg p2bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=6GgGZFBaWqVTFOKw7gVuzmbboSHMTIErAgsAQdOEDts=; b=eBZFVWo0Mq93T56WkDg2iPn3ODb/MXPuLNdZdUMjN0isDW+pjWuFfkI1K+0WQEX7oV CB5pNt8223ljeBAgY7LAeRUzu/p3XbYO9EJWJJ4wRNMx6sXySmKKNzw4VkxQbdj91/9A w6UNSQyZnUB20vdxNUKswf/argFkhzcq+JXPvQ5hy31pF6A0vOguCZP+mPi1oJWoHFce /i7mkIwcVLCQsI16MOWAMCySmXT6ZQnL7QS7akwQQVeClDxYnq+nI3GZwN/ozw/E8SCz DSZ2fplsDUC0R4XNKYBrAaGyyEW8MVPbr+TxLuuMnMdMz7H/yiQain+yCl5hzd41lAcl 6wKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=WjFSWpo2; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id w12-20020aa7d28c000000b005149d398b2bsi8982038edq.585.2023.06.14.19.40.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 19:40:30 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=WjFSWpo2; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 59E0838582BC for ; Thu, 15 Jun 2023 02:40:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 59E0838582BC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1686796829; bh=6GgGZFBaWqVTFOKw7gVuzmbboSHMTIErAgsAQdOEDts=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=WjFSWpo2sMFqRUGNMhKwZPV/BqeSPfHJ+FMqNz8a7+oqqF4FhFETOLSoBm8HnR2gJ K0QtyVsPFKnTl5kDqPfAloPaoP50qumORZL9S8ai0n3ZUjSsUrO3b3YM6Y5i322Vik zOJ/qUtKl+Pr9aIKntvJguCIKl1RJAkXix5ewOW0= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by sourceware.org (Postfix) with ESMTPS id 121B13858C1F for ; Thu, 15 Jun 2023 02:40:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 121B13858C1F Received: by mail-qt1-x830.google.com with SMTP id d75a77b69052e-3f9baa69682so25418981cf.3 for ; Wed, 14 Jun 2023 19:40:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686796820; x=1689388820; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6GgGZFBaWqVTFOKw7gVuzmbboSHMTIErAgsAQdOEDts=; b=Zxa0sNRoN27KqHU6qPpCVvqUmcmQJZIIPpJ2aNFnsJCZd7eM8QXTYLUuUBT8jsJhkA WhgQ0aIpYuPzOgW3PXl7SJW9w/tpNkE0xNw5p5IIvZJ5tFo+k8SxXo2SjSt4+p0W7JiJ gbHq+a3imnK2F37RyiuFO5DvaIESB5fUg5neRtpC5VqdSTzipSGCPrCeY0zZmzinbcwQ h11sbdGtLjk0U0qbRlv2t6K6DbWH2/xz+z3bE1BPzRMsrmec3EIB4QijPsqF48Lup4Zs Ol71fVm2DiK6si8N3fU/3NZ9BlLB+lhUiSX8n1eKtWrjQyAwrUeY7RyqnN/uPvfRVko0 Qtpw== X-Gm-Message-State: AC+VfDxh4YyJyRQ5SRIUpKgM0uEwCgVxo+vLD0+GF/8LqNy37fyqcNfC 7k1R2rd9PbdARaK5V8GSGZHjX5/RsbU= X-Received: by 2002:a05:622a:174d:b0:3f8:365:7aa3 with SMTP id l13-20020a05622a174d00b003f803657aa3mr4759505qtk.3.1686796819775; Wed, 14 Jun 2023 19:40:19 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id j24-20020a62b618000000b00643889e30c2sm10969248pff.180.2023.06.14.19.40.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 19:40:19 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 582051142B9E; Thu, 15 Jun 2023 12:10:15 +0930 (ACST) Date: Thu, 15 Jun 2023 12:10:15 +0930 To: binutils@sourceware.org Subject: vms write_archive memory leaks Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3034.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768734673334694669?= X-GMAIL-MSGID: =?utf-8?q?1768734673334694669?= This fixes two memory leaks in the vms archive handling code. * vms-lib.c (_bfd_vms_lib_build_map): Free input symbols. (_bfd_vms_lib_write_archive_contents): Free archive map symbols. diff --git a/bfd/vms-lib.c b/bfd/vms-lib.c index ab938768ebe..298e959b8b9 100644 --- a/bfd/vms-lib.c +++ b/bfd/vms-lib.c @@ -2108,6 +2108,7 @@ _bfd_vms_lib_build_map (unsigned int nbr_modules, *res_cnt = map_count; *res = map; + free (syms); return true; error_return: @@ -2394,6 +2395,7 @@ _bfd_vms_lib_write_archive_contents (bfd *arch) goto err; } + free (symbols); return true; input_err: