Remove BFD_FAIL in cpu-sh.c

Message ID ZHfmQsTZbxX1yUIq@squeak.grove.modra.org
State Accepted
Headers
Series Remove BFD_FAIL in cpu-sh.c |

Checks

Context Check Description
snail/binutils-gdb-check success Github commit url

Commit Message

Alan Modra June 1, 2023, 12:28 a.m. UTC
  The assertions in cpu-sh.c can be triggered by passing bogus values
in disassemble_info.mach.  This doesn't cause any bfd misbehaviour.

	* cpu-sh.c (sh_get_arch_from_bfd_mach): Remove BFD_FAIL.
	(sh_get_arch_up_from_bfd_mach): Likewise.
  

Patch

diff --git a/bfd/cpu-sh.c b/bfd/cpu-sh.c
index afea21a8dac..578ff086c3f 100644
--- a/bfd/cpu-sh.c
+++ b/bfd/cpu-sh.c
@@ -117,9 +117,6 @@  sh_get_arch_from_bfd_mach (unsigned long mach)
     else
       i++;
 
-  /* Machine not found.   */
-  BFD_FAIL();
-
   return SH_ARCH_UNKNOWN_ARCH;
 }
 
@@ -139,9 +136,6 @@  sh_get_arch_up_from_bfd_mach (unsigned long mach)
     else
       i++;
 
-  /* Machine not found.  */
-  BFD_FAIL();
-
   return SH_ARCH_UNKNOWN_ARCH;
 }