diff mbox series

Yet another ecoff fuzzed object fix

Message ID ZH2Mwib11IEH7JDu@squeak.grove.modra.org
State Unresolved
Headers
Series Yet another ecoff fuzzed object fix |

Checks

Context Check Description
snail/binutils-gdb-check warning Git am fail log

Commit Message

Alan Modra June 5, 2023, 7:20 a.m. UTC 
  * ecoff.c (_bfd_ecoff_slurp_symbol_table): Sanity check fdr_ptr
	csym against remaining space for symbols.  Error on out of bounds
	fdr_ptr fields.
diff mbox series

Patch

diff --git a/bfd/ecoff.c b/bfd/ecoff.c
index c4c2e530be0..573f52d0299 100644
--- a/bfd/ecoff.c
+++ b/bfd/ecoff.c
@@ -956,13 +956,19 @@  _bfd_ecoff_slurp_symbol_table (bfd *abfd)
       char *lraw_end;
       HDRR *symhdr = &ecoff_data (abfd)->debug_info.symbolic_header;
 
+      if (fdr_ptr->csym == 0)
+	continue;
       if (fdr_ptr->isymBase < 0
 	  || fdr_ptr->isymBase > symhdr->isymMax
-	  || fdr_ptr->csym <= 0
-	  || fdr_ptr->csym > symhdr->isymMax - fdr_ptr->isymBase
+	  || fdr_ptr->csym < 0
+	  || fdr_ptr->csym > ((long) bfd_get_symcount (abfd)
+			      - (internal_ptr - internal))
 	  || fdr_ptr->issBase < 0
 	  || fdr_ptr->issBase > symhdr->issMax)
-	continue;
+	{
+	  bfd_set_error (bfd_error_bad_value);
+	  return false;
+	}
       lraw_src = ((char *) ecoff_data (abfd)->debug_info.external_sym
 		  + fdr_ptr->isymBase * external_sym_size);
       lraw_end = lraw_src + fdr_ptr->csym * external_sym_size;